GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix typo in binding functions by deokjinkim · Pull Request #48003 · nodejs/node

Conversation

@deokjinkim

@deokjinkim deokjinkim commented May 14, 2023

Copy link
Copy Markdown
Contributor

According to usage(node::util::RegisterExternalReferences) of below line, namespace has to be util(not utils).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@deokjinkim
doc: fix typo in binding functions
20bc618 
According to usage(node::util::RegisterExternalReferences) of
below line, namespace has to be `util`(not `utils`).
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 14, 2023
RaisinTen
RaisinTen approved these changes May 14, 2023
View reviewed changes
@deokjinkim deokjinkim added doc Issues and PRs related to Node.js documentation. author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 15, 2023
daeyeon
daeyeon approved these changes May 15, 2023
View reviewed changes
HarshithaKP
HarshithaKP approved these changes May 15, 2023
View reviewed changes
@deokjinkim deokjinkim added the commit-queue PRs queued for automated landing through the Commit Queue. label May 15, 2023
lpinca
lpinca approved these changes May 15, 2023
View reviewed changes
aymen94
aymen94 approved these changes May 16, 2023
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 16, 2023
@nodejs-github-bot
nodejs-github-bot merged commit d2c4518 into nodejs:main May 16, 2023
@nodejs-github-bot

nodejs-github-bot commented May 16, 2023

Copy link
Copy Markdown
Collaborator

Landed in d2c4518
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 30, 2023
@deokjinkim @targos
doc: fix typo in binding functions
7660eb5 
According to usage(node::util::RegisterExternalReferences) of
below line, namespace has to be `util`(not `utils`).

PR-URL: #48003
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@deokjinkim @danielleadams
doc: fix typo in binding functions
ae93be9 
According to usage(node::util::RegisterExternalReferences) of
below line, namespace has to be `util`(not `utils`).

PR-URL: #48003
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@deokjinkim @MoLow
doc: fix typo in binding functions
ce859f9 
According to usage(node::util::RegisterExternalReferences) of
below line, namespace has to be `util`(not `utils`).

PR-URL: nodejs#48003
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@daeyeon daeyeon daeyeon approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
@HarshithaKP HarshithaKP HarshithaKP approved these changes
+1 more reviewer
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@deokjinkim @nodejs-github-bot @lpinca @daeyeon @aymen94 @RaisinTen @HarshithaKP
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.