GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: open issue when update workflow fails by marco-ippolito · Pull Request #48018 · nodejs/node

Conversation

@marco-ippolito

@marco-ippolito marco-ippolito commented May 15, 2023

Copy link
Copy Markdown
Member

Refs: nodejs/security-wg#973

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Giangpro89 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@marco-ippolito
tools: open issue when update workflow fails
3316d89
@nodejs-github-bot

nodejs-github-bot commented May 15, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
Giangpro89 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 15, 2023
@targos

targos commented May 15, 2023

Copy link
Copy Markdown
Member

Can you add a link to the failed run in the message?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@marco-ippolito

marco-ippolito commented May 15, 2023

Copy link
Copy Markdown
Member Author

Can you add a link to the failed run in the message?

Yes I'm figuring out how to

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@marco-ippolito
marco-ippolito force-pushed the feat/issue--deps-update-fail branch from 3d7d0a4 to 3dcab0a Compare May 15, 2023 14:16
@marco-ippolito
feat: add job url
8df8fbc
@marco-ippolito
marco-ippolito force-pushed the feat/issue--deps-update-fail branch from 3dcab0a to 8df8fbc Compare May 15, 2023 14:19
@marco-ippolito
marco-ippolito marked this pull request as ready for review May 15, 2023 18:02
tniessen
tniessen reviewed May 16, 2023
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/failed-dep-update.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread .github/workflows/tools.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@marco-ippolito
fix: open issue only when scheduled
f6acfa9
UlisesGascon
UlisesGascon approved these changes May 17, 2023
View reviewed changes
@UlisesGascon UlisesGascon mentioned this pull request May 17, 2023
Dependency update automation improvements nodejs/security-wg#973
Closed
7 of 9 tasks
@marco-ippolito
marco-ippolito requested review from richardlau, targos and tniessen May 22, 2023 08:04
richardlau
richardlau approved these changes May 22, 2023
View reviewed changes
@marco-ippolito marco-ippolito added the commit-queue PRs queued for automated landing through the Commit Queue. label May 25, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels May 25, 2023
@nodejs-github-bot

nodejs-github-bot commented May 25, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/48018
✔  Done loading data for nodejs/node/pull/48018
----------------------------------- PR info ------------------------------------
Title      tools: open issue when update workflow fails (#48018)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:feat/issue--deps-update-fail -> nodejs:main
Labels     meta
Commits    3
 - tools: open issue when update workflow fails
 - feat: add job url
 - fix: open issue only when scheduled
Committers 1
 - Marco Ippolito 
PR-URL: https://github.com/nodejs/node/pull/48018
Refs: https://github.com/nodejs/security-wg/issues/973
Reviewed-By: Richard Lau 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48018
Refs: https://github.com/nodejs/security-wg/issues/973
Reviewed-By: Richard Lau 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 15 May 2023 12:48:43 GMT
   ✔  Approvals: 1
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/48018#pullrequestreview-1436488602
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 48018
From https://github.com/nodejs/node
 * branch                  refs/pull/48018/merge -> FETCH_HEAD
✔  Fetched commits as 442c35215f2b..f6acfa9a14e8
--------------------------------------------------------------------------------
[main d2fa33066e] tools: open issue when update workflow fails
 Author: Marco Ippolito 
 Date: Mon May 15 14:47:27 2023 +0200
 2 files changed, 17 insertions(+)
 create mode 100644 .github/ISSUE_TEMPLATE/failed-dep-update.yml
[main dea82e74ac] feat: add job url
 Author: Marco Ippolito 
 Date: Mon May 15 16:02:35 2023 +0200
 3 files changed, 9 insertions(+), 8 deletions(-)
 create mode 100644 .github/ISSUE_TEMPLATE/failed-dep-update.md
 delete mode 100644 .github/ISSUE_TEMPLATE/failed-dep-update.yml
[main 04d4a5479d] fix: open issue only when scheduled
 Author: Marco Ippolito 
 Date: Tue May 16 10:15:55 2023 +0200
 2 files changed, 2 insertions(+), 2 deletions(-)
 rename .github/{ISSUE_TEMPLATE/failed-dep-update.md => FAILED_DEP_UPDATE_ISSUE_TEMPLATE.md} (100%)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: open issue when update workflow fails

PR-URL: #48018
Refs: nodejs/security-wg#973
Reviewed-By: Richard Lau [email protected]

[detached HEAD af671790e2] tools: open issue when update workflow fails
Author: Marco Ippolito [email protected]
Date: Mon May 15 14:47:27 2023 +0200
2 files changed, 17 insertions(+)
create mode 100644 .github/ISSUE_TEMPLATE/failed-dep-update.yml
Rebasing (3/6)
Rebasing (4/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
feat: add job url

PR-URL: #48018
Refs: nodejs/security-wg#973
Reviewed-By: Richard Lau [email protected]

[detached HEAD 6f763880de] feat: add job url
Author: Marco Ippolito [email protected]
Date: Mon May 15 16:02:35 2023 +0200
3 files changed, 9 insertions(+), 8 deletions(-)
create mode 100644 .github/ISSUE_TEMPLATE/failed-dep-update.md
delete mode 100644 .github/ISSUE_TEMPLATE/failed-dep-update.yml
Rebasing (5/6)
Rebasing (6/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fix: open issue only when scheduled

PR-URL: #48018
Refs: nodejs/security-wg#973
Reviewed-By: Richard Lau [email protected]

[detached HEAD 732bb54197] fix: open issue only when scheduled
Author: Marco Ippolito [email protected]
Date: Tue May 16 10:15:55 2023 +0200
2 files changed, 2 insertions(+), 2 deletions(-)
rename .github/{ISSUE_TEMPLATE/failed-dep-update.md => FAILED_DEP_UPDATE_ISSUE_TEMPLATE.md} (100%)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5077383983

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@marco-ippolito marco-ippolito added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels May 25, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit c488558 into nodejs:main May 25, 2023
@nodejs-github-bot

nodejs-github-bot commented May 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in c488558

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request May 30, 2023
@marco-ippolito @targos
tools: open issue when update workflow fails
db62325
PR-URL: #48018
Refs: nodejs/security-wg#973
Reviewed-By: Richard Lau <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@marco-ippolito @danielleadams
tools: open issue when update workflow fails
340073d
PR-URL: #48018
Refs: nodejs/security-wg#973
Reviewed-By: Richard Lau <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@marco-ippolito @MoLow
tools: open issue when update workflow fails
9aed868
PR-URL: nodejs#48018
Refs: nodejs/security-wg#973
Reviewed-By: Richard Lau <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@marco-ippolito @Ceres6
tools: open issue when update workflow fails
4e085e1
PR-URL: nodejs#48018
Refs: nodejs/security-wg#973
Reviewed-By: Richard Lau <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@marco-ippolito @Ceres6
tools: open issue when update workflow fails
14920d0
PR-URL: nodejs#48018
Refs: nodejs/security-wg#973
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes
@richardlau richardlau richardlau approved these changes
@tniessen tniessen Awaiting requested review from tniessen
@targos targos Awaiting requested review from targos

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@marco-ippolito @nodejs-github-bot @targos @tniessen @UlisesGascon @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.