GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: display dot report as wide as the terminal width by rluvaton · Pull Request #48038 · nodejs/node

Conversation

@rluvaton

@rluvaton rluvaton commented May 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I had a problem with PR #47901 so recreating it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and tonivj5 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@rluvaton
test_runner: display dot report as wide as the terminal width
c324ad8
@nodejs-github-bot

nodejs-github-bot commented May 16, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 16, 2023
@rluvaton rluvaton mentioned this pull request May 16, 2023
test: display dot report as wide as the terminal width #47901
Closed
MoLow
MoLow reviewed May 17, 2023
View reviewed changes
Comment thread test/fixtures/test-runner/output/dot_output_custom_columns.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow reviewed May 17, 2023
View reviewed changes
Comment thread test/fixtures/test-runner/output/dot_output_custom_columns.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow reviewed May 19, 2023
View reviewed changes
Comment thread lib/internal/test_runner/reporter/dot.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@rluvaton
test_runner: add test and fix error
b47e380
MoLow
MoLow reviewed May 19, 2023
View reviewed changes
Comment thread lib/internal/test_runner/reporter/dot.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@rluvaton @MoLow
Update lib/internal/test_runner/reporter/dot.js
ae1906c 
Co-authored-by: Moshe Atlow <[email protected]>
MoLow
MoLow approved these changes May 19, 2023
View reviewed changes
@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels May 19, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 19, 2023
@nodejs-github-bot

nodejs-github-bot commented May 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51876/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51878/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed May 19, 2023
View reviewed changes
Comment thread test/fixtures/test-runner/output/dot_output_custom_columns.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request May 20, 2023
CI Reliability 2023-05-20 nodejs/reliability#571
Open
19 tasks
@rluvaton @aduh95
Update test/fixtures/test-runner/output/dot_output_custom_columns.js
b991fd2 
Co-authored-by: Antoine du Hamel <[email protected]>
@github-actions github-actions Bot mentioned this pull request May 21, 2023
CI Reliability 2023-05-21 nodejs/reliability#572
Open
19 tasks
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 21, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 21, 2023
@nodejs-github-bot

nodejs-github-bot commented May 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51898/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51899/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig reviewed May 21, 2023
View reviewed changes
Comment thread lib/internal/test_runner/reporter/dot.js
yield 'X';
}
if ((type === 'test:fail' || type === 'test:pass') && ++count % 20 === 0) {
if ((type === 'test:fail' || type === 'test:pass') && ++count === columns) {

@cjihrig cjihrig May 21, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the ++count === columns be nested inside of the top level if? That way we only need to call getLineLength() once from there.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@rluvaton rluvaton May 22, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The need to call again is in case of resize of the terminal

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/fixtures/test-runner/output/dot_output_custom_columns.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/fixtures/test-runner/output/dot_output_custom_columns.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request May 22, 2023
CI Reliability 2023-05-22 nodejs/reliability#573
Open
16 tasks
rluvaton and others added 2 commits May 22, 2023 07:56
@rluvaton @cjihrig
Update test/fixtures/test-runner/output/dot_output_custom_columns.js
d38e661 
Co-authored-by: cjihrig <[email protected]>
@rluvaton @cjihrig
Update test/fixtures/test-runner/output/dot_output_custom_columns.js
ef8cec7 
Co-authored-by: cjihrig <[email protected]>
@MoLow
MoLow requested a review from cjihrig May 22, 2023 15:51
cjihrig
cjihrig approved these changes May 22, 2023
View reviewed changes
@MoLow MoLow added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels May 22, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 22, 2023
@nodejs-github-bot

nodejs-github-bot commented May 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51917/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request May 23, 2023
CI Reliability 2023-05-23 nodejs/reliability#574
Open
22 tasks
@nodejs-github-bot

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51919/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label May 23, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 7e0c12f into nodejs:main May 23, 2023
@nodejs-github-bot

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 7e0c12f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced May 24, 2023
CI Reliability 2023-05-24 nodejs/reliability#575
Open
CI Reliability 2023-05-25 nodejs/reliability#576
Open
CI Reliability 2023-05-26 nodejs/reliability#577
Open
CI Reliability 2023-05-27 nodejs/reliability#578
Open
CI Reliability 2023-05-28 nodejs/reliability#579
Open
CI Reliability 2023-05-29 nodejs/reliability#580
Open
CI Reliability 2023-05-30 nodejs/reliability#581
Open
targos pushed a commit that referenced this pull request May 30, 2023
@rluvaton @targos
test_runner: display dot report as wide as the terminal width
23d310b 
PR-URL: #48038
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@github-actions github-actions Bot mentioned this pull request May 31, 2023
CI Reliability 2023-05-31 nodejs/reliability#582
Open
22 tasks
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
@rluvaton
rluvaton deleted the display-dot-test-report-as-wide-as-the-terminal branch June 28, 2023 17:40
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@rluvaton @danielleadams
test_runner: display dot report as wide as the terminal width
f8cf353 
PR-URL: #48038
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@rluvaton @MoLow
test_runner: display dot report as wide as the terminal width
e0d0b19 
PR-URL: nodejs#48038
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@rluvaton @Ceres6
test_runner: display dot report as wide as the terminal width
7af4903 
PR-URL: nodejs#48038
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@rluvaton @Ceres6
test_runner: display dot report as wide as the terminal width
ac4359d 
PR-URL: nodejs#48038
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments
@cjihrig cjihrig cjihrig approved these changes
@MoLow MoLow MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@rluvaton @nodejs-github-bot @cjihrig @MoLow @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.