GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: align stdout and std error with and without `--test` by MoLow · Pull Request #48057 · nodejs/node

Conversation

@MoLow

@MoLow MoLow commented May 18, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

without --test:
image

before:
image

after (now matching running without --test):
image

same behavior with TAP reporter:

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and HinataKah0 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@MoLow
MoLow requested a review from cjihrig May 18, 2023 12:47
@nodejs-github-bot

nodejs-github-bot commented May 18, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 18, 2023
@cjihrig

cjihrig commented May 18, 2023

Copy link
Copy Markdown
Contributor

Can you add a test (unless we have an existing test) to confirm that colors are not used if the terminal doesn't support, or colors are explicitly disabled. A test to verify that this only impacts the spec reporter would be nice as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow

MoLow commented May 18, 2023

Copy link
Copy Markdown
Member Author

Can you add a test (unless we have an existing test) to confirm that colors are not used if the terminal doesn't support, or colors are explicitly disabled.

all the existing snapshot tests assert that, don't they?

A test to verify that this only impacts the spec reporter would be nice as well.

it impacts all reporters, not only spec reporter. if console.log(1) when running node --test-reporter tap test.js outputs 1 colored - adding --test should behave the same way (inside a diagnostic):

image
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow force-pushed the color_--test branch 4 times, most recently from 98408dc to d0fb5ce Compare May 23, 2023 07:14
@MoLow MoLow added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label May 23, 2023
@MoLow MoLow changed the title test_runner: pass FORCE_COLOR to child process test_runner: align stdout and std error with and without --test May 23, 2023
@MoLow MoLow mentioned this pull request May 23, 2023
test_runner: delegate split message to reporter #48140
Closed
HinataKah0
HinataKah0 reviewed May 23, 2023
View reviewed changes
Comment thread lib/internal/test_runner/reporter/tap.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow force-pushed the color_--test branch from d0fb5ce to 4a3e5b0 Compare May 23, 2023 16:59
@MoLow
MoLow requested review from cjihrig and removed request for cjihrig May 23, 2023 17:01
@MoLow
MoLow force-pushed the color_--test branch from 4a3e5b0 to 5a57936 Compare May 24, 2023 15:15
cjihrig
cjihrig approved these changes May 24, 2023
View reviewed changes
@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels May 24, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 24, 2023
@nodejs-github-bot

nodejs-github-bot commented May 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51950/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ljharb
ljharb reviewed May 24, 2023
View reviewed changes
Comment thread lib/internal/test_runner/reporter/tap.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow force-pushed the color_--test branch from 5a57936 to 4c314bf Compare May 24, 2023 21:16
@MoLow
test_runner: dont split lines on test:stdout
2684dd6
@MoLow
MoLow force-pushed the color_--test branch from 4c314bf to 28dabc9 Compare May 24, 2023 21:20
@MoLow

MoLow commented May 24, 2023

Copy link
Copy Markdown
Member Author

@cjihrig can you re-approve so I can land with the commit queue?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 24, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 24, 2023
This was referenced May 27, 2023
CI Reliability 2023-05-27 nodejs/reliability#578
Open
CI Reliability 2023-05-28 nodejs/reliability#579
Open
CI Reliability 2023-05-29 nodejs/reliability#580
Open
CI Reliability 2023-05-30 nodejs/reliability#581
Open
targos pushed a commit that referenced this pull request May 30, 2023
@MoLow @targos
test_runner: dont split lines on test:stdout
3278542 
PR-URL: #48057
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request May 30, 2023
@MoLow @targos
test_runner: pass FORCE_COLOR to child process
750d3e8 
PR-URL: #48057
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@github-actions github-actions Bot mentioned this pull request May 31, 2023
CI Reliability 2023-05-31 nodejs/reliability#582
Open
22 tasks
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
@danielleadams danielleadams added the backport-requested-v18.x label Jul 6, 2023
@MoLow MoLow added backport-open-v18.x and removed backport-requested-v18.x labels Jul 6, 2023
@MoLow MoLow mentioned this pull request Jul 6, 2023
[v18.x backport] test_runner: align stdout and std error with and without --test #48684
Closed
MoLow added a commit to MoLow/node that referenced this pull request Jul 9, 2023
@MoLow
test_runner: pass FORCE_COLOR to child process
12bb570 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@MoLow @danielleadams
test_runner: pass FORCE_COLOR to child process
04eb1f8 
PR-URL: #48057
Backport-PR-URL: #48684
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@MoLow @danielleadams
test_runner: dont split lines on test:stdout
d795c0a 
PR-URL: #48057
Backport-PR-URL: #48684
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams danielleadams added backported-to-v18.x and removed backport-open-v18.x labels Jul 12, 2023
@danielleadams danielleadams mentioned this pull request Jul 12, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: dont split lines on test:stdout
91b49b1 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: pass FORCE_COLOR to child process
b02e22f 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: dont split lines on test:stdout
0e736d3 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: pass FORCE_COLOR to child process
3d51afe 
PR-URL: nodejs#48057
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@cjihrig cjihrig mentioned this pull request Apr 19, 2025
util: fix test to prevent styleText color from changing #57935
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb left review comments
@cjihrig cjihrig cjihrig approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@HinataKah0 HinataKah0 HinataKah0 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@MoLow @nodejs-github-bot @cjihrig @ljharb @aduh95 @HinataKah0 @danielleadams
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.