GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: test streambase already has a consumer by MrJithil · Pull Request #48059 · nodejs/node

Conversation

@MrJithil

@MrJithil MrJithil commented May 18, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • test streambase already has a consumer
  • newStreamDuplexFromReadableWritablePair doesn't have a readable prop
  • newStreamDuplexFromReadableWritablePair doesn't have a writable prop

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels May 18, 2023
@MrJithil
MrJithil force-pushed the improve-webstreams-adapters-coverage branch from ae09e10 to d0aeccf Compare May 18, 2023 13:59
@MrJithil
MrJithil force-pushed the improve-webstreams-adapters-coverage branch from e38084c to fed96f5 Compare October 7, 2023 02:03
aduh95
aduh95 reviewed Oct 10, 2023
View reviewed changes
Comment thread test/parallel/test-whatwg-webstreams-adapters-to-readablewritablepair.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/parallel/test-whatwg-webstreams-adapters-to-streamduplex.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/parallel/test-whatwg-webstreams-adapters-to-streamduplex.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/parallel/test-whatwg-webstreams-adapters-streambase.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/parallel/test-whatwg-webstreams-adapters-streambase.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@MrJithil
MrJithil force-pushed the improve-webstreams-adapters-coverage branch from fed96f5 to f451c28 Compare October 11, 2023 08:59
@MrJithil
MrJithil requested a review from aduh95 October 11, 2023 09:00
aduh95
aduh95 reviewed Oct 11, 2023
View reviewed changes
Comment thread test/parallel/test-whatwg-webstreams-adapters-streambase.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@MrJithil
MrJithil force-pushed the improve-webstreams-adapters-coverage branch from f451c28 to 9c4697c Compare October 11, 2023 09:21
@MrJithil
MrJithil requested a review from aduh95 October 11, 2023 09:21
aduh95
aduh95 approved these changes Oct 11, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 11, 2023
@github-actions github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 11, 2023
@github-actions

github-actions Bot commented Oct 11, 2023

Copy link
Copy Markdown
Contributor
Failed to start CI
node:internal/modules/cjs/loader:1028
  const err = new Error(message);
              ^

Error: Cannot find module 'call-bind'

Require stack:


    

  • /opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js
    
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1028:15)
    
at Function.Module._load (node:internal/modules/cjs/loader:873:27)
    
at Module.require (node:internal/modules/cjs/loader:1100:19)
    
at require (node:internal/modules/cjs/helpers:119:18)
    
at Object. (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js:4:16)
    
at Module._compile (node:internal/modules/cjs/loader:1198:14)
    
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    
at Module.load (node:internal/modules/cjs/loader:1076:32)
    
at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    
at ModuleWrap. (node:internal/modules/esm/translators:169:29) {
    
code: 'MODULE_NOT_FOUND',
    
requireStack: [
    
'/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js'
    
]
    
}
https://github.com/nodejs/node/actions/runs/6480821911
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 11, 2023
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
jasnell
jasnell approved these changes Oct 28, 2023
View reviewed changes
@MrJithil
MrJithil force-pushed the improve-webstreams-adapters-coverage branch from 9c4697c to 638a73b Compare November 3, 2023 10:05
@MrJithil
test: test streambase has already has a consumer
6ade593 
test: test streambase has already has a consumer
@MrJithil
MrJithil force-pushed the improve-webstreams-adapters-coverage branch from 638a73b to 6ade593 Compare November 3, 2023 10:07
aduh95
aduh95 approved these changes Nov 3, 2023
View reviewed changes
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 3, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 3, 2023
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot mentioned this pull request Nov 4, 2023
CI Reliability 2023-11-04 nodejs/reliability#707
Open
14 tasks
This was referenced Nov 5, 2023
CI Reliability 2023-11-05 nodejs/reliability#708
Open
CI Reliability 2023-11-06 nodejs/reliability#709
Open
CI Reliability 2023-11-07 nodejs/reliability#710
Open
CI Reliability 2023-11-08 nodejs/reliability#711
Open
CI Reliability 2023-11-09 nodejs/reliability#712
Open
CI Reliability 2023-11-10 nodejs/reliability#713
Open
@MrJithil MrJithil added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 11, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 11, 2023
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55570/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MrJithil added a commit that referenced this pull request Nov 14, 2023
@MrJithil
test: test streambase has already has a consumer
eb46e09 
test: test streambase has already has a consumer
PR-URL: #48059
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MrJithil

MrJithil commented Nov 14, 2023

Copy link
Copy Markdown
Member Author

Landed in eb46e09
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MrJithil MrJithil closed this Nov 14, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
@MrJithil @targos
test: test streambase has already has a consumer
377dede 
test: test streambase has already has a consumer
PR-URL: #48059
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
v21.3.0 proposal #50954
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@MrJithil @UlisesGascon
test: test streambase has already has a consumer
b67665f 
test: test streambase has already has a consumer
PR-URL: #48059
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@MrJithil @UlisesGascon
test: test streambase has already has a consumer
49e5f47 
test: test streambase has already has a consumer
PR-URL: #48059
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@MrJithil @nodejs-github-bot @jasnell @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.