GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — v21.3.0 proposal by RafaelGSS · Pull Request #50954 · nodejs/node

Conversation

RafaelGSS commented Nov 28, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

2023-11-30, Version 21.3.0 (Current), @RafaelGSS

Notable Changes

New `--disable-warning` flag

This version adds a new --disable-warning option that allows users to disable specific warnings either by code
(i.e. DEP0025) or type (i.e. DeprecationWarning, ExperimentalWarning).

This option works alongside existing --warnings and --no-warnings.

For example, the following script will not emit DEP0025 require('node:sys') when executed with
node --disable-warning=DEP0025:

import sys from 'node:sys';

Contributed by Ethan-Arrowood in #50661

Update Root Certificates to NSS 3.95

This is the certdata.txt from NSS 3.95, released on 2023-11-16.

This is the version of NSS that will ship in Firefox 121 on
2023-12-19.

Certificates added:

TrustAsia Global Root CA G3
TrustAsia Global Root CA G4
CommScope Public Trust ECC Root-01
CommScope Public Trust ECC Root-02
CommScope Public Trust RSA Root-01
CommScope Public Trust RSA Root-02

Certificates removed:

Autoridad de Certificacion Firmaprofesional CIF A62634068

Fast fs.writeFileSync with UTF-8 Strings

Enhanced writeFileSync functionality by implementing a highly efficient fast path primarily in C++ for UTF8-encoded string data.
Additionally, optimized the appendFileSync method by leveraging the improved writeFileSync functionality.
For simplicity and performance considerations, the current implementation supports only string data,
as benchmark results raise concerns about the efficacy of using Buffer for this purpose.
Future optimizations and expansions may be explored, but for now, the focus is on maximizing efficiency for string data operations.

Contributed by CanadaHonk in #49884.

Other Notable Changes

[c7a7493ca2] - (SEMVER-MINOR) module: bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
[bc3f7b5401] - (SEMVER-MINOR) module: remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
[aadff07e59] - (SEMVER-MINOR) src: create per isolate proxy env template (Chengzhong Wu) #48655
[91aa9dd23a] - (SEMVER-MINOR) src: create fs_dir per isolate properties (Chengzhong Wu) #48655
[5c5834190a] - (SEMVER-MINOR) src: create worker per isolate properties (Chengzhong Wu) #48655
[4a1ce45181] - (SEMVER-MINOR) src: make process binding data weak (Chengzhong Wu) #48655

Commits

[4a20912279] - benchmark: update iterations in benchmark/util/splice-one.js (Liu Jia) #50698
[36380eb53d] - benchmark: increase the iteration number to an appropriate value (Lei Shi) #50766
[23f56d8bb3] - benchmark: rewrite import.meta benchmark (Joyee Cheung) #50683
[f7245d73d9] - benchmark: add misc/startup-cli-version benchmark (Joyee Cheung) #50684
[c81d2acfe0] - benchmark: remove punycode from require-builtins fixture (Joyee Cheung) #50689
[5849f09874] - build: add GN configurations for simdjson (Cheng Zhao) #50831
[12605e8f7d] - build: add configuration flag to enable Maglev (Keyhan Vakil) #50692
[43da9ea9e5] - build: fix GN configuration for deps/base64 (Cheng Zhao) #50696
[465f75b58a] - build: disable flag v8_scriptormodule_legacy_lifetime (Chengzhong Wu) #50616
[d2c0dfb1b7] - crypto: update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
[8d3a1d8911] - deps: update zlib to 1.2.13.1-motley-5daffc7 (Node.js GitHub Bot) #50803
[e02f304de7] - deps: V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50867
[c31ad5ceaa] - deps: update icu to 74.1 (Node.js GitHub Bot) #50515
[3ff2bda34e] - deps: update ada to 2.7.4 (Node.js GitHub Bot) #50815
[221f02df6d] - deps: update undici to 5.27.2 (Node.js GitHub Bot) #50813
[ee69c613a2] - deps: update minimatch to 9.0.3 (Node.js GitHub Bot) #50806
[00dab30fd2] - deps: V8: cherry-pick 475c8cdf9a95 (Keyhan Vakil) #50680
[a0c01b23b4] - deps: update simdutf to 4.0.4 (Node.js GitHub Bot) #50772
[071e46ae56] - deps: upgrade npm to 10.2.4 (npm team) #50751
[5d28f8d18f] - deps: escape Python strings correctly (Michaël Zasso) #50695
[3731f836ed] - deps: V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50654
[6dfe1023c3] - dns: call handle.setServers() with a valid array (Luigi Pinca) #50811
[2f13db475e] - doc: make theme consistent across api and other docs (Dima Demakov) #50877
[8c4976b732] - doc: add a section regarding instanceof in primordials.md (Antoine du Hamel) #50874
[6485687642] - doc: update email to reflect affiliation (Yagiz Nizipli) #50856
[bc31375a09] - doc: shard not supported with watch mode (Pulkit Gupta) #50640
[08c3b0ab20] - doc: get rid of unnecessary eslint-skip comments (Antoine du Hamel) #50829
[98fb1faff1] - doc: create deprecation code for isWebAssemblyCompiledModule (Marco Ippolito) #50486
[e116fcdb01] - doc: add CanadaHonk to triagers (CanadaHonk) #50848
[a37d9ee1e3] - doc: fix typos in --allow-fs-* (Tobias Nießen) #50845
[8468daf1a9] - doc: update Crypto API doc for x509.keyUsage (Daniel Meechan) #50603
[b4935dde60] - doc: fix fs.writeFileSync return value documentation (Ryan Zimmerman) #50760
[ead9879a04] - doc: update print results(detail) in PerformanceEntry (Jungku Lee) #50723
[6b7403c5df] - doc: fix Buffer.allocUnsafe documentation (Mert Can Altın) #50686
[713fdf1fc3] - doc: run license-builder (github-actions[bot]) #50691
[50f336c06f] - esm: fallback to getSource when load returns nullish source (Antoine du Hamel) #50825
[bd58870556] - esm: do not call getSource when format is commonjs (Francesco Trotta) #50465
[e59268a076] - fs: add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
[483200f68f] - fs: improve error performance for rmdirSync (CanadaHonk) #49846
[e4e0add0de] - fs: fix glob returning duplicates (Moshe Atlow) #50881
[45b2bb09f2] - fs: fix to not return for void function (Jungku Lee) #50769
[492e3e30b7] - fs: replace deprecated path._makeLong in copyFile (CanadaHonk) #50844
[9dc4cde75b] - fs: improve error perf of sync lstat+fstat (CanadaHonk) #49868
[c3eee590be] - inspector: use private fields instead of symbols (Yagiz Nizipli) #50776
[1a0069b13d] - meta: clarify nomination process according to Node.js charter (Matteo Collina) #50834
[65a811a86d] - meta: clarify recommendation for bug reproductions (Antoine du Hamel) #50882
[5811a59016] - meta: move cjihrig to TSC regular member (Colin Ihrig) #50816
[c7a7493ca2] - (SEMVER-MINOR) module: bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
[bc3f7b5401] - (SEMVER-MINOR) module: remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
[9197b0f2fc] - net: check pipe mode and path (theanarkh) #50770
[673de300b4] - node-api: factor out common code into macros (Gabriel Schulhof) #50664
[aebe2fc702] - perf_hooks: implement performance.now() with fast API calls (Joyee Cheung) #50492
[3fdecc4a8b] - permission: do not create symlinks if target is relative (Tobias Nießen) #49156
[27a4f58640] - permission: mark const functions as such (Tobias Nießen) #50705
[feb8ff9427] - src: assert return value of BN_bn2binpad (Tobias Nießen) #50860
[fd9195d750] - src: fix coverity warning (Michael Dawson) #50846
[adcab85c0c] - src: fix compatility with upcoming V8 12.1 APIs (Cheng Zhao) #50709
[79ef39b8c8] - (SEMVER-MINOR) src: add --disable-warning option (Ethan Arrowood) #50661
[faf6a04ba6] - src: add IsolateScopes before using isolates (Keyhan Vakil) #50680
[eacf4ba485] - src: iterate on import attributes array correctly (Michaël Zasso) #50703
[0fb35b6a67] - src: avoid copying strings in FSPermission::Apply (Tobias Nießen) #50662
[83ad272fa6] - src: remove erroneous default argument in RadixTree (Tobias Nießen) #50736
[2e8e237ce2] - src: fix JSONParser leaking internal V8 scopes (Keyhan Vakil) #50688
[0d3aa725cf] - src: return error --env-file if file is not found (Ardi Nugraha) #50588
[aadff07e59] - (SEMVER-MINOR) src: create per isolate proxy env template (Chengzhong Wu) #48655
[91aa9dd23a] - (SEMVER-MINOR) src: create fs_dir per isolate properties (Chengzhong Wu) #48655
[5c5834190a] - (SEMVER-MINOR) src: create worker per isolate properties (Chengzhong Wu) #48655
[4a1ce45181] - (SEMVER-MINOR) src: make process binding data weak (Chengzhong Wu) #48655
[8746073664] - src: avoid silent coercion to signed/unsigned int (Tobias Nießen) #50663
[57587de1fa] - src: handle errors from uv_pipe_connect2() (Deokjin Kim) #50657
[e5cce004e8] - stream: fix enumerability of ReadableStream.from (Mattias Buelens) #50779
[4522e229c0] - stream: fix enumerability of ReadableStream.prototype.values (Mattias Buelens) #50779
[2e0abed973] - stream: yield expected Error class on zlib errors (Filip Skokan) #50712
[a275155e81] - stream: add Symbol.toStringTag to Compression Streams (Filip Skokan) #50712
[146ad9cab0] - stream: treat compression web stream format per its WebIDL definition (Filip Skokan) #50631
[087cffc7c2] - test: fix message v8 not normalising alphanumeric paths (Jithil P Ponnan) #50730
[7de900a442] - test: fix dns test case failures after c-ares update to 1.21.0+ (Brad House) #50743
[b1b6c44712] - test: replace forEach with for of (Conor Watson) #50594
[7f44164ad4] - test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js (Alessandro Di Nisio) #50795
[9d76de1993] - test: replace foreach with for in test-https-simple.js (Shikha Mehta) #49793
[ce8fc56ee4] - test: add note about unresolved spec issue (Mattias Buelens) #50779
[628a12ac18] - test: add note about readable streams with type owning (Mattias Buelens) #50779
[82f0882ce0] - test: replace forEach with for-of in test-url-relative (vitosorriso) #50788
[3b7998305d] - test: replace forEach() with for ... of in test-tls-getprotocol.js (Steve Goode) #50600
[0e4d25eb5c] - test: use requires instead of flaky in console WPT status (Filip Skokan) #50812
[221952a88e] - test: use ppc and ppc64 to skip SEA tests on PowerPC (Joyee Cheung) #50828
[0e3b714069] - test: enable idlharness tests for encoding (Mattias Buelens) #50778
[c8d4cd68b4] - test: replace forEach in whatwg-encoding-custom-interop (Honza Machala) #50607
[f25637b5c9] - test: update WPT files for WebIDL tests (Filip Skokan) #50712
[f2e0fce389] - test: replace forEach() with for-loop (Jan) #50596
[4b26f14a53] - test: improve test-bootstrap-modules.js (Joyee Cheung) #50708
[28d78de0dd] - test: skip parallel/test-macos-app-sandbox if disk space < 120MB (Joyee Cheung) #50764
[4088b750e7] - test: mark SEA tests as flaky on PowerPC (Joyee Cheung) #50750
[6475cee6a4] - test: give more time to GC in test-shadow-realm-gc-* (Joyee Cheung) #50735
[0e8275b610] - test: replace foreach with for (Markus Muschol) #50599
[377deded59] - test: test streambase has already has a consumer (Jithil P Ponnan) #48059
[342a83e728] - test: change forEach to for...of in path extname (Kyriakos Markakis) #50667
[75265e491d] - test: replace forEach with for...of (Ryan Williams) #50611
[982b57651b] - test: migrate message v8 tests from Python to JS (Joshua LeMay) #50421
[7ebc8c2aed] - test,stream: enable compression WPTs (Filip Skokan) #50631
[0bd694ab64] - test_runner: add tests for various mock timer issues (Mika Fischer) #50384
[dee8039c9b] - tls: fix order of setting cipher before setting cert and key (Kumar Rishav) #50186
[5de30531b8] - tools: add macOS notarization verification step (Ulises Gascón) #50833
[a12d9e03f2] - tools: use macOS keychain to notarize the releases (Ulises Gascón) #50715
[f21637717f] - tools: update eslint to 8.54.0 (Node.js GitHub Bot) #50809
[daa933d93a] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #50807
[52830b71cc] - tools: add workflow to update release links (Michaël Zasso) #50710
[db8ce5bbdd] - tools: recognize GN files in dep_updaters (Cheng Zhao) #50693
[5ef6729b66] - tools: remove unused file (Ulises Gascon) #50622
[c49483820a] - tools: change minimatch install strategy (Marco Ippolito) #50476
[0d556d9a59] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #50675
[eaa4c14e6b] - util: improve performance of normalizeEncoding (kylo5aby) #50721
[a5d959b765] - v8,tools: expose necessary V8 defines (Cheng Zhao) #50820

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and lemire reacted with thumbs up emoji

bricss reacted with hooray emoji

bricss reacted with heart emoji

bricss reacted with rocket emoji

All reactions

👍 2 reactions
🎉 1 reaction
❤️ 1 reaction
🚀 1 reaction

jahjahLemonade and others added 30 commits

November 23, 2023 10:15


          test: migrate message v8 tests from Python to JS

982b576

PR-URL: #50421
Fixes: #47707
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>


          test_runner: add tests for various mock timer issues

0bd694a

PR-URL: #50384
Fixes: #50365
Fixes: #50381
Fixes: #50382
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          test,stream: enable compression WPTs

7ebc8c2

PR-URL: #50631
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>


          stream: treat compression web stream format per its WebIDL definition

146ad9c

PR-URL: #50631
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>


          tools: update lint-md-dependencies to [email protected]

0d556d9

PR-URL: #50675
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>


          test: replace forEach with for...of

75265e4

PR-URL: #50611
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          deps: V8: cherry-pick 8f0b94671ddb

3731f83

Original commit message:

    [gcc] Add include for TurboShaft

    Include <limits> for std::numeric_limits.

    Bug: chromium:819294
    Change-Id: I26a71ed4bad1858d2f5ed5d7dcd529e9cae60f37
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4889285
    Commit-Queue: Nico Hartmann <[email protected]>
    Reviewed-by: Nico Hartmann <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90347}

Refs: v8/v8@8f0b946
PR-URL: #50654
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          src: handle errors from uv_pipe_connect2()

57587de

We need to handle errors from uv_pipe_connect2()
because return type is `int`.

Fixes: #50652
Refs: #49667
Refs: libuv/libuv#4030
PR-URL: #50657
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: theanarkh <[email protected]>


          src: avoid silent coercion to signed/unsigned int

Be accurate about signedness and bit widths.

PR-URL: #50663
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          node-api: factor out common code into macros

673de30

    * Create macro for checking new string arguments.
    * Create macro for combining env check and inside-gc check.

PR-URL: #50664
Reviewed-By: Vladimir Morozov <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>


          tools: change minimatch install strategy

c494838

PR-URL: #50476
Refs: nodejs/security-wg#1037
Reviewed-By: James M Snell <[email protected]>


          test: change forEach to for...of in path extname

342a83e

PR-URL: #50667
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>


          src: make process binding data weak

4a1ce45

Avoid the realm being strongly referenced by the process binding data.

PR-URL: #48655
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>


          src: create worker per isolate properties

5c58341

PR-URL: #48655
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>


          src: create fs_dir per isolate properties

91aa9dd

PR-URL: #48655
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>


          src: create per isolate proxy env template

aadff07

PR-URL: #48655
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>


          module: remove useCustomLoadersIfPresent flag

bc3f7b5

The flag is always true and can be determined by isLoaderWorker solely.

PR-URL: #48655
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>


          module: bootstrap module loaders in shadow realm

c7a7493

This bootstraps ESM loaders in the ShadowRealm with
`ShadowRealm.prototype.importValue` as its entry point and enables
loading ESM and CJS modules in the ShadowRealm. The module is imported
without a parent URL and resolved with the current process's working
directory.

PR-URL: #48655
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>


          src: return error --env-file if file is not found

0d3aa72

PR-URL: #50588
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>


          test: test streambase has already has a consumer

377dede

test: test streambase has already has a consumer
PR-URL: #48059
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          deps: escape Python strings correctly

5d28f8d

Fixes: #50671
PR-URL: #50695
Reviewed-By: Christian Clauss <[email protected]>
Reviewed-By: Jithil P Ponnan <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          src: fix JSONParser leaking internal V8 scopes

2e8e237

JSONParser uses V8's JSON.parse (for now), meaning that its uses handles
and contexts. JSONParser was leaking its internal HandleScope and
Context::Scope.

Move the scope construction to the member functions to prevent those
scopes from leaking.

Refs: #50680 (comment)
PR-URL: #50688
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>


          tools: remove unused file

5ef6729

PR-URL: #50622
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>


          doc: run license-builder

713fdf1

PR-URL: #50691
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>


          benchmark: remove punycode from require-builtins fixture

c81d2ac

It's now runtime-deprecated. Remove it from the benchmark. This
also gets rid of the warning emitted when the fixture is loaded.

PR-URL: #50689
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          tools: recognize GN files in dep_updaters

db8ce5b

PR-URL: #50693
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>


          test: replace foreach with for

0e8275b

PR-URL: #50599
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>


          tools: add workflow to update release links

52830b7

Refs: #50623
PR-URL: #50710
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>


          doc: fix Buffer.allocUnsafe documentation

6b7403c

PR-URL: #50686
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>


          benchmark: add misc/startup-cli-version benchmark

f7245d7

This benchmarks the startup of various CLI tools that are already
checked into the source code. We use --version because the output
tends to be minimal and fewer operations are done to generate
these so that the startup cost is still dominated by a more
indispensible part of the CLI.

PR-URL: #50684
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>

aduh95 and others added 12 commits

November 29, 2023 09:46


          meta: clarify recommendation for bug reproductions

65a811a

Sometimes reporters link to a repo for their repro, which
not only likely takes them more time to setup, but also is less
convenient for maintainers. Setting up a repo goes against the idea of a
minimal repro, as if it was actually minimal, they would not have
bothered creating a repo.

PR-URL: #50882
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>


          src: assert return value of BN_bn2binpad

feb8ff9

Every other invocation of BN_bn2binpad checks the return value. For
safety and consistency, do so in RandomPrimeTraits::EncodeOutput()
as well.

PR-URL: #50860
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          fs: fix glob returning duplicates

e4e0add

PR-URL: #50881
Fixes: #50875
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>


          benchmark: update iterations in benchmark/util/splice-one.js

4a20912

Increase the number of iterations from 1e5 to 5e6
to avoid the test performance gap caused by inactive
V8 optimization caused by insufficient number of iterations

Refs: #50571
PR-URL: #50698
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>


          meta: clarify nomination process according to Node.js charter

1a0069b

Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #50834
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>


          fs: improve error performance for rmdirSync

483200f

PR-URL: #49846
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>


          fs: add c++ fast path for writeFileSync utf8

e59268a

PR-URL: #49884
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          doc: make theme consistent across api and other docs

2f13db4

Since website based on 2 different repos, there was an inconsistency
in theme selection, so we had 2 independant theme props.
Now only one stored in local storage is a single source of truth

PR-URL: #50877
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>


          test: fix message v8 not normalising alphanumeric paths

087cffc

PR-URL: #50730
Fixes: #50724
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>


          esm: do not call getSource when format is commonjs

bd58870

Ensure that `defaultLoad` does not uselessly access the file system to
get the source of modules that are known to be in CommonJS format.

This allows CommonJS imports to resolve in the current phase of the
event loop.

Refs: eslint/eslint#17683
PR-URL: #50465
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>


          esm: fallback to getSource when load returns nullish source

50f336c

When using the Modules Customization Hooks API to load CommonJS modules,
we want to support the returned value of `defaultLoad` which must be
nullish to preserve backward compatibility. This can be achieved by
fetching the source from the translator.

PR-URL: #50825
Fixes: #50435
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>


          2023-11-30, Version 21.3.0 (Current)

1f0ba08

Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
fs:
  * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
  * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
  * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
src:
  * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
  * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
  * (SEMVER-MINOR) create fs_dir per isolate properties (Chengzhong Wu) #48655
  * (SEMVER-MINOR) create worker per isolate properties (Chengzhong Wu) #48655
  * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655

PR-URL: #50954

RafaelGSS force-pushed the v21.3.0-proposal branch from 6379d60 to 1f0ba08 Compare

November 29, 2023 13:09

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 29, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 29, 2023

There was an error while loading. Please reload this page.

anonrig approved these changes

Nov 30, 2023

View reviewed changes

targos dismissed their stale review

November 30, 2023 10:41

buggy commit removed

UlisesGascon approved these changes

Nov 30, 2023

View reviewed changes

RafaelGSS merged commit 1f0ba08 into v21.x

Nov 30, 2023

RafaelGSS deleted the v21.3.0-proposal branch

November 30, 2023 16:58

RafaelGSS added a commit that referenced this pull request

Nov 30, 2023


          Working on v21.3.1

eea8930

PR-URL: #50954

RafaelGSS added a commit that referenced this pull request

Nov 30, 2023


          2023-11-30, Version 21.3.0 (Current)

b7d2827

Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
fs:
  * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
  * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
  * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
src:
  * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
  * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
  * (SEMVER-MINOR) create fs_dir per isolate properties (Chengzhong Wu) #48655
  * (SEMVER-MINOR) create worker per isolate properties (Chengzhong Wu) #48655
  * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655

PR-URL: #50954

RafaelGSS added a commit to RafaelGSS/nodejs.org that referenced this pull request

Nov 30, 2023


          Blog: v21.3.0 release post

2ae1227

Refs: nodejs/node#50954

RafaelGSS mentioned this pull request

Nov 30, 2023

Blog: v21.3.0 release post nodejs/nodejs.org#6152

Merged

github-merge-queue Bot pushed a commit to nodejs/nodejs.org that referenced this pull request

Nov 30, 2023


          Blog: v21.3.0 release post (#6152)

f292c26

* Blog: v21.3.0 release post

Refs: nodejs/node#50954

* Apply suggestions from code review

Co-authored-by: Richard Lau <[email protected]>
Signed-off-by: Rafael Gonzaga <[email protected]>

---------

Signed-off-by: Rafael Gonzaga <[email protected]>
Co-authored-by: Richard Lau <[email protected]>

Reviewers

anonrig

anonrig approved these changes

UlisesGascon

UlisesGascon approved these changes

+1 more reviewer

targos

targos left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci

PRs that need a full CI run.

release

Issues and PRs related to Node.js releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

RafaelGSS commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2023-11-30, Version 21.3.0 (Current), @RafaelGSS

Notable Changes

New --disable-warning flag

Update Root Certificates to NSS 3.95

Fast fs.writeFileSync with UTF-8 Strings

Other Notable Changes

Commits

Uh oh!

nodejs-github-bot commented Nov 29, 2023 • edited by RafaelGSS Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 29, 2023

Uh oh!

nodejs-github-bot commented Nov 29, 2023

Uh oh!

nodejs-github-bot commented Nov 29, 2023

Uh oh!

nodejs-github-bot commented Nov 30, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

RafaelGSS commented Nov 28, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

New `--disable-warning` flag

nodejs-github-bot commented Nov 29, 2023 •

edited by RafaelGSS

Loading

Uh oh!

There was an error while loading. Please reload this page.