GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: add debug logs to deps update by marco-ippolito · Pull Request #48060 · nodejs/node

Conversation

@marco-ippolito

@marco-ippolito marco-ippolito commented May 18, 2023

Copy link
Copy Markdown
Member

add debug logs to deps update

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@marco-ippolito
tools: add debug logs
b8508bc
@nodejs-github-bot

nodejs-github-bot commented May 18, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/single-executable
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito marco-ippolito changed the title tools: add debug logs tools: add debug logs to deps update May 18, 2023
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 18, 2023
ruyadorno
ruyadorno approved these changes May 18, 2023
View reviewed changes
richardlau
richardlau approved these changes May 18, 2023
View reviewed changes
deokjinkim
deokjinkim approved these changes May 18, 2023
View reviewed changes
RaisinTen
RaisinTen approved these changes May 19, 2023
View reviewed changes
Mesteery
Mesteery approved these changes May 19, 2023
View reviewed changes
@tniessen

tniessen commented May 19, 2023

Copy link
Copy Markdown
Member

I still think we should be logging checksums of files that are downloaded (or commit IDs of commits that are checked out), see #47992 (review).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito

marco-ippolito commented May 19, 2023

Copy link
Copy Markdown
Member Author

I still think we should be logging checksums of files that are downloaded (or commit IDs of commits that are checked out), see #47992 (review).

Yes I've tracked it here: nodejs/security-wg#973, we might want checksum for all the zip we download
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes May 21, 2023
View reviewed changes
@marco-ippolito marco-ippolito added the commit-queue PRs queued for automated landing through the Commit Queue. label May 22, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 22, 2023
@nodejs-github-bot
nodejs-github-bot merged commit f858dc5 into main May 22, 2023
@nodejs-github-bot
nodejs-github-bot deleted the feat/add-debug-logs branch May 22, 2023 08:22
@nodejs-github-bot

nodejs-github-bot commented May 22, 2023

Copy link
Copy Markdown
Collaborator

Landed in f858dc5
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 30, 2023
@marco-ippolito @targos
tools: add debug logs
2226088 
PR-URL: #48060
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@marco-ippolito @danielleadams
tools: add debug logs
177ea90 
PR-URL: #48060
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@marco-ippolito @MoLow
tools: add debug logs
0b0818c 
PR-URL: nodejs#48060
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@marco-ippolito @Ceres6
tools: add debug logs
caac5f3 
PR-URL: nodejs#48060
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@marco-ippolito @Ceres6
tools: add debug logs
121c28f 
PR-URL: nodejs#48060
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes
@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@deokjinkim deokjinkim deokjinkim approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@Mesteery Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@marco-ippolito @nodejs-github-bot @tniessen @ruyadorno @lpinca @richardlau @deokjinkim @RaisinTen @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.