GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: ignore helper files in WPTs by panva · Pull Request #48079 · nodejs/node

Conversation

@panva

@panva panva commented May 19, 2023

Copy link
Copy Markdown
Member

Because daily WPT report started timing out on these helper files. These are not test entrypoints so we're not losing any coverage.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@panva
test: ignore helper files in WPTs
3d6e750
@panva panva added test Issues and PRs related to Node.js core tests and test infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels May 19, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 19, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 19, 2023
@nodejs-github-bot

nodejs-github-bot commented May 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51880/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed May 19, 2023
View reviewed changes
Comment thread test/common/wpt.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@panva panva removed the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label May 19, 2023
@nodejs nodejs deleted a comment from github-actions Bot May 19, 2023
anonrig
anonrig approved these changes May 20, 2023
View reviewed changes
@panva

panva commented May 20, 2023

Copy link
Copy Markdown
Member Author

I'm hoping to just rename the one offending file that doesn't follow the, I assume unwritten, convention.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
KhafraDev
KhafraDev approved these changes May 20, 2023
View reviewed changes

@KhafraDev KhafraDev left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although there's no harm in skipping these files, I don't understand why they would time out. Is it a deeper problem with the WPT runner?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@panva

panva commented May 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Is it a deeper problem with the WPT runner?

The way it selects files that contain tests is definitely one. Combined with the recent change to register a timeout to keep the event loop spinning being another, I wanted to avoid that but the wpt maintainers weren't keen to acknowledging our event loop and called my patch to a particular test a bug hiding solution instead.

We can go with this workaround for now until I get the time to pull in the native WPT python tool scripts that build the manifest of files to run. That should avoid any future test file selection problems.
KhafraDev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes May 21, 2023
View reviewed changes
@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label May 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 21, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 6439f68 into nodejs:main May 21, 2023
@nodejs-github-bot

nodejs-github-bot commented May 21, 2023

Copy link
Copy Markdown
Collaborator

Landed in 6439f68
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva
panva deleted the wpt-ignore-helpers branch May 21, 2023 13:58
targos pushed a commit that referenced this pull request May 30, 2023
@panva @targos
test: ignore helper files in WPTs
8d2a3b1 
PR-URL: #48079
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@panva @danielleadams
test: ignore helper files in WPTs
a0d14b0 
PR-URL: #48079
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@panva @MoLow
test: ignore helper files in WPTs
5c5b1d2 
PR-URL: nodejs#48079
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@panva @Ceres6
test: ignore helper files in WPTs
bd39529 
PR-URL: nodejs#48079
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@panva @Ceres6
test: ignore helper files in WPTs
f2eeafa 
PR-URL: nodejs#48079
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@KhafraDev KhafraDev KhafraDev approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@panva @nodejs-github-bot @lpinca @anonrig @aduh95 @KhafraDev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.