GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: correct line break for Windows terminals by alexsch01 · Pull Request #48083 · nodejs/node

Conversation

@alexsch01

@alexsch01 alexsch01 commented May 20, 2023

Copy link
Copy Markdown
Contributor

Windows terminals [Command Prompt and PowerShell] don't use \ for line breaks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented May 20, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/single-executable
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label May 20, 2023
@Trott

Trott commented May 20, 2023

Copy link
Copy Markdown
Member

LGTM, although I wonder if we should just remove the line-wrapping entirely for these commands.
ruyadorno and RaisinTen reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes May 20, 2023
View reviewed changes
lpinca
lpinca approved these changes May 20, 2023
View reviewed changes
@Trott Trott added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels May 20, 2023
RaisinTen
RaisinTen approved these changes May 20, 2023
View reviewed changes
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 20, 2023
tniessen
tniessen approved these changes May 20, 2023
View reviewed changes

@tniessen tniessen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows... 🤦‍♂️

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sheplu
sheplu approved these changes May 20, 2023
View reviewed changes

@sheplu sheplu left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Mesteery
Mesteery approved these changes May 21, 2023
View reviewed changes
ovflowd
ovflowd approved these changes May 21, 2023
View reviewed changes

@ovflowd ovflowd left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@alexsch01

alexsch01 commented May 21, 2023

Copy link
Copy Markdown
Contributor Author

Can this be merged?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label May 21, 2023
@github-actions

github-actions Bot commented May 21, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.
lpinca and tniessen reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 21, 2023
@nodejs-github-bot

This comment was marked as off-topic.

Sign in to view
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label May 21, 2023
@tniessen tniessen added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels May 21, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels May 21, 2023
@nodejs-github-bot

nodejs-github-bot commented May 21, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/48083
✔  Done loading data for nodejs/node/pull/48083
----------------------------------- PR info ------------------------------------
Title      doc: correct line break for Windows terminals (#48083)
Author     Alex Schwartz  (@alexsch01, first-time contributor)
Branch     alexsch01:patch-1 -> nodejs:main
Labels     doc, fast-track, author ready, commit-queue-squash
Commits    3
 - doc: correct line break for Windows terminals
 - fixup! doc: correct line break for Windows terminals
 - fixup! doc: correct line break for Windows terminals
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/48083
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Darshan Sen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Mestery 
Reviewed-By: Claudio Wunder 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48083
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Darshan Sen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Mestery 
Reviewed-By: Claudio Wunder 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 20 May 2023 00:01:20 GMT
   ✔  Approvals: 6
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435313042
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435361522
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435362880
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435449579
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435512554
   ✔  - Claudio Wunder (@ovflowd): https://github.com/nodejs/node/pull/48083#pullrequestreview-1435517144
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
   ⚠  PR author is a new contributor: @alexsch01([email protected])
   ⚠  - commit 5452a24117c8 is authored by [email protected]
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5038315202
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alexsch01 @Trott
doc: correct line break for Windows terminals
e49bb68 
PR-URL: #48083
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
@Trott
Trott merged commit e49bb68 into nodejs:main May 21, 2023
@Trott

Trott commented May 21, 2023

Copy link
Copy Markdown
Member

Landed in e49bb68
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented May 21, 2023

Copy link
Copy Markdown
Member

Thanks for the contribution! 🎉
RaisinTen reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 30, 2023
@alexsch01 @targos
doc: correct line break for Windows terminals
0ac4b33 
PR-URL: #48083
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
@danielleadams

danielleadams commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

blocked by #47125
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams danielleadams added the backport-blocked-v18.x label Jul 3, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@alexsch01 @Ceres6
doc: correct line break for Windows terminals
311cbd6 
PR-URL: nodejs#48083
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@alexsch01 @Ceres6
doc: correct line break for Windows terminals
abb2199 
PR-URL: nodejs#48083
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@tniessen tniessen tniessen approved these changes
@ovflowd ovflowd ovflowd approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+2 more reviewers
@sheplu sheplu sheplu approved these changes
@Mesteery Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@alexsch01 @nodejs-github-bot @Trott @danielleadams @sheplu @lpinca @tniessen @ovflowd @RaisinTen @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.