GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add atlowChemi to triagers by atlowChemi · Pull Request #48104 · nodejs/node

Conversation

@atlowChemi

@atlowChemi atlowChemi commented May 21, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I recently started contributing to the node project. I am looking forward to getting more involved in the node project, and one day becoming a collaborator 🙏🏽
I have read node's code of conduct, and I will adhere to it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@atlowChemi
doc: add atlowChemi to triagers
854fb63
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label May 21, 2023
benjamingr
benjamingr approved these changes May 21, 2023
View reviewed changes
@benjamingr

benjamingr commented May 21, 2023

Copy link
Copy Markdown
Member

@gireeshpunathil

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Trott
Trott reviewed May 21, 2023
View reviewed changes
Comment thread README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Trott
Trott requested changes May 21, 2023
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entry needs to be moved, but other than that, this looks good to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

atlowChemi reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@atlowChemi
re-order
313f80f
@atlowChemi
atlowChemi requested a review from Trott May 21, 2023 16:31
Trott
Trott approved these changes May 21, 2023
View reviewed changes
@MoLow

MoLow commented May 21, 2023

Copy link
Copy Markdown
Member

👍🏻 I'l let others approve this as we are brothers ❤️

atlowChemi and RaisinTen reacted with laugh emoji atlowChemi reacted with heart emoji
All reactions
  • 😄 2 reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ayase-252
Ayase-252 approved these changes May 22, 2023
View reviewed changes
RaisinTen
RaisinTen approved these changes May 22, 2023
View reviewed changes

@RaisinTen RaisinTen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
cc @nodejs/issue-triage

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
daeyeon
daeyeon approved these changes May 22, 2023
View reviewed changes

@daeyeon daeyeon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
VoltrexKeyva
VoltrexKeyva approved these changes May 22, 2023
View reviewed changes
lpinca
lpinca approved these changes May 25, 2023
View reviewed changes
F3n67u
F3n67u approved these changes May 26, 2023
View reviewed changes
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label May 28, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels May 28, 2023
@nodejs-github-bot

nodejs-github-bot commented May 28, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/48104
✔  Done loading data for nodejs/node/pull/48104
----------------------------------- PR info ------------------------------------
Title      doc: add atlowChemi to triagers (#48104)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     atlowChemi:add-atlowChemi-to-triagers -> nodejs:main
Labels     doc
Commits    2
 - doc: add atlowChemi to triagers
 - re-order
Committers 1
 - atlowChemi 
PR-URL: https://github.com/nodejs/node/pull/48104
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Rich Trott 
Reviewed-By: Qingyu Deng 
Reviewed-By: Darshan Sen 
Reviewed-By: Daeyeon Jeong 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Luigi Pinca 
Reviewed-By: Feng Yu 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48104
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Rich Trott 
Reviewed-By: Qingyu Deng 
Reviewed-By: Darshan Sen 
Reviewed-By: Daeyeon Jeong 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Luigi Pinca 
Reviewed-By: Feng Yu 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 21 May 2023 16:08:49 GMT
   ✔  Approvals: 8
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435563635
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435564304
   ✔  - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435713363
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435794234
   ✔  - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/48104#pullrequestreview-1435797533
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/48104#pullrequestreview-1436005936
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48104#pullrequestreview-1444503120
   ✔  - Feng Yu (@F3n67u): https://github.com/nodejs/node/pull/48104#pullrequestreview-1444841370
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 48104
From https://github.com/nodejs/node
 * branch                  refs/pull/48104/merge -> FETCH_HEAD
✔  Fetched commits as 186307a48432..313f80f3a60e
--------------------------------------------------------------------------------
Auto-merging README.md
[main 9117246235] doc: add atlowChemi to triagers
 Author: atlowChemi 
 Date: Sun May 21 19:00:00 2023 +0300
 1 file changed, 2 insertions(+)
Auto-merging README.md
[main 86e4513914] re-order
 Author: atlowChemi 
 Date: Sun May 21 19:31:26 2023 +0300
 1 file changed, 2 insertions(+), 2 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: add atlowChemi to triagers

PR-URL: #48104
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Rich Trott [email protected]
Reviewed-By: Qingyu Deng [email protected]
Reviewed-By: Darshan Sen [email protected]
Reviewed-By: Daeyeon Jeong [email protected]
Reviewed-By: Mohammed Keyvanzadeh [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Feng Yu [email protected]

[detached HEAD 2449a12bb8] doc: add atlowChemi to triagers
Author: atlowChemi [email protected]
Date: Sun May 21 19:00:00 2023 +0300
1 file changed, 2 insertions(+)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
re-order

PR-URL: #48104
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Rich Trott [email protected]
Reviewed-By: Qingyu Deng [email protected]
Reviewed-By: Darshan Sen [email protected]
Reviewed-By: Daeyeon Jeong [email protected]
Reviewed-By: Mohammed Keyvanzadeh [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Feng Yu [email protected]

[detached HEAD 58f7772041] re-order
Author: atlowChemi [email protected]
Date: Sun May 21 19:31:26 2023 +0300
1 file changed, 2 insertions(+), 2 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5103062163

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoLow MoLow added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels May 28, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 28, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 7f6f17e into nodejs:main May 28, 2023
@nodejs-github-bot

nodejs-github-bot commented May 28, 2023

Copy link
Copy Markdown
Collaborator

Landed in 7f6f17e

MoLow, atlowChemi, and benjamingr reacted with hooray emoji
All reactions
  • 🎉 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@atlowChemi
atlowChemi deleted the add-atlowChemi-to-triagers branch May 28, 2023 08:30
targos pushed a commit that referenced this pull request May 30, 2023
@atlowChemi @targos
doc: add atlowChemi to triagers
13e95e2
PR-URL: #48104
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@atlowChemi @danielleadams
doc: add atlowChemi to triagers
fafd78a
PR-URL: #48104
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@atlowChemi @MoLow
doc: add atlowChemi to triagers
795ca70
PR-URL: nodejs#48104
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
doc: add atlowChemi to triagers
e679ca7
PR-URL: nodejs#48104
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
doc: add atlowChemi to triagers
7883301
PR-URL: nodejs#48104
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@Ayase-252 Ayase-252 Ayase-252 approved these changes
@daeyeon daeyeon daeyeon approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+2 more reviewers
@F3n67u F3n67u F3n67u approved these changes
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@atlowChemi @benjamingr @MoLow @nodejs-github-bot @Trott @lpinca @Ayase-252 @daeyeon @F3n67u @RaisinTen @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.