GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: improve the documentation of the stdio option by Karnav123 · Pull Request #48110 · nodejs/node

Conversation

@Karnav123

@Karnav123 Karnav123 commented May 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

doc: Add the links to better explain stdio property of cluster.settings in the file doc/api/cluster.md#clustersettings.

Fixes: issue #47705
Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings

  • doc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to Node.js documentation. labels May 22, 2023
lpinca
lpinca reviewed May 25, 2023
View reviewed changes
Comment thread doc/api/cluster.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Karnav123
Karnav123 requested a review from lpinca May 25, 2023 19:47
lpinca
lpinca reviewed May 25, 2023
View reviewed changes
Comment thread doc/api/cluster.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes May 25, 2023
View reviewed changes
@Karnav123 Karnav123 changed the title Update cluster.md doc: Update cluster.md May 26, 2023
@Karnav123

Karnav123 commented May 28, 2023

Copy link
Copy Markdown
Contributor Author

@lpinca I am sorry for bothering but this PR is not getting included in the CI run. I am not able to understand why?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca

lpinca commented May 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It is a doc only change so there is no need for a full CI run. Can you please use a more descriptive commit title? Something like doc: improve the documentation of the stdio option should be ok.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Karnav123 Karnav123 changed the title doc: Update cluster.md doc: improve the documentation of the stdio May 28, 2023
@Karnav123 Karnav123 changed the title doc: improve the documentation of the stdio doc: improve the documentation of the stdio option May 28, 2023
@Karnav123

Karnav123 commented May 28, 2023

Copy link
Copy Markdown
Contributor Author

It is a doc only change so there is no need for a full CI run. Can you please use a more descriptive commit title? Something like doc: improve the documentation of the stdio option should be ok.

Thank you! Done.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca

lpinca commented May 28, 2023

Copy link
Copy Markdown
Member

@Karnav123 you changed the PR title not the first commit title. Do you want to try to do it? You need to do a git rebase. If you prefer, we can also do it before landing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Karnav123

Karnav123 commented May 29, 2023

Copy link
Copy Markdown
Contributor Author

@Karnav123 you changed the PR title not the first commit title. Do you want to try to do it? You need to do a git rebase. If you prefer, we can also do it before landing.

Please rebase and change it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes May 29, 2023
View reviewed changes
@Karnav123 @lpinca
doc: improve the documentation of the stdio option
cca6a89 
Fixes: nodejs#47705
@lpinca
lpinca force-pushed the patch-1 branch from bb0567f to cca6a89 Compare May 29, 2023 19:12
@lpinca lpinca added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 29, 2023
lpinca
lpinca approved these changes May 30, 2023
View reviewed changes
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label May 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 30, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 84716d8 into nodejs:main May 30, 2023
@nodejs-github-bot

nodejs-github-bot commented May 30, 2023

Copy link
Copy Markdown
Collaborator

Landed in 84716d8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 30, 2023
@Karnav123 @targos
doc: improve the documentation of the stdio option
8c53386 
Fixes: #47705
PR-URL: #48110
Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@Karnav123 @danielleadams
doc: improve the documentation of the stdio option
0eaefd5 
Fixes: #47705
PR-URL: #48110
Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@Karnav123 @MoLow
doc: improve the documentation of the stdio option
f2bb191 
Fixes: nodejs#47705
PR-URL: nodejs#48110
Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@Karnav123 @Ceres6
doc: improve the documentation of the stdio option
e908fef 
Fixes: nodejs#47705
PR-URL: nodejs#48110
Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@Karnav123 @Ceres6
doc: improve the documentation of the stdio option
23f77b7 
Fixes: nodejs#47705
PR-URL: nodejs#48110
Refs: https://nodejs.org/docs/latest-v20.x/api/cluster.html#clustersettings
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Karnav123 @lpinca @nodejs-github-bot @jasnell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.