GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: alphabetize CODEOWNERS by Trott · Pull Request #48124 · nodejs/node

Conversation

@Trott

@Trott Trott commented May 22, 2023

Copy link
Copy Markdown
Member

Keep each list in CODEOWNERS in alphabetical order so it is easier to find things in the longer lists.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot

nodejs-github-bot commented May 22, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 22, 2023
@Trott Trott mentioned this pull request May 22, 2023
tools: add security-wg as dep updaters owner #48113
Merged
RaisinTen
RaisinTen approved these changes May 23, 2023
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes May 23, 2023
View reviewed changes
MoLow
MoLow approved these changes May 23, 2023
View reviewed changes
Mesteery
Mesteery approved these changes May 23, 2023
View reviewed changes
marco-ippolito
marco-ippolito approved these changes May 23, 2023
View reviewed changes
RafaelGSS
RafaelGSS approved these changes May 23, 2023
View reviewed changes
@debadree25 debadree25 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels May 23, 2023
lpinca
lpinca approved these changes May 24, 2023
View reviewed changes
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels May 24, 2023
@nodejs-github-bot

nodejs-github-bot commented May 24, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/48124
✔  Done loading data for nodejs/node/pull/48124
----------------------------------- PR info ------------------------------------
Title      tools: alphabetize CODEOWNERS (#48124)
Author     Rich Trott  (@Trott)
Branch     Trott:alphabetize-codeowners -> nodejs:main
Labels     meta, author ready
Commits    1
 - tools: alphabetize CODEOWNERS
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/48124
Reviewed-By: Darshan Sen 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Moshe Atlow 
Reviewed-By: Mestery 
Reviewed-By: Marco Ippolito 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48124
Reviewed-By: Darshan Sen 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Moshe Atlow 
Reviewed-By: Mestery 
Reviewed-By: Marco Ippolito 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 22 May 2023 22:28:02 GMT
   ✔  Approvals: 7
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/48124#pullrequestreview-1438517385
   ✔  - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/48124#pullrequestreview-1438534809
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48124#pullrequestreview-1438575044
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/48124#pullrequestreview-1438716308
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/48124#pullrequestreview-1438844200
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/48124#pullrequestreview-1439978640
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48124#pullrequestreview-1442604646
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 48124
From https://github.com/nodejs/node
 * branch                  refs/pull/48124/merge -> FETCH_HEAD
✔  Fetched commits as ceb2a21edd7b..60d2b0b69501
--------------------------------------------------------------------------------
Auto-merging .github/CODEOWNERS
CONFLICT (content): Merge conflict in .github/CODEOWNERS
error: could not apply 60d2b0b695... tools: alphabetize CODEOWNERS
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
   ✘  Failed to apply patches
https://github.com/nodejs/node/actions/runs/5074032340
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott
Trott force-pushed the alphabetize-codeowners branch from 60d2b0b to a07d3b6 Compare May 24, 2023 23:48
@Trott Trott removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label May 24, 2023
@Trott
tools: alphabetize CODEOWNERS
bd829f2
Keep each list in CODEOWNERS in alphabetical order so it is easier to
find things in the longer lists.

PR-URL: nodejs#48124
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Trott force-pushed the alphabetize-codeowners branch from a07d3b6 to bd829f2 Compare May 24, 2023 23:49
@Trott
Trott merged commit bd829f2 into nodejs:main May 24, 2023
@Trott

Trott commented May 24, 2023

Copy link
Copy Markdown
Member Author

Landed in bd829f2

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott
Trott deleted the alphabetize-codeowners branch May 24, 2023 23:50
targos pushed a commit that referenced this pull request May 30, 2023
@Trott @targos
tools: alphabetize CODEOWNERS
ad8a688
Keep each list in CODEOWNERS in alphabetical order so it is easier to
find things in the longer lists.

PR-URL: #48124
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@Trott @danielleadams
tools: alphabetize CODEOWNERS
0969206
Keep each list in CODEOWNERS in alphabetical order so it is easier to
find things in the longer lists.

PR-URL: #48124
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@Trott @MoLow
tools: alphabetize CODEOWNERS
4c5c63f
Keep each list in CODEOWNERS in alphabetical order so it is easier to
find things in the longer lists.

PR-URL: nodejs#48124
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@Trott @Ceres6
tools: alphabetize CODEOWNERS
3b05ff1
Keep each list in CODEOWNERS in alphabetical order so it is easier to
find things in the longer lists.

PR-URL: nodejs#48124
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@Trott @Ceres6
tools: alphabetize CODEOWNERS
b26de98
Keep each list in CODEOWNERS in alphabetical order so it is easier to
find things in the longer lists.

PR-URL: nodejs#48124
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@MoLow MoLow MoLow approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@Mesteery Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@Trott @nodejs-github-bot @lpinca @gireeshpunathil @MoLow @RafaelGSS @marco-ippolito @RaisinTen @Mesteery @debadree25
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.