GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix flaky test-runner-watch-mode by MoLow · Pull Request #48144 · nodejs/node

Conversation

@MoLow

@MoLow MoLow commented May 23, 2023

Copy link
Copy Markdown
Member

I was able to reproduce the fluke with tools/test.py -J --timeout=10 --repeat=1500 test/parallel/test-runner-watch-mode and validate this fixes it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and ErickWendel reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@MoLow
test: fix flaky test-runner-watch-mode
cd6d57e
@nodejs-github-bot

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels May 23, 2023
@MoLow MoLow added fast-track PRs proposed for a shorter-than-standard waiting period before landing. and removed fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels May 23, 2023
@github-actions

github-actions Bot commented May 23, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs nodejs deleted a comment from github-actions Bot May 23, 2023
@MoLow MoLow added the flaky-test Issues and PRs involving tests that fail intermittently in CI. label May 23, 2023
JakobJingleheimer
JakobJingleheimer approved these changes May 23, 2023
View reviewed changes

@JakobJingleheimer JakobJingleheimer left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W00t! Thanks for fixing a flaky test 🙌

I assume the race-conditions are not inherent to the use-case (and do not need to be accounted for).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott

Trott commented May 23, 2023

Copy link
Copy Markdown
Member

Nit: Is it me or does this test write to the fixtures directory? It should use the testing tmp directory instead.
MoLow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes May 23, 2023
View reviewed changes
aymen94
aymen94 approved these changes May 24, 2023
View reviewed changes
benjamingr
benjamingr approved these changes May 24, 2023
View reviewed changes
@MoLow
CR: don't use tmpdir only
771e2d8
@MoLow
MoLow requested review from Trott and benjamingr May 24, 2023 13:25
@MoLow MoLow added commit-queue-squash PRs the Commit Queue should land as one squashed commit. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels May 24, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 24, 2023
@nodejs-github-bot

nodejs-github-bot commented May 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51949/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 24, 2023
Trott
Trott approved these changes May 24, 2023
View reviewed changes
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label May 24, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels May 24, 2023
@nodejs-github-bot

nodejs-github-bot commented May 24, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/48144
✔  Done loading data for nodejs/node/pull/48144
----------------------------------- PR info ------------------------------------
Title      test: fix flaky test-runner-watch-mode (#48144)
Author     Moshe Atlow  (@MoLow)
Branch     MoLow:fix-flaky-test-runner-watch-mode -> nodejs:main
Labels     test, flaky-test, fast-track, author ready, needs-ci, commit-queue-squash
Commits    2
 - test: fix flaky test-runner-watch-mode
 - CR: don't use tmpdir only
Committers 1
 - Moshe Atlow 
PR-URL: https://github.com/nodejs/node/pull/48144
Reviewed-By: Jacob Smith 
Reviewed-By: Rich Trott 
Reviewed-By: Benjamin Gruenbaum 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48144
Reviewed-By: Jacob Smith 
Reviewed-By: Rich Trott 
Reviewed-By: Benjamin Gruenbaum 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 23 May 2023 18:06:03 GMT
   ✔  Approvals: 3
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/48144#pullrequestreview-1440586936
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/48144#pullrequestreview-1442268852
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/48144#pullrequestreview-1441654648
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 24 more hours to land (or 0 hours if there are 2 more approvals (👍) of the fast-track request from collaborators).
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-05-24T15:32:17Z: https://ci.nodejs.org/job/node-test-pull-request/51949/
- Querying data for job/node-test-pull-request/51949/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5071858438
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow removed fast-track PRs proposed for a shorter-than-standard waiting period before landing. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels May 24, 2023
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label May 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit dd31255 into nodejs:main May 25, 2023
@nodejs-github-bot

nodejs-github-bot commented May 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in dd31255
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 30, 2023
@MoLow @targos
test: fix flaky test-runner-watch-mode
8c49d74 
PR-URL: #48144
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
@MoLow MoLow linked an issue Jun 8, 2023 that may be closed by this pull request
ibmi: parallel/test-runner-watch-mode fails with timeout #48065
Closed
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@MoLow @danielleadams
test: fix flaky test-runner-watch-mode
9ffe061 
PR-URL: #48144
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLow
MoLow deleted the fix-flaky-test-runner-watch-mode branch July 6, 2023 20:33
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
@MoLow
test: fix flaky test-runner-watch-mode
446f611 
PR-URL: nodejs#48144
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test: fix flaky test-runner-watch-mode
6072c87 
PR-URL: nodejs#48144
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test: fix flaky test-runner-watch-mode
d634476 
PR-URL: nodejs#48144
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes
@benjamingr benjamingr Awaiting requested review from benjamingr
+1 more reviewer
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ibmi: parallel/test-runner-watch-mode fails with timeout

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@MoLow @nodejs-github-bot @Trott @benjamingr @JakobJingleheimer @aymen94
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.