GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: automate histogram update by marco-ippolito · Pull Request #48171 · nodejs/node

Conversation

@marco-ippolito

@marco-ippolito marco-ippolito commented May 25, 2023

Copy link
Copy Markdown
Member

Refs: nodejs/security-wg#828
More context: #47742

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented May 25, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels May 25, 2023
This was referenced May 25, 2023
tools: log and check shasum of archive file #48088
Merged
tools: add version to maintaining-dependencies.md dependencies list and automate the update #48081
Merged
Automate updates of all dependencies nodejs/security-wg#828
Closed
tniessen
tniessen reviewed May 25, 2023
View reviewed changes
Comment thread tools/dep_updaters/update-histogram.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS
RafaelGSS approved these changes May 25, 2023
View reviewed changes

@RafaelGSS RafaelGSS left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
UlisesGascon
UlisesGascon approved these changes May 25, 2023
View reviewed changes
tniessen
tniessen reviewed May 25, 2023
View reviewed changes
Comment thread tools/dep_updaters/update-histogram.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.

@marco-ippolito
marco-ippolito force-pushed the feat/automate-histogram branch from e5aa120 to 49c6609 Compare May 26, 2023 08:23
tniessen
tniessen reviewed May 26, 2023
View reviewed changes
Comment thread tools/dep_updaters/update-histogram.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.

@marco-ippolito marco-ippolito added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 26, 2023
marco-ippolito added 3 commits May 29, 2023 11:55
@marco-ippolito
tools: automate histogram update
be6204e
@marco-ippolito
fix: multiple source copy
6ddb894
@marco-ippolito
fix: add checksum
a7c20ee
@marco-ippolito
marco-ippolito force-pushed the feat/automate-histogram branch from 49c6609 to a7c20ee Compare May 29, 2023 09:55
jasnell
jasnell approved these changes May 29, 2023
View reviewed changes
@marco-ippolito marco-ippolito added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. labels May 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 30, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 3e07158 into nodejs:main May 30, 2023
@nodejs-github-bot

nodejs-github-bot commented May 30, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3e07158

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request May 30, 2023
@marco-ippolito @targos
tools: automate histogram update
07aa264
PR-URL: #48171
Refs: nodejs/security-wg#828
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@marco-ippolito @danielleadams
tools: automate histogram update
598c7ab
PR-URL: #48171
Refs: nodejs/security-wg#828
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@marco-ippolito @MoLow
tools: automate histogram update
715cf81
PR-URL: nodejs#48171
Refs: nodejs/security-wg#828
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@marco-ippolito @Ceres6
tools: automate histogram update
d4b90c4
PR-URL: nodejs#48171
Refs: nodejs/security-wg#828
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@marco-ippolito @Ceres6
tools: automate histogram update
8afaa94
PR-URL: nodejs#48171
Refs: nodejs/security-wg#828
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessen tniessen tniessen left review comments
@richardlau richardlau richardlau left review comments
@jasnell jasnell jasnell approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@marco-ippolito @nodejs-github-bot @jasnell @tniessen @UlisesGascon @richardlau @RafaelGSS
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.