GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: order dependency jobs alphabetically by lutaok · Pull Request #48184 · nodejs/node

Conversation

@lutaok

@lutaok lutaok commented May 26, 2023

Copy link
Copy Markdown
Contributor

Hi everyone,
I opened this PR to tackle the last bullet point of this issue where jobs in tools.yml were not ordered alphabetically.

I also added the following options in workflow_dispatch, that were missing:

  • minimatch
  • zlib

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
lutaok added 2 commits May 26, 2023 08:49
@lutaok
tools: order dependency jobs alphabetically
c90e7ac
Refs: nodejs/security-wg#973
@lutaok
tools: add missing dependencies options
4f40ee5
Refs: nodejs/security-wg#973
@nodejs-github-bot

nodejs-github-bot commented May 26, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 26, 2023
@lutaok
tools: Revert spacing before comments
3be7024
PR-URL: nodejs#48184
Refs: nodejs/security-wg#973
marco-ippolito
marco-ippolito approved these changes May 26, 2023
View reviewed changes
@marco-ippolito marco-ippolito added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 26, 2023
Mesteery
Mesteery approved these changes May 26, 2023
View reviewed changes
UlisesGascon
UlisesGascon approved these changes May 27, 2023
View reviewed changes
lpinca
lpinca approved these changes May 27, 2023
View reviewed changes
debadree25
debadree25 approved these changes May 29, 2023
View reviewed changes
@debadree25 debadree25 added the commit-queue PRs queued for automated landing through the Commit Queue. label May 29, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels May 29, 2023
@nodejs-github-bot

nodejs-github-bot commented May 29, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/48184
✔  Done loading data for nodejs/node/pull/48184
----------------------------------- PR info ------------------------------------
Title      tools: order dependency jobs alphabetically (#48184)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     lutaok:jobs-dependencies-alphabetic-order -> nodejs:main
Labels     meta, author ready
Commits    3
 - tools: order dependency jobs alphabetically
 - tools: add missing dependencies options
 - tools: Revert spacing before comments
Committers 1
 - lutaok 
PR-URL: https://github.com/nodejs/node/pull/48184
Reviewed-By: Marco Ippolito 
Reviewed-By: Mestery 
Reviewed-By: Luigi Pinca 
Reviewed-By: Debadree Chatterjee 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48184
Reviewed-By: Marco Ippolito 
Reviewed-By: Mestery 
Reviewed-By: Luigi Pinca 
Reviewed-By: Debadree Chatterjee 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 26 May 2023 07:01:21 GMT
   ✔  Approvals: 4
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/48184#pullrequestreview-1446499944
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/48184#pullrequestreview-1446788888
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48184#pullrequestreview-1447507295
   ✔  - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/48184#pullrequestreview-1448806651
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   023e8803f8..b47fce0762  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - 2b236c8e70 test_runner: remove redundant check from coverage
 - b47fce0762 test_runner: remove redundant check from coverage
--------------------------------------------------------------------------------
HEAD is now at b47fce0762 test_runner: remove redundant check from coverage
   ✔  Reset to origin/main
- Downloading patch for 48184
From https://github.com/nodejs/node
 * branch                  refs/pull/48184/merge -> FETCH_HEAD
✔  Fetched commits as b47fce07620a..3be7024073da
--------------------------------------------------------------------------------
[main adeba4d8f0] tools: order dependency jobs alphabetically
 Author: lutaok 
 Date: Fri May 26 08:49:48 2023 +0200
 1 file changed, 98 insertions(+), 98 deletions(-)
[main 84200f7809] tools: add missing dependencies options
 Author: lutaok 
 Date: Fri May 26 08:58:16 2023 +0200
 1 file changed, 2 insertions(+)
[main 6d043268e8] tools: Revert spacing before comments
 Author: lutaok 
 Date: Fri May 26 13:36:31 2023 +0200
 1 file changed, 5 insertions(+), 5 deletions(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: order dependency jobs alphabetically

Refs: nodejs/security-wg#973
PR-URL: #48184
Reviewed-By: Marco Ippolito [email protected]
Reviewed-By: Mestery [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Debadree Chatterjee [email protected]

[detached HEAD 7878c7a36a] tools: order dependency jobs alphabetically
Author: lutaok [email protected]
Date: Fri May 26 08:49:48 2023 +0200
1 file changed, 98 insertions(+), 98 deletions(-)
Rebasing (3/6)
Rebasing (4/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: add missing dependencies options

Refs: nodejs/security-wg#973
PR-URL: #48184
Reviewed-By: Marco Ippolito [email protected]
Reviewed-By: Mestery [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Debadree Chatterjee [email protected]

[detached HEAD 63f1af6236] tools: add missing dependencies options
Author: lutaok [email protected]
Date: Fri May 26 08:58:16 2023 +0200
1 file changed, 2 insertions(+)
Rebasing (5/6)
Rebasing (6/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: Revert spacing before comments

PR-URL: #48184
Refs: nodejs/security-wg#973
PR-URL: #48184
Reviewed-By: Marco Ippolito [email protected]
Reviewed-By: Mestery [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Debadree Chatterjee [email protected]

[detached HEAD d1cc2af363] tools: Revert spacing before comments
Author: lutaok [email protected]
Date: Fri May 26 13:36:31 2023 +0200
1 file changed, 5 insertions(+), 5 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5108545422

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@debadree25 debadree25 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels May 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 29, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 607c8f4 into nodejs:main May 29, 2023
@nodejs-github-bot

nodejs-github-bot commented May 29, 2023

Copy link
Copy Markdown
Collaborator

Landed in 607c8f4

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request May 30, 2023
@lutaok @targos
tools: order dependency jobs alphabetically
7478ed0
Refs: nodejs/security-wg#973
PR-URL: #48184
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
@lutaok lutaok mentioned this pull request Jun 11, 2023
tools: yaml lint command in vcbuild script #48422
Closed
@danielleadams danielleadams added the backport-requested-v18.x label Jun 30, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lutaok @Ceres6
tools: order dependency jobs alphabetically
9a08661
Refs: nodejs/security-wg#973
PR-URL: nodejs#48184
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lutaok @Ceres6
tools: order dependency jobs alphabetically
1444273
Refs: nodejs/security-wg#973
PR-URL: nodejs#48184
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
+2 more reviewers
@debadree25 debadree25 debadree25 approved these changes
@Mesteery Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@lutaok @nodejs-github-bot @lpinca @UlisesGascon @debadree25 @marco-ippolito @Mesteery @danielleadams
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.