GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix typo in readline completer function section by samoyedness · Pull Request #48188 · nodejs/node

Conversation

@samoyedness

@samoyedness samoyedness commented May 26, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@samoyedness
doc: fix typo in readline completer function section
adcccfe
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. readline Issues and PRs related to the built-in readline module. labels May 26, 2023
marco-ippolito
marco-ippolito approved these changes May 26, 2023
View reviewed changes
RaisinTen
RaisinTen approved these changes May 26, 2023
View reviewed changes
himself65
himself65 approved these changes May 26, 2023
View reviewed changes
@eternityduck

eternityduck commented May 26, 2023

Copy link
Copy Markdown

good job
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva
VoltrexKeyva approved these changes May 26, 2023
View reviewed changes
@VoltrexKeyva VoltrexKeyva added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label May 26, 2023
@github-actions

github-actions Bot commented May 26, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @VoltrexKeyva. Please 👍 to approve.
samoyedness, RaisinTen, and marco-ippolito reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
watilde
watilde approved these changes May 27, 2023
View reviewed changes
@VoltrexKeyva VoltrexKeyva added the commit-queue PRs queued for automated landing through the Commit Queue. label May 27, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 27, 2023
@nodejs-github-bot
nodejs-github-bot merged commit f8b7154 into nodejs:main May 27, 2023
@nodejs-github-bot

nodejs-github-bot commented May 27, 2023

Copy link
Copy Markdown
Collaborator

Landed in f8b7154
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 30, 2023
@samoyedness @targos
doc: fix typo in readline completer function section
5f83ce5 
PR-URL: #48188
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@samoyedness @danielleadams
doc: fix typo in readline completer function section
d8d2e1a 
PR-URL: #48188
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@samoyedness @MoLow
doc: fix typo in readline completer function section
e437a0a 
PR-URL: nodejs#48188
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@samoyedness @Ceres6
doc: fix typo in readline completer function section
5679a81 
PR-URL: nodejs#48188
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@samoyedness @Ceres6
doc: fix typo in readline completer function section
6e45450 
PR-URL: nodejs#48188
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@watilde watilde watilde approved these changes
@himself65 himself65 himself65 approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. readline Issues and PRs related to the built-in readline module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@samoyedness @eternityduck @nodejs-github-bot @watilde @himself65 @marco-ippolito @RaisinTen @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.