GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — net: fix family autoselection SSL connection handling by ShogunPanda · Pull Request #48189 · nodejs/node

Conversation

@ShogunPanda

@ShogunPanda ShogunPanda commented May 26, 2023

Copy link
Copy Markdown
Contributor

This PR fixes SSL connection attempts by not attempting to restore SSL information (like server name) if such informations are not available anymore.

Fixes #48000.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. labels May 26, 2023
@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 26, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 26, 2023
@nodejs-github-bot

nodejs-github-bot commented May 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51971/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mscdex
mscdex reviewed May 26, 2023
View reviewed changes
Comment thread test/parallel/test-https-autoselectfamily-slow-timeout.js Outdated

@mscdex mscdex May 26, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this test go in test/internet/ if it's attempting to reach an internet host?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ShogunPanda ShogunPanda May 28, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I didn't know about it. Fixed now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
richardlau
richardlau reviewed May 26, 2023
View reviewed changes
Comment thread test/parallel/test-https-autoselectfamily-slow-timeout.js Outdated

@richardlau richardlau May 26, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is reaching out to the internet this should go in internet and not parallel. It should also be using a constant from common/internet to allow people to run the test suites in places that restrict access to some addresses.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ShogunPanda ShogunPanda May 28, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I didn't know about this. This is fixed now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
This was referenced May 27, 2023
CI Reliability 2023-05-27 nodejs/reliability#578
Open
CI Reliability 2023-05-28 nodejs/reliability#579
Open
@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 28, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 28, 2023
@nodejs-github-bot

nodejs-github-bot commented May 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51982/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51985/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51986/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51989/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request May 29, 2023
CI Reliability 2023-05-29 nodejs/reliability#580
Open
22 tasks
ShogunPanda added 2 commits May 29, 2023 13:01
@ShogunPanda
net: fix family autoselection SSL connection handling
e5e6ce6
@ShogunPanda
net: move test to right location
5150216
@ShogunPanda
ShogunPanda force-pushed the fix-family-autoselection-ssl-connect branch from 7425b2d to 5150216 Compare May 29, 2023 11:01
@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 29, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 29, 2023
@nodejs-github-bot

nodejs-github-bot commented May 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51998/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes May 29, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request May 30, 2023
CI Reliability 2023-05-30 nodejs/reliability#581
Open
23 tasks
@ShogunPanda

ShogunPanda commented May 30, 2023

Copy link
Copy Markdown
Contributor Author

@nodejs/build I have a failure in GH suite but I don't think it's related to my changes. Can I ignore or do you first want to address it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
marco-ippolito
marco-ippolito approved these changes May 30, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request May 31, 2023
CI Reliability 2023-05-31 nodejs/reliability#582
Open
22 tasks
This was referenced May 31, 2023
net: fix address iteration with autoSelectFamily #48258
Merged
tls: reapply servername on happy eyeballs connect #48255
Merged
@ShogunPanda

ShogunPanda commented May 31, 2023

Copy link
Copy Markdown
Contributor Author

Landed in 26450c5
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ShogunPanda added a commit that referenced this pull request May 31, 2023
@ShogunPanda
net: fix family autoselection SSL connection handling
26450c5 
PR-URL: #48189
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@ShogunPanda ShogunPanda closed this May 31, 2023
@targos

targos commented May 31, 2023

Copy link
Copy Markdown
Member

The test-internet failure was confirmed to be unrelated and we opened #48262 for it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ShogunPanda
ShogunPanda deleted the fix-family-autoselection-ssl-connect branch June 1, 2023 20:50
@ShogunPanda ShogunPanda mentioned this pull request Jun 1, 2023
test: fix tests failing only on node v20 nodejs/undici#2096
Merged
This was referenced Jun 2, 2023
CI Reliability 2023-06-02 nodejs/reliability#583
Open
CI Reliability 2023-06-03 nodejs/reliability#584
Open
CI Reliability 2023-06-04 nodejs/reliability#585
Open
targos pushed a commit that referenced this pull request Jun 4, 2023
@ShogunPanda @targos
net: fix family autoselection SSL connection handling
5ddca72 
PR-URL: #48189
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
@danielleadams danielleadams added the backport-requested-v18.x label Jun 30, 2023
@mhdawson mhdawson mentioned this pull request Jul 27, 2023
net: rework autoSelectFamily implementation #46587
Merged
@mhdawson mhdawson mentioned this pull request Aug 4, 2023
[v18.x] Backport 48969 to v18.x staging #49016
Closed
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@ShogunPanda @Ceres6
net: fix family autoselection SSL connection handling
63877ea 
PR-URL: nodejs#48189
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@ShogunPanda @Ceres6
net: fix family autoselection SSL connection handling
20ecd6c 
PR-URL: nodejs#48189
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@mhdawson mhdawson mentioned this pull request Aug 15, 2023
Backport 48969 to v18.x staging v2 #49183
Closed
@mhdawson mhdawson added the backport-open-v18.x label Aug 15, 2023
mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Aug 15, 2023
@ShogunPanda @mhdawson
net: fix family autoselection SSL connection handling
009414e 
PR-URL: nodejs#48189
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 17, 2023
@ShogunPanda @ruyadorno
net: fix family autoselection SSL connection handling
b5f53d9 
PR-URL: #48189
Backport-PR-URL: #49183
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@ruyadorno ruyadorno added backported-to-v18.x and removed backport-requested-v18.x labels Aug 17, 2023
@ruyadorno ruyadorno mentioned this pull request Aug 17, 2023
v18.18.0 proposal #49220
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau left review comments
@jasnell jasnell jasnell approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
+1 more reviewer
@mscdex mscdex mscdex left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assertion (wrap->ssl_) != nullptr failed in TLSWrap::GetServername

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@ShogunPanda @nodejs-github-bot @targos @mscdex @jasnell @richardlau @marco-ippolito @ruyadorno @danielleadams @mhdawson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.