GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: use lower security level in s_client by lpinca · Pull Request #48192 · nodejs/node

Conversation

@lpinca

@lpinca lpinca commented May 26, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

With the default security level (SECLEVEL=2), the following error

40E72B52DB7F0000:error:0A00018A:SSL routines:tls_process_ske_dhe:dh key
too small:../deps/openssl/openssl/ssl/statem/statem_clnt.c:2100

is raised on on Ubuntu 22.04 on WSL2.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels May 26, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 26, 2023
@lpinca
test: use lower security level in s_client
4c6ea53 
With the default security level (SECLEVEL=2), the following error

```
40E72B52DB7F0000:error:0A00018A:SSL routines:tls_process_ske_dhe:dh key
too small:../deps/openssl/openssl/ssl/statem/statem_clnt.c:2100
```

is raised on on Ubuntu 22.04 on WSL2.
@lpinca
lpinca force-pushed the set/seclevel-for-s_client branch from c91a637 to 4c6ea53 Compare May 26, 2023 15:50
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 26, 2023
@nodejs-github-bot

nodejs-github-bot commented May 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51972/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca

lpinca commented May 27, 2023

Copy link
Copy Markdown
Member Author

This is the full output

$ ./tools/test.py test/parallel/test-tls-dhe.js
=== release test-tls-dhe ===
Path: parallel/test-tls-dhe
node:assert:991
    throw newErr;
    ^

AssertionError [ERR_ASSERTION]: ifError got unwanted exception: Command failed: /home/luigi/node/out/Release/openssl-cli s_client -connect 127.0.0.1:35673 -cipher DHE-RSA-AES128-SHA256:ECDHE-RSA-AES128-SHA256
Can't use SSL_get_servername
depth=0 C = US, ST = CA, L = SF, O = Joyent, OU = Node.js, CN = agent2, emailAddress = [email protected]
verify error:num=18:self-signed certificate
verify return:1
depth=0 C = US, ST = CA, L = SF, O = Joyent, OU = Node.js, CN = agent2, emailAddress = [email protected]
verify return:1
40E72B52DB7F0000:error:0A00018A:SSL routines:tls_process_ske_dhe:dh key too small:../deps/openssl/openssl/ssl/statem/statem_clnt.c:2100:

    at /home/luigi/node/test/common/index.js:426:12
    at /home/luigi/node/test/common/index.js:463:15
    at ChildProcess.exithandler (node:child_process:427:5)
    at ChildProcess.exithandler (node:child_process:419:12)
    at ChildProcess.emit (node:events:511:28)
    at maybeClose (node:internal/child_process:1098:16)
    at ChildProcess._handle.onexit (node:internal/child_process:304:5) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: Error: Command failed: /home/luigi/node/out/Release/openssl-cli s_client -connect 127.0.0.1:35673 -cipher DHE-RSA-AES128-SHA256:ECDHE-RSA-AES128-SHA256
  Can't use SSL_get_servername
  depth=0 C = US, ST = CA, L = SF, O = Joyent, OU = Node.js, CN = agent2, emailAddress = [email protected]
  verify error:num=18:self-signed certificate
  verify return:1
  depth=0 C = US, ST = CA, L = SF, O = Joyent, OU = Node.js, CN = agent2, emailAddress = [email protected]
  verify return:1
  40E72B52DB7F0000:error:0A00018A:SSL routines:tls_process_ske_dhe:dh key too small:../deps/openssl/openssl/ssl/statem/statem_clnt.c:2100:

      at ChildProcess.exithandler (node:child_process:419:12)
      at ChildProcess.emit (node:events:511:28)
      at maybeClose (node:internal/child_process:1098:16)
      at ChildProcess._handle.onexit (node:internal/child_process:304:5) {
    code: 1,
    killed: false,
    signal: null,
    cmd: '/home/luigi/node/out/Release/openssl-cli s_client -connect 127.0.0.1:35673 -cipher DHE-RSA-AES128-SHA256:ECDHE-RSA-AES128-SHA256'
  },
  expected: null,
  operator: 'ifError'
}

Node.js v21.0.0-pre
Command: out/Release/node --no-warnings /home/luigi/node/test/parallel/test-tls-dhe.js


[00:00|% 100|+   0|-   1]: Done

Failed tests:
out/Release/node --no-warnings /home/luigi/node/test/parallel/test-tls-dhe.js
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnoordhuis
bnoordhuis approved these changes May 27, 2023
View reviewed changes
jasnell
jasnell approved these changes May 29, 2023
View reviewed changes
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label May 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 29, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 20080f9 into nodejs:main May 29, 2023
@nodejs-github-bot

nodejs-github-bot commented May 29, 2023

Copy link
Copy Markdown
Collaborator

Landed in 20080f9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca
lpinca deleted the set/seclevel-for-s_client branch May 29, 2023 19:26
targos pushed a commit that referenced this pull request May 30, 2023
@lpinca @targos
test: use lower security level in s_client
e12ee59 
With the default security level (SECLEVEL=2), the following error

```
40E72B52DB7F0000:error:0A00018A:SSL routines:tls_process_ske_dhe:dh key
too small:../deps/openssl/openssl/ssl/statem/statem_clnt.c:2100
```

is raised on on Ubuntu 22.04 on WSL2.

PR-URL: #48192
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@richardlau richardlau added the lts-watch-v18.x label Jun 2, 2023
@richardlau richardlau mentioned this pull request Jun 2, 2023
ansible: add Ubuntu 22.04 sharedlibs container nodejs/build#3371
Merged
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
richardlau pushed a commit to richardlau/node-1 that referenced this pull request Jul 6, 2023
@lpinca @richardlau
test: use lower security level in s_client
ee8fc9b 
With the default security level (SECLEVEL=2), the following error

```
40E72B52DB7F0000:error:0A00018A:SSL routines:tls_process_ske_dhe:dh key
too small:../deps/openssl/openssl/ssl/statem/statem_clnt.c:2100
```

is raised on on Ubuntu 22.04 on WSL2.

PR-URL: nodejs#48192
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@lpinca @danielleadams
test: use lower security level in s_client
8512e64 
With the default security level (SECLEVEL=2), the following error

```
40E72B52DB7F0000:error:0A00018A:SSL routines:tls_process_ske_dhe:dh key
too small:../deps/openssl/openssl/ssl/statem/statem_clnt.c:2100
```

is raised on on Ubuntu 22.04 on WSL2.

PR-URL: #48192
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@lpinca @MoLow
test: use lower security level in s_client
a9d0b8d 
With the default security level (SECLEVEL=2), the following error

```
40E72B52DB7F0000:error:0A00018A:SSL routines:tls_process_ske_dhe:dh key
too small:../deps/openssl/openssl/ssl/statem/statem_clnt.c:2100
```

is raised on on Ubuntu 22.04 on WSL2.

PR-URL: nodejs#48192
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
test: use lower security level in s_client
e1e285d 
With the default security level (SECLEVEL=2), the following error

```
40E72B52DB7F0000:error:0A00018A:SSL routines:tls_process_ske_dhe:dh key
too small:../deps/openssl/openssl/ssl/statem/statem_clnt.c:2100
```

is raised on on Ubuntu 22.04 on WSL2.

PR-URL: nodejs#48192
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
test: use lower security level in s_client
909dc04 
With the default security level (SECLEVEL=2), the following error

```
40E72B52DB7F0000:error:0A00018A:SSL routines:tls_process_ske_dhe:dh key
too small:../deps/openssl/openssl/ssl/statem/statem_clnt.c:2100
```

is raised on on Ubuntu 22.04 on WSL2.

PR-URL: nodejs#48192
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos added backported-to-v18.x and removed lts-watch-v18.x labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@jasnell jasnell jasnell approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@lpinca @nodejs-github-bot @bnoordhuis @jasnell @targos @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.