GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc,vm: clarify usage of `cachedData` in `vm.compileFunction()` by RaisinTen · Pull Request #48193 · nodejs/node

Conversation

@RaisinTen

@RaisinTen RaisinTen commented May 26, 2023

Copy link
Copy Markdown
Member

Fixes: #48175

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RaisinTen
doc,vm: clarify usage of cachedData in vm.compileFunction()
55706b4 
Fixes: nodejs#48175
Signed-off-by: Darshan Sen <[email protected]>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. vm Issues and PRs related to the vm subsystem. labels May 26, 2023
@RaisinTen RaisinTen mentioned this pull request May 26, 2023
Function returned by vm.compileFunction can't accept arguments when cachedData is passed #48175
Closed
debadree25
debadree25 approved these changes May 26, 2023
View reviewed changes
@debadree25 debadree25 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 26, 2023
lpinca
lpinca approved these changes May 28, 2023
View reviewed changes
@RaisinTen RaisinTen added the commit-queue PRs queued for automated landing through the Commit Queue. label May 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 29, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 023e880 into nodejs:main May 29, 2023
@nodejs-github-bot

nodejs-github-bot commented May 29, 2023

Copy link
Copy Markdown
Collaborator

Landed in 023e880
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen
RaisinTen deleted the doc-vm-clarify-usage-of-cachedData-in-compileFunction branch May 29, 2023 01:27
targos pushed a commit that referenced this pull request May 30, 2023
@RaisinTen @targos
doc,vm: clarify usage of cachedData in vm.compileFunction()
802db92 
Fixes: #48175
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #48193
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@RaisinTen @danielleadams
doc,vm: clarify usage of cachedData in vm.compileFunction()
71cc43e 
Fixes: #48175
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: #48193
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@RaisinTen @MoLow
doc,vm: clarify usage of cachedData in vm.compileFunction()
563f9fe 
Fixes: nodejs#48175
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: nodejs#48193
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RaisinTen @Ceres6
doc,vm: clarify usage of cachedData in vm.compileFunction()
566bba0 
Fixes: nodejs#48175
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: nodejs#48193
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RaisinTen @Ceres6
doc,vm: clarify usage of cachedData in vm.compileFunction()
8630358 
Fixes: nodejs#48175
Signed-off-by: Darshan Sen <[email protected]>
PR-URL: nodejs#48193
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
+1 more reviewer
@debadree25 debadree25 debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Function returned by vm.compileFunction can't accept arguments when cachedData is passed

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@RaisinTen @nodejs-github-bot @lpinca @debadree25
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.