GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update codeowners with website team by ovflowd · Pull Request #48197 · nodejs/node

Conversation

@ovflowd

@ovflowd ovflowd commented May 26, 2023

Copy link
Copy Markdown
Member

This PR updates the CODEOWNERS file to manually ping the Website Team with changes to /tool/doc and /doc/api.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ovflowd
doc: update codeowners with website team
e74bb65
@nodejs-github-bot

nodejs-github-bot commented May 26, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 26, 2023
@ovflowd
doc: added remaining doc folders to website
f4a169a
@tniessen

tniessen commented May 26, 2023

Copy link
Copy Markdown
Member

FWIW, /doc/api will create a lot of noise. We already have a @nodejs/documentation team and we don't even ping that team for /doc/api AFAIK.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ovflowd

ovflowd commented May 27, 2023

Copy link
Copy Markdown
Member Author

Afaik the @nodejs/documentation team is going to be sunset/removed because of lack of activity?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ovflowd
doc: do not ping to /api/
f5d6585
Trott
Trott approved these changes May 27, 2023
View reviewed changes
lpinca
lpinca approved these changes May 28, 2023
View reviewed changes
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label May 28, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels May 28, 2023
@nodejs-github-bot

This comment was marked as off-topic.

Sign in to view
@debadree25 debadree25 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels May 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 29, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 191dce8 into main May 29, 2023
@nodejs-github-bot
nodejs-github-bot deleted the ovflowd-patch-1 branch May 29, 2023 09:22
@nodejs-github-bot

nodejs-github-bot commented May 29, 2023

Copy link
Copy Markdown
Collaborator

Landed in 191dce8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ovflowd

ovflowd commented May 29, 2023

Copy link
Copy Markdown
Member Author

Thank you all!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 30, 2023
@ovflowd @targos
doc: update codeowners with website team
2b51ee5 
PR-URL: #48197
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@ovflowd @danielleadams
doc: update codeowners with website team
1be3222 
PR-URL: #48197
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@ovflowd @MoLow
doc: update codeowners with website team
19ad471 
PR-URL: nodejs#48197
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@ovflowd @Ceres6
doc: update codeowners with website team
275f8e9 
PR-URL: nodejs#48197
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@ovflowd @Ceres6
doc: update codeowners with website team
4701b5c 
PR-URL: nodejs#48197
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@ovflowd @nodejs-github-bot @tniessen @Trott @lpinca @debadree25
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.