GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: authenticate github api request to avoid rate limit by fasenderos · Pull Request #48200 · nodejs/node

Conversation

@fasenderos

@fasenderos fasenderos commented May 27, 2023

Copy link
Copy Markdown
Contributor

Fixes: #48119
Refs: nodejs/security-wg#973

Added authorization header to authenticate Github api requests in the dependency update workflow

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@fasenderos
tools: deps update authenticate github api request
dc2c619
@nodejs-github-bot

nodejs-github-bot commented May 27, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 27, 2023
@fasenderos fasenderos mentioned this pull request May 27, 2023
Dependency update automation improvements nodejs/security-wg#973
Closed
7 of 9 tasks
UlisesGascon
UlisesGascon approved these changes May 27, 2023
View reviewed changes
lpinca
lpinca approved these changes May 27, 2023
View reviewed changes
marco-ippolito
marco-ippolito approved these changes May 27, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels May 27, 2023
Mesteery
Mesteery reviewed May 27, 2023
View reviewed changes
Comment thread tools/dep_updaters/update-ada.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito marco-ippolito mentioned this pull request May 28, 2023
deps: update eslint job failed #48213
Closed
MoLow
MoLow approved these changes May 28, 2023
View reviewed changes
fasenderos and others added 3 commits May 29, 2023 00:22
@fasenderos @Mesteery
Update tools/dep_updaters/update-ada.sh
9bfeedf 
Co-authored-by: Mestery <[email protected]>
@fasenderos
tools: authenticated request if GITHUB_TOKEN exist
9d338f7
@fasenderos
tools: format code
fde737d
Mesteery
Mesteery approved these changes May 28, 2023
View reviewed changes
@debadree25 debadree25 added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label May 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 29, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 40b89c5 into nodejs:main May 29, 2023
@nodejs-github-bot

nodejs-github-bot commented May 29, 2023

Copy link
Copy Markdown
Collaborator

Landed in 40b89c5
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@fasenderos
fasenderos deleted the deps-auth-requests branch May 29, 2023 15:58
targos pushed a commit that referenced this pull request May 30, 2023
@fasenderos @targos
tools: deps update authenticate github api request
a60bc41 
PR-URL: #48200
Fixes: #48119
Refs: nodejs/security-wg#973
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mestery <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
@danielleadams danielleadams added the backport-requested-v18.x label Jun 30, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@fasenderos @Ceres6
tools: deps update authenticate github api request
6e77e60 
PR-URL: nodejs#48200
Fixes: nodejs#48119
Refs: nodejs/security-wg#973
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mestery <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@fasenderos @Ceres6
tools: deps update authenticate github api request
028be86 
PR-URL: nodejs#48200
Fixes: nodejs#48119
Refs: nodejs/security-wg#973
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Mestery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@MoLow MoLow MoLow approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
+1 more reviewer
@Mesteery Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tools updater throws 402 rate limit exceeded error

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@fasenderos @nodejs-github-bot @lpinca @UlisesGascon @MoLow @marco-ippolito @Mesteery @danielleadams @aduh95 @debadree25
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.