GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: fix global after hook by MoLow · Pull Request #48231 · nodejs/node

Conversation

@MoLow

@MoLow MoLow commented May 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes: #48230

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and tonivj5 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@MoLow
test_runner: fix global after hook
9d6fd55
@MoLow
MoLow requested a review from cjihrig May 28, 2023 14:52
@nodejs-github-bot

nodejs-github-bot commented May 28, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 28, 2023
atlowChemi
atlowChemi reviewed May 28, 2023
View reviewed changes
Comment thread lib/internal/test_runner/test.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig reviewed May 29, 2023
View reviewed changes
Comment thread lib/internal/test_runner/harness.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/test_runner/test.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
CR
969de02
@MoLow

MoLow commented May 30, 2023

Copy link
Copy Markdown
Member Author

@cjihrig I just pushed a fix making root test use run and this way it gets all the logic and hooks included inside run OOTB.
this meant I had to adjust run to be 100% synchronous in cases we use it for the root test
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi
atlowChemi reviewed May 30, 2023
View reviewed changes
Comment thread lib/internal/test_runner/test.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow requested a review from cjihrig May 30, 2023 20:02
cjihrig
cjihrig reviewed May 31, 2023
View reviewed changes

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this meant I had to adjust run to be 100% synchronous in cases we use it for the root test

run() can't be 100% synchronous - it's an async function.

I guess there are no implications since the tests seem to pass, but don't we call root.postRun() in runner.js? Should we be calling root.run() there instead now?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread lib/internal/test_runner/harness.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/test_runner/test.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/test_runner/test.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/test_runner/test.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@MoLow

MoLow commented May 31, 2023

Copy link
Copy Markdown
Member Author

but don't we call root.postRun() in runner.js? Should we be calling root.run() there instead now?

well in runner.js we run test files only, and we use a root that is not global (created using createTestTree), so there is no need to use run since it is impossible to set hooks or anything else that run handles
cjihrig reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
CR 1
ca8e7bf
benjamingr
benjamingr approved these changes May 31, 2023
View reviewed changes
cjihrig
cjihrig approved these changes May 31, 2023
View reviewed changes
@MoLow MoLow added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels May 31, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 31, 2023
@nodejs-github-bot

nodejs-github-bot commented May 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52015/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52018/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52020/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52023/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label May 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 31, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 5e98a74 into nodejs:main May 31, 2023
@nodejs-github-bot

nodejs-github-bot commented May 31, 2023

Copy link
Copy Markdown
Collaborator

Landed in 5e98a74
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow deleted the fix-global-after branch May 31, 2023 15:33
@github-actions github-actions Bot mentioned this pull request Jun 2, 2023
CI Reliability 2023-06-02 nodejs/reliability#583
Open
34 tasks
This was referenced Jun 3, 2023
CI Reliability 2023-06-03 nodejs/reliability#584
Open
CI Reliability 2023-06-04 nodejs/reliability#585
Open
targos pushed a commit that referenced this pull request Jun 4, 2023
@MoLow @targos
test_runner: fix global after hook
f3268d6 
PR-URL: #48231
Fixes: #48230
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
@github-actions github-actions Bot mentioned this pull request Jun 5, 2023
CI Reliability 2023-06-05 nodejs/reliability#586
Open
30 tasks
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@MoLow @danielleadams
test_runner: fix global after hook
44d17d6 
PR-URL: #48231
Fixes: #48230
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
@MoLow
test_runner: fix global after hook
6a82fbd 
PR-URL: nodejs#48231
Fixes: nodejs#48230
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: fix global after hook
f044963 
PR-URL: nodejs#48231
Fixes: nodejs#48230
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: fix global after hook
178db24 
PR-URL: nodejs#48231
Fixes: nodejs#48230
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atlowChemi atlowChemi atlowChemi left review comments
@benjamingr benjamingr benjamingr approved these changes
@cjihrig cjihrig cjihrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test-runner: global after not working

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@MoLow @nodejs-github-bot @benjamingr @cjihrig @atlowChemi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.