GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — module: reduce the number of URL initializations by anonrig · Pull Request #48272 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented May 31, 2023

Copy link
Copy Markdown
Member

This reduces the number of URL creations. There are still a lot of unnecessary URL initializations, but I believe we are moving in the right direction.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss, H4ad, and lin72h reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@anonrig
module: reduce the number of URL initializations
6aabf1a
@nodejs-github-bot

nodejs-github-bot commented May 31, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels May 31, 2023
GeoffreyBooth
GeoffreyBooth approved these changes May 31, 2023
View reviewed changes

@GeoffreyBooth GeoffreyBooth left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread lib/internal/modules/esm/get_format.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/modules/esm/get_format.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
fixup! module: reduce the number of URL initializations
88bde4c
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels May 31, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 31, 2023
@nodejs-github-bot

nodejs-github-bot commented May 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52037/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
GeoffreyBooth
GeoffreyBooth approved these changes May 31, 2023
View reviewed changes
KhafraDev
KhafraDev approved these changes Jun 1, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52040/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig mentioned this pull request Jun 1, 2023
Reduce URL initializations in ESM nodejs/performance#92
Closed
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52053/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Mesteery
Mesteery approved these changes Jun 1, 2023
View reviewed changes
lpinca
lpinca approved these changes Jun 2, 2023
View reviewed changes
jasnell
jasnell approved these changes Jun 3, 2023
View reviewed changes
anonrig added a commit that referenced this pull request Jun 3, 2023
@anonrig
module: reduce the number of URL initializations
54e0cb5 
PR-URL: #48272
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@anonrig

anonrig commented Jun 3, 2023

Copy link
Copy Markdown
Member Author

Landed in 54e0cb5
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig closed this Jun 3, 2023
targos pushed a commit that referenced this pull request Jun 4, 2023
@anonrig @targos
module: reduce the number of URL initializations
6d6bf3e 
PR-URL: #48272
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@anonrig @danielleadams
module: reduce the number of URL initializations
e816cd2 
PR-URL: #48272
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@anonrig @MoLow
module: reduce the number of URL initializations
5d75ec4 
PR-URL: nodejs#48272
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
aduh95 added a commit to aduh95/node that referenced this pull request Aug 13, 2023
@aduh95
esm: align sync and async load implementations
76f1380 
Refs: nodejs#48272
@aduh95 aduh95 mentioned this pull request Aug 13, 2023
esm: align sync and async load implementations #49152
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@anonrig @Ceres6
module: reduce the number of URL initializations
8819352 
PR-URL: nodejs#48272
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@anonrig @Ceres6
module: reduce the number of URL initializations
740c136 
PR-URL: nodejs#48272
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Aug 20, 2023
@aduh95
esm: align sync and async load implementations
2557932 
Refs: #48272
PR-URL: #49152
Refs: #47999
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@aduh95 @UlisesGascon
esm: align sync and async load implementations
a6cfea3 
Refs: #48272
PR-URL: #49152
Refs: #47999
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@lpinca lpinca lpinca approved these changes
@KhafraDev KhafraDev KhafraDev approved these changes
+1 more reviewer
@Mesteery Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@anonrig @nodejs-github-bot @jasnell @GeoffreyBooth @lpinca @KhafraDev @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.