GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: apply `runOnly` on suites by MoLow · Pull Request #48279 · nodejs/node

Conversation

@MoLow

@MoLow MoLow commented Jun 1, 2023

Copy link
Copy Markdown
Member

Fixes: #47937

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and tonivj5 reacted with thumbs up emoji tonivj5 reacted with heart emoji tonivj5 reacted with rocket emoji
All reactions
  • 👍 2 reactions
  • ❤️ 1 reaction
  • 🚀 1 reaction
@MoLow
test_runner: apply runOnly on suites
6dd1122
@MoLow
MoLow requested review from benjamingr and cjihrig June 1, 2023 10:06
@nodejs-github-bot

nodejs-github-bot commented Jun 1, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jun 1, 2023
@MoLow

MoLow commented Jun 3, 2023

Copy link
Copy Markdown
Member Author

ping @nodejs/test_runner can someone take a look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ljharb
ljharb approved these changes Jun 3, 2023
View reviewed changes
aduh95
aduh95 approved these changes Jun 3, 2023
View reviewed changes
cjihrig
cjihrig approved these changes Jun 4, 2023
View reviewed changes
@MoLow MoLow added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jun 4, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 4, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52080/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Jun 4, 2023
View reviewed changes
MoLow added a commit that referenced this pull request Jun 4, 2023
@MoLow
test_runner: apply runOnly on suites
5c27cc2 
PR-URL: #48279
Fixes: #47937
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@MoLow

MoLow commented Jun 4, 2023

Copy link
Copy Markdown
Member Author

Landed in 5c27cc2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow closed this Jun 4, 2023
@MoLow
MoLow deleted the fix-suite-children-only branch June 4, 2023 21:06
@github-actions github-actions Bot mentioned this pull request Jun 5, 2023
CI Reliability 2023-06-05 nodejs/reliability#586
Open
30 tasks
targos pushed a commit that referenced this pull request Jun 5, 2023
@MoLow @targos
test_runner: apply runOnly on suites
44411fc 
PR-URL: #48279
Fixes: #47937
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@targos targos mentioned this pull request Jun 5, 2023
v20.3.0 release proposal #48332
Merged
This was referenced Jun 6, 2023
CI Reliability 2023-06-06 nodejs/reliability#587
Open
CI Reliability 2023-06-09 nodejs/reliability#588
Open
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@MoLow @danielleadams
test_runner: apply runOnly on suites
45c1ea8 
PR-URL: #48279
Fixes: #47937
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
@MoLow
test_runner: apply runOnly on suites
2262653 
PR-URL: nodejs#48279
Fixes: nodejs#47937
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: apply runOnly on suites
cf0c2f3 
PR-URL: nodejs#48279
Fixes: nodejs#47937
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
test_runner: apply runOnly on suites
7d68a89 
PR-URL: nodejs#48279
Fixes: nodejs#47937
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes
@benjamingr benjamingr benjamingr approved these changes
@cjihrig cjihrig cjihrig approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

it.only inside describe.only run all other its as well

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@MoLow @nodejs-github-bot @ljharb @benjamingr @cjihrig @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.