GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib: create weakRef only if any signals provided by atlowChemi · Pull Request #48448 · nodejs/node

Conversation

@atlowChemi

@atlowChemi atlowChemi commented Jun 13, 2023

Copy link
Copy Markdown
Member

Fixes: #48419

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and lin72h reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 13, 2023
@atlowChemi
atlowChemi requested review from Linkgoron and MoLow June 13, 2023 12:44
Linkgoron
Linkgoron reviewed Jun 13, 2023
View reviewed changes
Comment thread lib/internal/abort_controller.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@atlowChemi
atlowChemi force-pushed the lib--create-weakRef-only-if-any-signals-provided branch from b74da91 to f70772d Compare June 13, 2023 12:48
@atlowChemi
atlowChemi requested a review from Linkgoron June 13, 2023 12:48
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 13, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52238/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed Jun 13, 2023
View reviewed changes
Comment thread lib/internal/abort_controller.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Linkgoron
Linkgoron reviewed Jun 13, 2023
View reviewed changes
Comment thread lib/internal/abort_controller.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@atlowChemi
atlowChemi force-pushed the lib--create-weakRef-only-if-any-signals-provided branch from f70772d to 26d8fbe Compare June 13, 2023 13:48
Linkgoron
Linkgoron reviewed Jun 13, 2023
View reviewed changes
Comment thread lib/internal/abort_controller.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@atlowChemi
lib: create weakRef only if any signals provided
6cb4ad9
@atlowChemi
atlowChemi force-pushed the lib--create-weakRef-only-if-any-signals-provided branch from 26d8fbe to 6cb4ad9 Compare June 13, 2023 14:18
aduh95
aduh95 approved these changes Jun 13, 2023
View reviewed changes
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 13, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52240/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Linkgoron
Linkgoron approved these changes Jun 13, 2023
View reviewed changes
@atlowChemi atlowChemi added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jun 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52243/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes Jun 13, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Jun 14, 2023
CI Reliability 2023-06-14 nodejs/reliability#593
Open
20 tasks
@atlowChemi atlowChemi added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 14, 2023
lpinca
lpinca approved these changes Jun 14, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Jun 15, 2023
CI Reliability 2023-06-15 nodejs/reliability#594
Open
22 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 15, 2023
@nodejs-github-bot
nodejs-github-bot merged commit f3ee4e2 into nodejs:main Jun 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 15, 2023

Copy link
Copy Markdown
Collaborator

Landed in f3ee4e2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@atlowChemi
atlowChemi deleted the lib--create-weakRef-only-if-any-signals-provided branch June 15, 2023 12:56
@github-actions github-actions Bot mentioned this pull request Jun 21, 2023
CI Reliability 2023-06-21 nodejs/reliability#595
Open
29 tasks
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@atlowChemi @RafaelGSS
lib: create weakRef only if any signals provided
8c2c02d 
PR-URL: #48448
Fixes: #48419
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
@atlowChemi atlowChemi mentioned this pull request Jul 16, 2023
[v18.x backport] lib: implement AbortSignal.any() #48800
Closed
atlowChemi added a commit to atlowChemi/node that referenced this pull request Jul 17, 2023
@atlowChemi
lib: create weakRef only if any signals provided
a30ecab 
PR-URL: nodejs#48448
Fixes: nodejs#48419
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 17, 2023
@atlowChemi @danielleadams
lib: create weakRef only if any signals provided
156292d 
PR-URL: #48448
Backport-PR-URL: #48800
Fixes: #48419
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams added the backported-to-v18.x label Jul 17, 2023
@danielleadams danielleadams mentioned this pull request Jul 18, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
lib: create weakRef only if any signals provided
4198d5c 
PR-URL: nodejs#48448
Fixes: nodejs#48419
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
lib: create weakRef only if any signals provided
30b380c 
PR-URL: nodejs#48448
Fixes: nodejs#48419
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@MoLow MoLow MoLow approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@Linkgoron Linkgoron Linkgoron approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AbortSignal.any() not destroyed when goes out of scope

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@atlowChemi @nodejs-github-bot @Linkgoron @lpinca @MoLow @aduh95 @danielleadams
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.