GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v18.x backport] lib: implement AbortSignal.any() by atlowChemi · Pull Request #48800 · nodejs/node

Conversation

@atlowChemi

@atlowChemi atlowChemi commented Jul 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Refs: #47821, #48448

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v18.x labels Jul 16, 2023
atlowChemi
atlowChemi commented Jul 16, 2023
View reviewed changes
Comment thread test/common/wpt.js Outdated

@atlowChemi atlowChemi Jul 16, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this change is really related / wanted here

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@atlowChemi atlowChemi added the abortcontroller Issues and PRs related to the AbortController and AbortSignal APIs. label Jul 16, 2023
atlowChemi added 2 commits July 17, 2023 07:55
@atlowChemi
lib: implement AbortSignal.any()
82fe050 
PR-URL: nodejs#47821
Fixes: nodejs#47811
Refs: whatwg/dom#1152
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@atlowChemi
lib: create weakRef only if any signals provided
a30ecab 
PR-URL: nodejs#48448
Fixes: nodejs#48419
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@atlowChemi
atlowChemi force-pushed the v18-backport-abortSignal.any branch from 4e57bf1 to a30ecab Compare July 17, 2023 04:55
@atlowChemi atlowChemi added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jul 17, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52803/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@atlowChemi atlowChemi mentioned this pull request Jul 17, 2023
v18.17.0 release proposal #48694
Merged
danielleadams
danielleadams approved these changes Jul 17, 2023
View reviewed changes
danielleadams pushed a commit that referenced this pull request Jul 17, 2023
@atlowChemi @danielleadams
lib: implement AbortSignal.any()
efaa073 
PR-URL: #47821
Backport-PR-URL: #48800
Fixes: #47811
Refs: whatwg/dom#1152
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this pull request Jul 17, 2023
@atlowChemi @danielleadams
lib: create weakRef only if any signals provided
156292d 
PR-URL: #48448
Backport-PR-URL: #48800
Fixes: #48419
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams

danielleadams commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

Landed in d002f9b...156292d
atlowChemi reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danielleadams danielleadams closed this Jul 17, 2023
@atlowChemi
atlowChemi deleted the v18-backport-abortSignal.any branch August 27, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@danielleadams danielleadams danielleadams approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

abortcontroller Issues and PRs related to the AbortController and AbortSignal APIs. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@atlowChemi @nodejs-github-bot @danielleadams
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.