GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: mark test-child-process-stdio-reuse-readable-stdio flaky by lpinca · Pull Request #48537 · nodejs/node

Conversation

@lpinca

@lpinca lpinca commented Jun 24, 2023

Copy link
Copy Markdown
Member

Refs: #48300 (comment)
Refs: nodejs/reliability#597 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lpinca
test: mark test-child-process-stdio-reuse-readable-stdio flaky
90f4bb1 
Refs: nodejs#48300 (comment)
Refs: nodejs/reliability#597 (comment)
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Jun 24, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 24, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52430/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Jun 24, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Jun 25, 2023
CI Reliability 2023-06-25 nodejs/reliability#598
Open
25 tasks
@nodejs-github-bot

nodejs-github-bot commented Jun 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52449/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes Jun 25, 2023
View reviewed changes
@MoLow MoLow added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jun 25, 2023
@github-actions

github-actions Bot commented Jun 25, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.
benjamingr reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52454/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Jun 25, 2023
View reviewed changes
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 25, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit c308054 into nodejs:main Jun 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in c308054
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca
lpinca deleted the mark/test-child-process-stdio-reuse-readable-stdio-flaky branch June 25, 2023 16:14
This was referenced Jun 26, 2023
CI Reliability 2023-06-26 nodejs/reliability#599
Open
CI Reliability 2023-06-27 nodejs/reliability#600
Open
CI Reliability 2023-06-28 nodejs/reliability#601
Open
CI Reliability 2023-06-29 nodejs/reliability#602
Open
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jun 29, 2023
@lpinca @juanarbol
test: mark test-child-process-stdio-reuse-readable-stdio flaky
5daa07a 
Refs: nodejs#48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: nodejs#48537
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@lpinca @RafaelGSS
test: mark test-child-process-stdio-reuse-readable-stdio flaky
0f912a7 
Refs: #48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: #48537
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
juanarbol pushed a commit that referenced this pull request Jul 4, 2023
@lpinca @juanarbol
test: mark test-child-process-stdio-reuse-readable-stdio flaky
2edd0fd 
Refs: #48300 (comment)
Refs: nodejs/reliability#597 (comment)
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #48537
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
richardlau pushed a commit that referenced this pull request Jul 11, 2023
@lpinca @richardlau
test: mark test-child-process-stdio-reuse-readable-stdio flaky
859aa87 
Refs: #48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: #48537
Backport-PR-URL: #48650
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
test: mark test-child-process-stdio-reuse-readable-stdio flaky
5f92b46 
Refs: nodejs#48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: nodejs#48537
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
test: mark test-child-process-stdio-reuse-readable-stdio flaky
4339923 
Refs: nodejs#48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: nodejs#48537
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request May 5, 2024
@lpinca @StefanStojanovic
test: mark test-child-process-stdio-reuse-readable-stdio flaky
f42996e 
Refs: nodejs/node#48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: nodejs/node#48537
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@anonrig anonrig anonrig approved these changes
@MoLow MoLow MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@lpinca @nodejs-github-bot @benjamingr @anonrig @MoLow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.