GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v16.x] test: mark flaky parallel tests by StefanStojanovic · Pull Request #48650 · nodejs/node

Conversation

@StefanStojanovic

@StefanStojanovic StefanStojanovic commented Jul 4, 2023

Copy link
Copy Markdown
Contributor

As mentioned in #48345 (comment), the v16.x-staging branch is missing flaky tests, which makes the daily job fail constantly. This PR marks the flaky tests, for the v16 branch, in the same way as #48601 does for the v18 branch.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
MoLow and others added 2 commits July 4, 2023 13:56
@MoLow @StefanStojanovic
test: mark test-child-process-pipe-dataflow as flaky
5f5834f 
PR-URL: nodejs#48334
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@lpinca @StefanStojanovic
test: mark test-child-process-stdio-reuse-readable-stdio flaky
f42996e 
Refs: nodejs#48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: nodejs#48537
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. v16.x labels Jul 4, 2023
MoLow
MoLow approved these changes Jul 4, 2023
View reviewed changes
@MoLow MoLow added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jul 4, 2023
@github-actions

github-actions Bot commented Jul 4, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.
StefanStojanovic, lpinca, juanarbol, and anonrig reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 4, 2023
richardlau
richardlau approved these changes Jul 4, 2023
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 4, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52596/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Jul 4, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jul 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52600/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Jul 6, 2023
View reviewed changes
@StefanStojanovic

StefanStojanovic commented Jul 10, 2023

Copy link
Copy Markdown
Contributor Author

Is there something else I can do to help move this forward?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau pushed a commit that referenced this pull request Jul 11, 2023
@MoLow @richardlau
test: mark test-child-process-pipe-dataflow as flaky
42030f7 
PR-URL: #48334
Backport-PR-URL: #48650
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 11, 2023
@lpinca @richardlau
test: mark test-child-process-stdio-reuse-readable-stdio flaky
859aa87 
Refs: #48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: #48537
Backport-PR-URL: #48650
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@richardlau

richardlau commented Jul 11, 2023

Copy link
Copy Markdown
Member

Landed in 7447de2...859aa87.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@richardlau richardlau richardlau approved these changes
@MoLow MoLow MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@StefanStojanovic @nodejs-github-bot @richardlau @lpinca @anonrig @MoLow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.