GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: remove flaky designation for some tests by lpinca · Pull Request #48575 · nodejs/node

Conversation

@lpinca

@lpinca lpinca commented Jun 27, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It has been a long time since the failures have been seen in CI and I cannot reproduce them locally running

python.exe tools/test.py -J --repeat=1000 test/parallel/test-timers-immediate-queue.js
python.exe tools/test.py -J --repeat=1000 test/parallel/test-crypto-keygen.js

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Jun 27, 2023
MoLow
MoLow approved these changes Jun 27, 2023
View reviewed changes
@lpinca
lpinca force-pushed the remove/flaky-designation branch from 6104e4d to bb7a2df Compare June 27, 2023 08:46
anonrig
anonrig approved these changes Jun 27, 2023
View reviewed changes
lpinca added 2 commits June 27, 2023 17:19
@lpinca
test: remove test-timers-immediate-queue flaky designation
0f6da0e
@lpinca
test: remove test-crypto-keygen flaky designation
70d7d12
@lpinca
lpinca force-pushed the remove/flaky-designation branch from bb7a2df to 70d7d12 Compare June 27, 2023 15:19
@lpinca lpinca changed the title test: remove test-timers-immediate-queue flaky designation test: remove flaky designation for some tests Jun 27, 2023
@lpinca lpinca added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Jun 27, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52517/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52521/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52524/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva
VoltrexKeyva approved these changes Jun 27, 2023
View reviewed changes
This was referenced Jun 28, 2023
CI Reliability 2023-06-28 nodejs/reliability#601
Open
CI Reliability 2023-06-29 nodejs/reliability#602
Open
Trott
Trott approved these changes Jun 29, 2023
View reviewed changes
@Trott

This comment was marked as resolved.

Sign in to view
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 29, 2023
This was referenced Jun 29, 2023
flaky: parallel/test-timers-immediate-queue #24497
Closed
Investigate flaky test - parallel/test-crypto-keygen #41206
Closed
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 29, 2023

Copy link
Copy Markdown
Collaborator

Landed in 1683e60...893c000
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot closed this Jun 29, 2023
nodejs-github-bot pushed a commit that referenced this pull request Jun 29, 2023
@lpinca @nodejs-github-bot
test: remove test-timers-immediate-queue flaky designation
300634d 
PR-URL: #48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jun 29, 2023
@lpinca @nodejs-github-bot
test: remove test-crypto-keygen flaky designation
893c000 
PR-URL: #48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@lpinca
lpinca deleted the remove/flaky-designation branch June 29, 2023 10:35
@github-actions github-actions Bot mentioned this pull request Jun 30, 2023
CI Reliability 2023-06-30 nodejs/reliability#603
Open
33 tasks
This was referenced Jul 1, 2023
CI Reliability 2023-07-01 nodejs/reliability#604
Open
CI Reliability 2023-07-02 nodejs/reliability#605
Open
CI Reliability 2023-07-03 nodejs/reliability#606
Open
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@lpinca @RafaelGSS
test: remove test-timers-immediate-queue flaky designation
75aa0a7 
PR-URL: #48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@lpinca @RafaelGSS
test: remove test-crypto-keygen flaky designation
07eb310 
PR-URL: #48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
v20.4.0 proposal #48643
Merged
@github-actions github-actions Bot mentioned this pull request Jul 4, 2023
CI Reliability 2023-07-04 nodejs/reliability#607
Open
22 tasks
@StefanStojanovic

StefanStojanovic commented Jul 4, 2023

Copy link
Copy Markdown
Contributor

I've been going through some recent builds (after this landed) and I see that test-crypto-keygen failed in few of those runs:

  • https://ci.nodejs.org/view/All/job/node-test-commit-windows-fanned/56151/
  • https://ci.nodejs.org/view/All/job/node-test-commit-windows-fanned/56135/
  • https://ci.nodejs.org/view/All/job/node-test-commit-windows-fanned/56133/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca mentioned this pull request Jul 4, 2023
Revert "test: remove test-crypto-keygen flaky designation" #48652
Merged
lpinca added a commit to lpinca/node that referenced this pull request Jul 4, 2023
@lpinca
Revert "test: remove test-crypto-keygen flaky designation"
7c7bb6a 
This reverts commit 893c000.

Refs: nodejs#48575 (comment)
@github-actions github-actions Bot mentioned this pull request Jul 5, 2023
CI Reliability 2023-07-05 nodejs/reliability#608
Open
20 tasks
nodejs-github-bot pushed a commit that referenced this pull request Jul 5, 2023
@lpinca
Revert "test: remove test-crypto-keygen flaky designation"
08638b7 
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
juanarbol pushed a commit that referenced this pull request Jul 13, 2023
@lpinca @juanarbol
Revert "test: remove test-crypto-keygen flaky designation"
dfa0aee 
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
test: remove test-timers-immediate-queue flaky designation
b84712f 
PR-URL: nodejs#48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
test: remove test-crypto-keygen flaky designation
66ae94c 
PR-URL: nodejs#48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
Revert "test: remove test-crypto-keygen flaky designation"
a94c283 
This reverts commit 893c000.

Refs: nodejs#48575 (comment)
PR-URL: nodejs#48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
test: remove test-timers-immediate-queue flaky designation
4f80e28 
PR-URL: nodejs#48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
test: remove test-crypto-keygen flaky designation
8d48b5f 
PR-URL: nodejs#48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
Revert "test: remove test-crypto-keygen flaky designation"
f687d00 
This reverts commit 893c000.

Refs: nodejs#48575 (comment)
PR-URL: nodejs#48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@lpinca @ruyadorno
test: remove test-timers-immediate-queue flaky designation
9308992 
PR-URL: #48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@lpinca @ruyadorno
test: remove test-crypto-keygen flaky designation
87e5563 
PR-URL: #48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@lpinca @ruyadorno
Revert "test: remove test-crypto-keygen flaky designation"
cfcb3de 
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 11, 2023
v18.18.0 proposal #49220
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@lpinca @ruyadorno
test: remove test-timers-immediate-queue flaky designation
df9a9af 
PR-URL: #48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@lpinca @ruyadorno
test: remove test-crypto-keygen flaky designation
dd1805e 
PR-URL: #48575
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@lpinca @ruyadorno
Revert "test: remove test-crypto-keygen flaky designation"
0b62218 
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@lpinca @ruyadorno
Revert "test: remove test-crypto-keygen flaky designation"
a79112b 
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
@aduh95 aduh95 mentioned this pull request May 11, 2024
test: replace flaky immediates event loop test #41423
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@anonrig anonrig anonrig approved these changes
@MoLow MoLow MoLow approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@lpinca @nodejs-github-bot @Trott @StefanStojanovic @anonrig @MoLow @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.