GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "test: remove test-crypto-keygen flaky designation" by lpinca · Pull Request #48652 · nodejs/node

Conversation

@lpinca

@lpinca lpinca commented Jul 4, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 893c000.

Refs: #48575 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Jul 4, 2023
@lpinca
Revert "test: remove test-crypto-keygen flaky designation"
7c7bb6a
This reverts commit 893c000.

Refs: nodejs#48575 (comment)
@lpinca
lpinca force-pushed the revert/893c000 branch from e6b5426 to 7c7bb6a Compare July 4, 2023 13:43
richardlau
richardlau approved these changes Jul 4, 2023
View reviewed changes
StefanStojanovic
StefanStojanovic approved these changes Jul 4, 2023
View reviewed changes
@lpinca lpinca added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Jul 4, 2023
@github-actions

github-actions Bot commented Jul 4, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

StefanStojanovic, KhafraDev, and richardlau reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jul 4, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52601/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Jul 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52603/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Jul 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52604/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

KhafraDev
KhafraDev approved these changes Jul 5, 2023
View reviewed changes
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 5, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Jul 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 5, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/48652
✔  Done loading data for nodejs/node/pull/48652
----------------------------------- PR info ------------------------------------
Title      Revert "test: remove test-crypto-keygen flaky designation" (#48652)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     lpinca:revert/893c000 -> nodejs:main
Labels     test, fast-track, needs-ci
Commits    1
 - Revert "test: remove test-crypto-keygen flaky designation"
Committers 1
 - Luigi Pinca 
PR-URL: https://github.com/nodejs/node/pull/48652
Reviewed-By: Richard Lau 
Reviewed-By: Matthew Aitken 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48652
Reviewed-By: Richard Lau 
Reviewed-By: Matthew Aitken 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 04 Jul 2023 13:42:24 GMT
   ✔  Approvals: 2
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/48652#pullrequestreview-1512977268
   ✔  - Matthew Aitken (@KhafraDev): https://github.com/nodejs/node/pull/48652#pullrequestreview-1514888857
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 21 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-07-04T19:25:03Z: https://ci.nodejs.org/job/node-test-pull-request/52604/
- Querying data for job/node-test-pull-request/52604/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5466566342
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@richardlau richardlau added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Jul 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 5, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 08638b7 into nodejs:main Jul 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Jul 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in 08638b7

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lpinca
lpinca deleted the revert/893c000 branch July 5, 2023 16:41
juanarbol pushed a commit that referenced this pull request Jul 13, 2023
@lpinca @juanarbol
Revert "test: remove test-crypto-keygen flaky designation"
dfa0aee
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
@juanarbol juanarbol mentioned this pull request Jul 13, 2023
V20.5.0 proposal #48761
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
Revert "test: remove test-crypto-keygen flaky designation"
a94c283
This reverts commit 893c000.

Refs: nodejs#48575 (comment)
PR-URL: nodejs#48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@lpinca @Ceres6
Revert "test: remove test-crypto-keygen flaky designation"
f687d00
This reverts commit 893c000.

Refs: nodejs#48575 (comment)
PR-URL: nodejs#48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@lpinca @ruyadorno
Revert "test: remove test-crypto-keygen flaky designation"
cfcb3de
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 11, 2023
v18.18.0 proposal #49220
Merged
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@lpinca @ruyadorno
Revert "test: remove test-crypto-keygen flaky designation"
0b62218
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@lpinca @ruyadorno
Revert "test: remove test-crypto-keygen flaky designation"
a79112b
This reverts commit 893c000.

Refs: #48575 (comment)
PR-URL: #48652
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Sep 19, 2023
@codebytere
Revert "test: remove test-crypto-keygen flaky designation"
a3b5892
nodejs/node#48652
codebytere added a commit to electron/electron that referenced this pull request Sep 19, 2023
@codebytere
Revert "test: remove test-crypto-keygen flaky designation"
f993a1d
nodejs/node#48652
codebytere added a commit to electron/electron that referenced this pull request Sep 20, 2023
@codebytere
Revert "test: remove test-crypto-keygen flaky designation"
332800c
nodejs/node#48652
codebytere added a commit to electron/electron that referenced this pull request Sep 20, 2023
@codebytere
Revert "test: remove test-crypto-keygen flaky designation"
912ad6d
nodejs/node#48652
codebytere added a commit to electron/electron that referenced this pull request Sep 20, 2023
@codebytere
Revert "test: remove test-crypto-keygen flaky designation"
38d06bf
nodejs/node#48652
jkleinsc pushed a commit to electron/electron that referenced this pull request Sep 20, 2023
@electron-roller @codebytere
chore: bump node to v18.18.0 (main) (#39915)
1766511
* chore: bump node in DEPS to v18.18.0

* child_process: harden against prototype pollution

nodejs/node#48726

* deps: upgrade to libuv 1.46.0

nodejs/node#49591

* module: reduce url invocations in esm/load.js

nodejs/node#48337

* Revert "test: remove test-crypto-keygen flaky designation"

nodejs/node#48652

* fix: FTBTFS in ada dep

ada-url/ada#464
ada-url/idna#31

* fix: force_colors snapshot line number

* chore: fixup patch indices

* chore: update filenames.json

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@electron-roller @codebytere MrHuangJser
chore: bump node to v18.18.0 (main) (electron#39915)
a848ba1
* chore: bump node in DEPS to v18.18.0

* child_process: harden against prototype pollution

nodejs/node#48726

* deps: upgrade to libuv 1.46.0

nodejs/node#49591

* module: reduce url invocations in esm/load.js

nodejs/node#48337

* Revert "test: remove test-crypto-keygen flaky designation"

nodejs/node#48652

* fix: FTBTFS in ada dep

ada-url/ada#464
ada-url/idna#31

* fix: force_colors snapshot line number

* chore: fixup patch indices

* chore: update filenames.json

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes
@KhafraDev KhafraDev KhafraDev approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@lpinca @nodejs-github-bot @richardlau @StefanStojanovic @KhafraDev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.