GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — Revert "test: remove test-crypto-keygen flaky designation" by lpinca · Pull Request #48652 · nodejs/node Conversation
|
|
Fast-track has been requested by @lpinca. Please 👍 to approve. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Commit Queue failed- Loading data for nodejs/node/pull/48652 ✔ Done loading data for nodejs/node/pull/48652 ----------------------------------- PR info ------------------------------------ Title Revert "test: remove test-crypto-keygen flaky designation" (#48652) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch lpinca:revert/893c000 -> nodejs:main Labels test, fast-track, needs-ci Commits 1 - Revert "test: remove test-crypto-keygen flaky designation" Committers 1 - Luigi Pinca PR-URL: https://github.com/nodejs/node/pull/48652 Reviewed-By: Richard Lau Reviewed-By: Matthew Aitken ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48652 Reviewed-By: Richard Lau Reviewed-By: Matthew Aitken -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 04 Jul 2023 13:42:24 GMT ✔ Approvals: 2 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/48652#pullrequestreview-1512977268 ✔ - Matthew Aitken (@KhafraDev): https://github.com/nodejs/node/pull/48652#pullrequestreview-1514888857 ℹ This PR is being fast-tracked ✘ This PR needs to wait 21 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-07-04T19:25:03Z: https://ci.nodejs.org/job/node-test-pull-request/52604/ - Querying data for job/node-test-pull-request/52604/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5466566342 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Landed in 08638b7 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
This reverts commit 893c000. Refs: #48575 (comment) PR-URL: #48652 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
This reverts commit 893c000. Refs: nodejs#48575 (comment) PR-URL: nodejs#48652 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
This reverts commit 893c000. Refs: nodejs#48575 (comment) PR-URL: nodejs#48652 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
This reverts commit 893c000. Refs: #48575 (comment) PR-URL: #48652 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
This reverts commit 893c000. Refs: #48575 (comment) PR-URL: #48652 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
This reverts commit 893c000. Refs: #48575 (comment) PR-URL: #48652 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
* chore: bump node in DEPS to v18.18.0 * child_process: harden against prototype pollution nodejs/node#48726 * deps: upgrade to libuv 1.46.0 nodejs/node#49591 * module: reduce url invocations in esm/load.js nodejs/node#48337 * Revert "test: remove test-crypto-keygen flaky designation" nodejs/node#48652 * fix: FTBTFS in ada dep ada-url/ada#464 ada-url/idna#31 * fix: force_colors snapshot line number * chore: fixup patch indices * chore: update filenames.json --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
* chore: bump node in DEPS to v18.18.0 * child_process: harden against prototype pollution nodejs/node#48726 * deps: upgrade to libuv 1.46.0 nodejs/node#49591 * module: reduce url invocations in esm/load.js nodejs/node#48337 * Revert "test: remove test-crypto-keygen flaky designation" nodejs/node#48652 * fix: FTBTFS in ada dep ada-url/ada#464 ada-url/idna#31 * fix: force_colors snapshot line number * chore: fixup patch indices * chore: update filenames.json --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.