GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v18.x] test: mark test-child-process-stdio-reuse-readable-stdio flaky by juanarbol · Pull Request #48601 · nodejs/node

Conversation

@juanarbol

@juanarbol juanarbol commented Jun 29, 2023

Copy link
Copy Markdown
Member

As mentioned #48345 (comment), this PR includes the current v18.x release line blockers to get any PR landed there. I hope this fixes the problems :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
MoLow and others added 2 commits June 29, 2023 09:56
@MoLow @juanarbol
test: mark test-child-process-pipe-dataflow as flaky
137f1cd 
PR-URL: nodejs#48334
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@lpinca @juanarbol
test: mark test-child-process-stdio-reuse-readable-stdio flaky
5daa07a 
Refs: nodejs#48300 (comment)
Refs: nodejs/reliability#597 (comment)
PR-URL: nodejs#48537
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. v18.x labels Jun 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Jun 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52561/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson
mhdawson approved these changes Jun 29, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
anonrig
anonrig approved these changes Jun 29, 2023
View reviewed changes
StefanStojanovic
StefanStojanovic approved these changes Jun 29, 2023
View reviewed changes
lpinca
lpinca approved these changes Jul 1, 2023
View reviewed changes
@juanarbol juanarbol added the commit-queue PRs queued for automated landing through the Commit Queue. label Jul 1, 2023
@StefanStojanovic StefanStojanovic mentioned this pull request Jul 4, 2023
[v16.x] test: mark flaky parallel tests #48650
Closed
@juanarbol

juanarbol commented Jul 4, 2023

Copy link
Copy Markdown
Member Author

Landed in fb90b6b...2edd0fd
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol juanarbol closed this Jul 4, 2023
@juanarbol
juanarbol deleted the v18.x-staging-flaky-tests branch December 6, 2023 03:27
@panva panva removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@juanarbol @nodejs-github-bot @lpinca @anonrig @mhdawson @StefanStojanovic @panva @MoLow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.