GeezerVison

Copy link

Copy Markdown

Member

bricss reacted with thumbs up emoji

rluvaton marked this pull request as ready for review July 25, 2023 09:44

rluvaton commented Jul 25, 2023

View reviewed changes

rluvaton commented Jul 25, 2023

View reviewed changes

MoLow reviewed Jul 25, 2023

View reviewed changes

rluvaton commented Jul 25, 2023

View reviewed changes

MoLow reviewed Jul 25, 2023

View reviewed changes

MoLow reviewed Jul 25, 2023

View reviewed changes

atlowChemi reviewed Jul 25, 2023

View reviewed changes

atlowChemi reviewed Jul 25, 2023

View reviewed changes

ljharb reviewed Jul 25, 2023

View reviewed changes

MoLow approved these changes Jul 25, 2023

View reviewed changes

MoLow requested a review from benjamingr July 25, 2023 18:56

atlowChemi reviewed Jul 26, 2023

View reviewed changes

benjamingr requested changes Jul 26, 2023

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

const { aborted } = require('internal/abort_controller');

function stopTest(timeout, signal) {
  return aborted(signal, {});
}

const { beforeEach, afterEach, test} = require("node:test");
beforeEach(() => {
  global.gc();
});
afterEach(() => {
  global.gc();
});

for (let i = 1; i <= 11; ++i) {
  test(`${i}`, () => {
  global.gc();
  });
}

(node:60047) MaxListenersExceededWarning: Possible EventTarget memory leak detected. 11 abort listeners added to [AbortSignal]. Use events.setMaxListeners() to increase limit
    at [kNewListener] (node:internal/event_target:542:17)
    at [kNewListener] (node:internal/abort_controller:239:24)
    at EventTarget.addEventListener (node:internal/event_target:655:23)
    at node:internal/test_runner/test:85:12
    at new Promise (<anonymous>)
    at stopTest (node:internal/test_runner/test:84:10)
    at TestHook.run (node:internal/test_runner/test:563:21)
    at TestHook.run (node:internal/test_runner/test:772:18)
    at node:internal/test_runner/test:519:20
    at async Test.runHook (node:internal/test_runner/test:517:7)

function stopTest(timeout, signal) {
  return new Promise((resolve) => {
    signal.addEventListener('abort', resolve, { [kWeakHandler]: {} });
    setImmediate(() => {
      global.gc()
    }).unref()
  });
}

benjamingr approved these changes Jul 29, 2023

View reviewed changes

fix nodejs#48475

PR-URL: nodejs#48915
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>

no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>

fix #48475

PR-URL: #48915
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>

no longer needed after #48915 fix

PR-URL: #48989
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>

There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: nodejs#48915

There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: #48915
PR-URL: #49943
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>

There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: #48915
PR-URL: #49943
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>

fix #48475

PR-URL: #48915
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>

no longer needed after #48915 fix

PR-URL: #48989
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>

There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: #48915
PR-URL: #49943
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>

There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: nodejs#48915
PR-URL: nodejs#49943
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>

fix #48475

PR-URL: nodejs/node#48915
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>

There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: nodejs/node#48915
PR-URL: nodejs/node#49943
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>

fix #48475

PR-URL: nodejs/node#48915
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>

There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: nodejs/node#48915
PR-URL: nodejs/node#49943
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>