GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: remove `--no-warnings` flag in `test_runner` fixtures by rluvaton · Pull Request #48989 · nodejs/node

Conversation

@rluvaton

@rluvaton rluvaton commented Aug 1, 2023

Copy link
Copy Markdown
Member

no longer needed after #48915 fix

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@rluvaton
test: remove --no-warnings flag in test_runner fixtures
b6e5fc6 
no longer needed after nodejs#48915 fix
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 1, 2023
MoLow
MoLow approved these changes Aug 2, 2023
View reviewed changes

@MoLow MoLow left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 2, 2023
atlowChemi
atlowChemi approved these changes Aug 2, 2023
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53038/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rluvaton

rluvaton commented Aug 2, 2023

Copy link
Copy Markdown
Member Author

Seems unrelated can you please retry?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53051/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Aug 3, 2023
CI Reliability 2023-08-03 nodejs/reliability#632
Open
29 tasks
@nodejs-github-bot

nodejs-github-bot commented Aug 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53056/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 3, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 3, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 1353681 into nodejs:main Aug 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 3, 2023

Copy link
Copy Markdown
Collaborator

Landed in 1353681
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Aug 4, 2023
CI Reliability 2023-08-04 nodejs/reliability#633
Open
25 tasks
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@rluvaton @Ceres6
test: remove --no-warnings flag in test_runner fixtures
caed781 
no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@rluvaton @Ceres6
test: remove --no-warnings flag in test_runner fixtures
a757158 
no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@rluvaton @UlisesGascon
test: remove --no-warnings flag in test_runner fixtures
d968618 
no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@rluvaton @RafaelGSS
test: remove --no-warnings flag in test_runner fixtures
be56e23 
no longer needed after #48915 fix

PR-URL: #48989
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
v20.6.0 proposal #49185
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@rluvaton @RafaelGSS
test: remove --no-warnings flag in test_runner fixtures
9e0d82a 
no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@RafaelGSS RafaelGSS added the backport-requested-v20.x label Aug 17, 2023
@RafaelGSS

RafaelGSS commented Aug 17, 2023

Copy link
Copy Markdown
Member

Due to fact, #48877 didn't land cleanly on v20.x-staging. This PR somehow, depends on it. So we'll need a manual backport.

Reference: https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rluvaton
rluvaton deleted the remove-no-warning-in-test-output branch August 17, 2023 22:25
@rluvaton rluvaton mentioned this pull request Aug 18, 2023
[v20.x backport] backport multiple test runner related prs #49225
Closed
@rluvaton rluvaton added backport-open-v20.x and removed backport-requested-v20.x labels Aug 18, 2023
@rluvaton

rluvaton commented Aug 18, 2023

Copy link
Copy Markdown
Member Author

Backport PR:

  • [v20.x backport] backport multiple test runner related prs #49225
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rluvaton added a commit to rluvaton/node that referenced this pull request Sep 4, 2023
@rluvaton
test: remove --no-warnings flag in test_runner fixtures
dbc3124 
no longer needed after nodejs#48915 fix

PR-URL: nodejs#48989
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@rluvaton @UlisesGascon
test: remove --no-warnings flag in test_runner fixtures
4d184b5 
no longer needed after #48915 fix

PR-URL: #48989
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
v20.7.0 proposal #49592
Merged
@targos targos added backported-to-v20.x and removed backport-open-v20.x labels Nov 12, 2023
targos pushed a commit that referenced this pull request Nov 27, 2023
@rluvaton @targos
test: remove --no-warnings flag in test_runner fixtures
7e714e6 
no longer needed after #48915 fix

PR-URL: #48989
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: remove --no-warnings flag in test_runner fixtures
1b442df 
no longer needed after #48915 fix

PR-URL: nodejs/node#48989
Backport-PR-URL: nodejs/node#49225
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: remove --no-warnings flag in test_runner fixtures
b52c472 
no longer needed after #48915 fix

PR-URL: nodejs/node#48989
Backport-PR-URL: nodejs/node#49225
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLow MoLow MoLow approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@rluvaton @nodejs-github-bot @RafaelGSS @MoLow @atlowChemi @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.