GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: fix typo `libray` -> `library` (configure.py) by michalbiesek · Pull Request #49106 · nodejs/node

Conversation

@michalbiesek

@michalbiesek michalbiesek commented Aug 11, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Aug 11, 2023
richardlau
richardlau approved these changes Aug 11, 2023
View reviewed changes
@michalbiesek
build: fix typo libray -> library (configure.py)
4ea89c7 
Signed-off-by: Michal Biesek <[email protected]>
@michalbiesek
michalbiesek force-pushed the build-fix-typo branch from 6b2d04c to 4ea89c7 Compare August 11, 2023 12:06
@deokjinkim deokjinkim changed the title build: Fix typo libray -> library (configure.py) build: fix typo libray -> library (configure.py) Aug 11, 2023
deokjinkim
deokjinkim approved these changes Aug 11, 2023
View reviewed changes
@richardlau richardlau added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 11, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 11, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53194/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau

richardlau commented Aug 11, 2023

Copy link
Copy Markdown
Member

Test failure is #49059 (comment), being fixed (🤞) by a revert #49110.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Aug 11, 2023
View reviewed changes
lpinca
lpinca approved these changes Aug 11, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Aug 13, 2023
CI Reliability 2023-08-13 nodejs/reliability#635
Open
29 tasks
@nodejs-github-bot

nodejs-github-bot commented Aug 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53299/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Aug 15, 2023
CI Reliability 2023-08-15 nodejs/reliability#637
Open
22 tasks
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53337/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53338/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 15, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 15, 2023
@nodejs-github-bot
nodejs-github-bot merged commit b3eb05b into nodejs:main Aug 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2023

Copy link
Copy Markdown
Collaborator

Landed in b3eb05b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@michalbiesek
michalbiesek deleted the build-fix-typo branch August 15, 2023 21:01
This was referenced Aug 16, 2023
CI Reliability 2023-08-16 nodejs/reliability#638
Open
CI Reliability 2023-08-17 nodejs/reliability#639
Open
CI Reliability 2023-08-18 nodejs/reliability#640
Open
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@michalbiesek @UlisesGascon
build: fix typo libray -> library (configure.py)
f637fd4 
Signed-off-by: Michal Biesek <[email protected]>
PR-URL: #49106
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
v20.7.0 proposal #49592
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@michalbiesek @targos
build: fix typo libray -> library (configure.py)
a781d24 
Signed-off-by: Michal Biesek <[email protected]>
PR-URL: #49106
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
build: fix typo libray -> library (configure.py)
482aee9 
Signed-off-by: Michal Biesek <[email protected]>
PR-URL: nodejs/node#49106
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
build: fix typo libray -> library (configure.py)
fc5b695 
Signed-off-by: Michal Biesek <[email protected]>
PR-URL: nodejs/node#49106
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@deokjinkim deokjinkim deokjinkim approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@michalbiesek @nodejs-github-bot @richardlau @benjamingr @lpinca @deokjinkim
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.