GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "test_runner: run global after() hook earlier" by joyeecheung · Pull Request #49110 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Aug 11, 2023

Copy link
Copy Markdown
Member

This reverts commit 6346bdc.

Reason for revert: breaking CI

See https://ci.nodejs.org/job/node-test-pull-request/53201/ and https://ci.nodejs.org/job/node-test-pull-request/53200/ where test-runner-output.mjs failed everywhere, though the changes are unrelated. This test also fails for me locally consistently unless I revert #49059

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joyeecheung
Revert "test_runner: run global after() hook earlier"
b603fb6 
This reverts commit 6346bdc.

Reason for revert: breaking CI
@nodejs-github-bot

nodejs-github-bot commented Aug 11, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung joyeecheung added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Aug 11, 2023
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Aug 11, 2023
@github-actions

github-actions Bot commented Aug 11, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @joyeecheung. Please 👍 to approve.
cjihrig, GeoffreyBooth, anonrig, LiviaMedeiros, debadree25, benjamingr, and bricss reacted with thumbs up emoji
All reactions
  • 👍 7 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Aug 11, 2023
View reviewed changes
anonrig
anonrig approved these changes Aug 11, 2023
View reviewed changes
@joyeecheung joyeecheung added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 11, 2023
@richardlau richardlau mentioned this pull request Aug 11, 2023
build: fix typo libray -> library (configure.py) #49106
Merged
LiviaMedeiros
LiviaMedeiros approved these changes Aug 11, 2023
View reviewed changes
debadree25
debadree25 approved these changes Aug 11, 2023
View reviewed changes
benjamingr
benjamingr approved these changes Aug 11, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 11, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 11, 2023
@nodejs-github-bot

ghost commented Aug 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53206/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Aug 11, 2023
View reviewed changes
@anonrig anonrig mentioned this pull request Aug 11, 2023
src: add built-in .env file support #48890
Merged
6 of 11 tasks
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 11, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 12, 2023
@nodejs-github-bot

ghost commented Aug 12, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49110
✔  Done loading data for nodejs/node/pull/49110
----------------------------------- PR info ------------------------------------
Title      Revert "test_runner: run global after() hook earlier" (#49110)
Author     Joyee Cheung  (@joyeecheung)
Branch     joyeecheung:revert-49059 -> nodejs:main
Labels     fast-track, author ready, needs-ci, test_runner
Commits    1
 - Revert "test_runner: run global after() hook earlier"
Committers 1
 - Joyee Cheung 
PR-URL: https://github.com/nodejs/node/pull/49110
Reviewed-By: Colin Ihrig 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: LiviaMedeiros 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49110
Reviewed-By: Colin Ihrig 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: LiviaMedeiros 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 11 Aug 2023 16:53:34 GMT
   ✔  Approvals: 6
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/49110#pullrequestreview-1574075155
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49110#pullrequestreview-1574080138
   ✔  - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/49110#pullrequestreview-1574115646
   ✔  - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/49110#pullrequestreview-1574118355
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49110#pullrequestreview-1574121762
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49110#pullrequestreview-1574230036
   ℹ  This PR is being fast-tracked
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-08-11T17:55:23Z: https://ci.nodejs.org/job/node-test-pull-request/53206/
- Querying data for job/node-test-pull-request/53206/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5838544157
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth GeoffreyBooth added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Aug 12, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 12, 2023
@nodejs-github-bot
nodejs-github-bot merged commit bb52656 into nodejs:main Aug 12, 2023
@nodejs-github-bot

ghost commented Aug 12, 2023

Copy link
Copy Markdown
Collaborator

Landed in bb52656
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig cjihrig mentioned this pull request Aug 12, 2023
test_runner: reland run global after() hook earlier #49116
Merged
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
v20.6.0 proposal #49185
Merged
@joyeecheung joyeecheung mentioned this pull request Aug 15, 2023
bootstrap: do not generate code cache in an unfinalized isolate #49108
Merged
@aduh95 aduh95 added dont-land-on-v16.x labels Aug 16, 2023
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@cjihrig cjihrig cjihrig approved these changes
@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes
+1 more reviewer
@debadree25 debadree25 debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@joyeecheung @nodejs-github-bot @benjamingr @lpinca @anonrig @cjihrig @debadree25 @LiviaMedeiros @GeoffreyBooth @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.