GeezerVison

- Loading data for nodejs/node/pull/49793
✔  Done loading data for nodejs/node/pull/49793
----------------------------------- PR info ------------------------------------
Title      test: replace foreach with for in test-https-simple.js (#49793)
Author     Shikha Mehta  (@Shikha2410, first-time contributor)
Branch     Shikha2410:replace-foreach -> nodejs:main
Labels     test, code-and-learn, author ready, needs-ci
Commits    1
 - test: replace foreach with for in test-https-simple.js
Committers 1
 - Shikha Mehta 
PR-URL: https://github.com/nodejs/node/pull/49793
Fixes: https://docs.google.com/spreadsheets/d/1kjaxxXX2zGgJUoqj-7U3EYf_0dvSuI-N6YPan4Hye_4/edit#gid=0&range=100:100
Reviewed-By: Tobias Nießen 
Reviewed-By: Jithil P Ponnan 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49793
Fixes: https://docs.google.com/spreadsheets/d/1kjaxxXX2zGgJUoqj-7U3EYf_0dvSuI-N6YPan4Hye_4/edit#gid=0&range=100:100
Reviewed-By: Tobias Nießen 
Reviewed-By: Jithil P Ponnan 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 22 Sep 2023 22:40:08 GMT
   ✔  Approvals: 2
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49793#pullrequestreview-1739958150
   ✔  - Jithil P Ponnan (@MrJithil): https://github.com/nodejs/node/pull/49793#pullrequestreview-1741332180
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-11-21T13:00:20Z: https://ci.nodejs.org/job/node-test-pull-request/55823/
- Querying data for job/node-test-pull-request/55823/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 49793
From https://github.com/nodejs/node
 * branch                  refs/pull/49793/merge -> FETCH_HEAD
✔  Fetched commits as 1858341377c2..cc7938d71ac5
--------------------------------------------------------------------------------
[main 95eeeaaf91] test: replace foreach with for in test-https-simple.js
 Author: Shikha Mehta 
 Date: Fri Sep 22 15:22:18 2023 -0700
 1 file changed, 2 insertions(+), 2 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
test: replace foreach with for in test-https-simple.js
Fixes: #50818

PR-URL: #49793

Fixes: https://docs.google.com/spreadsheets/d/1kjaxxXX2zGgJUoqj-7U3EYf_0dvSuI-N6YPan4Hye_4/edit#gid=0&range=100:100

Reviewed-By: Tobias Nießen [email protected]

Reviewed-By: Jithil P Ponnan [email protected]
[main 23d682ade1] test: replace foreach with for in test-https-simple.js

Author: Shikha Mehta [email protected]

Date: Fri Sep 22 15:22:18 2023 -0700

1 file changed, 2 insertions(+), 2 deletions(-)

✖  23d682ade1e7b5fc3f4744013eb8c2e971ed2053

✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer

✔  1:7      Valid fixes URL.                          fixes-url

✖  3:7      Fixes must be a GitHub URL.               fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  2:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

⚠  0:50     Title should be <= 50 columns.            title-length
ℹ  Please fix the commit message and try again.

Please manually ammend the commit message, by running

git commit --amend

Once commit message is fixed, finish the landing command running

git node land --continue