GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update doc to [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] by nodejs-github-bot · Pull Request #49988 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Oct 1, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

This is an automated update of doc to [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected].

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2023

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/web-infra
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Oct 1, 2023
@lpinca
lpinca force-pushed the actions/tools-update-doc branch from bcca2e8 to af4b2d9 Compare October 1, 2023 05:38
MoLow
MoLow approved these changes Oct 1, 2023
View reviewed changes
lpinca
lpinca approved these changes Oct 1, 2023
View reviewed changes
@lpinca

lpinca commented Oct 3, 2023

Copy link
Copy Markdown
Member

I'm not sure why the coverage job fails. Can we ignore it?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lpinca
lpinca force-pushed the actions/tools-update-doc branch from af4b2d9 to 7710af5 Compare October 6, 2023 17:13
@nodejs-github-bot nodejs-github-bot changed the title tools: update doc to [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] tools: update doc to [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] Oct 15, 2023
@aduh95
aduh95 force-pushed the actions/tools-update-doc branch from 6d492c8 to 269c8b8 Compare October 23, 2023 17:09
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Oct 23, 2023
mhdawson
mhdawson approved these changes Oct 24, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
nodejs-github-bot added 3 commits October 26, 2023 11:14
@nodejs-github-bot @aduh95
tools: update doc dependencies
ba3fa67
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
@nodejs-github-bot @aduh95
tools: update doc to [email protected] [email protected] rem…
a175c8d
…[email protected] [email protected] [email protected] [email protected] [email protected]
@nodejs-github-bot @aduh95
tools: update doc to [email protected] [email protected] rem…
bcad579
…[email protected] [email protected] [email protected] [email protected] [email protected]
@aduh95
aduh95 force-pushed the actions/tools-update-doc branch from 269c8b8 to bcad579 Compare October 26, 2023 09:14
aduh95
aduh95 approved these changes Oct 26, 2023
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 26, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 6431c65 into main Oct 26, 2023
@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-doc branch October 26, 2023 12:42
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2023

Copy link
Copy Markdown
Collaborator Author

Landed in 6431c65

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@richardlau

richardlau commented Oct 26, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I think this has broken the without-intl build:
https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutintl_x64/40113/console

17:31:46 npm WARN cli npm v10.2.0 does not support Node.js v22.0.0-pre. This version of npm supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the latest version at https://nodejs.org/.
17:31:47 
17:31:47 added 109 packages, and audited 110 packages in 1s
17:31:47 
17:31:47 94 packages are looking for funding
17:31:47   run `npm fund` for details
17:31:47 
17:31:47 found 0 vulnerabilities
17:31:47 file:///home/iojs/build/workspace/node-test-commit-linux-containered/tools/doc/node_modules/micromark-util-character/index.js:5
17:31:47 const unicodePunctuationInternal = regexCheck(/\p{P}/u)
17:31:47                                               ^^^^^^^^
17:31:47 
17:31:47 SyntaxError: Invalid regular expression: /\p{P}/u: Invalid property name
17:31:47     at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:155:18)
17:31:47     at callTranslator (node:internal/modules/esm/loader:285:14)
17:31:47     at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:291:30)
17:31:47 
17:31:47 Node.js v22.0.0-pre
17:31:47 /bin/sh: 5: node: not found
17:31:47 Makefile:374: recipe for target 'test/addons/.docbuildstamp' failed

Opened a revert: #50414

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@richardlau richardlau mentioned this pull request Oct 26, 2023
Revert "tools: update doc dependencies" #50414
Merged
@aduh95 aduh95 mentioned this pull request Oct 26, 2023
micromark-util-character: fix crash on some Node.js versions micromark/micromark#157
Closed
5 tasks done
This was referenced Oct 26, 2023
tools: add needs-ci label to tools/doc #50416
Closed
test: fix crypto-dh error message for OpenSSL 3.x #50395
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@nodejs-github-bot @targos
tools: update doc dependencies
90c9dd3
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]

PR-URL: #49988
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@nodejs-github-bot @UlisesGascon
tools: update doc dependencies
8fd67c2
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]

PR-URL: #49988
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
@aduh95 aduh95 mentioned this pull request Dec 17, 2023
tools: update doc to new version #51192
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@MoLow MoLow MoLow approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@nodejs-github-bot @lpinca @richardlau @MoLow @mhdawson @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.