GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — tools: change minimatch install strategy by marco-ippolito · Pull Request #50476 · nodejs/node

Conversation

marco-ippolito commented Oct 30, 2023

Copy link

Copy Markdown

Member

Refs: nodejs/security-wg#1037
It makes build process repeatable and keeps track of package lock

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mertcanaltin reacted with hooray emoji

mertcanaltin reacted with rocket emoji

All reactions

🎉 1 reaction
🚀 1 reaction

nodejs-github-bot added dependencies

PRs that add, update, or configure Node.js dependencies.

needs-ci PRs that need a full CI run. labels

Oct 30, 2023


          tools: change minimatch install strategy

8f1b37d

marco-ippolito force-pushed the feat/minimatch-update branch from 61edd35 to 8f1b37d Compare

October 30, 2023 15:19


          fix: header broke everything

d57fcda

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 31, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 31, 2023

nodejs-github-bot commented Oct 31, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55343/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MoLow reviewed

Oct 31, 2023

View reviewed changes

Comment thread

tools/dep_updaters/update-minimatch.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.

fix

2080d72

marco-ippolito added commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels

Oct 31, 2023

marco-ippolito closed this

Nov 6, 2023

marco-ippolito reopened this

Nov 6, 2023

nodejs-github-bot commented Nov 7, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55474/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Nov 8, 2023

CI Reliability 2023-11-08 nodejs/reliability#711

Open

CI Reliability 2023-11-09 nodejs/reliability#712

Open

CI Reliability 2023-11-10 nodejs/reliability#713

Open

CI Reliability 2023-11-11 nodejs/reliability#714

Open

nodejs-github-bot commented Nov 11, 2023 •

edited by jasnell

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55577/ 💛

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 12, 2023

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Nov 12, 2023

nodejs-github-bot commented Nov 12, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/50476
✔  Done loading data for nodejs/node/pull/50476
----------------------------------- PR info ------------------------------------
Title      tools: change minimatch install strategy (#50476)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:feat/minimatch-update -> nodejs:main
Labels     needs-ci, dependencies
Commits    3
 - tools: change minimatch install strategy
 - fix: header broke everything
 - fix
Committers 1
 - Marco Ippolito 
PR-URL: https://github.com/nodejs/node/pull/50476
Refs: https://github.com/nodejs/security-wg/issues/1037
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50476
Refs: https://github.com/nodejs/security-wg/issues/1037
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 30 Oct 2023 15:10:36 GMT
   ✘  Approvals: 0
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-11-11T19:17:40Z: https://ci.nodejs.org/job/node-test-pull-request/55577/
- Querying data for job/node-test-pull-request/55577/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6840374876

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell approved these changes

Nov 12, 2023

View reviewed changes

jasnell added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Nov 12, 2023

nodejs-github-bot commented Nov 12, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/50476
✔  Done loading data for nodejs/node/pull/50476
----------------------------------- PR info ------------------------------------
Title      tools: change minimatch install strategy (#50476)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:feat/minimatch-update -> nodejs:main
Labels     needs-ci, dependencies
Commits    3
 - tools: change minimatch install strategy
 - fix: header broke everything
 - fix
Committers 1
 - Marco Ippolito 
PR-URL: https://github.com/nodejs/node/pull/50476
Refs: https://github.com/nodejs/security-wg/issues/1037
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50476
Refs: https://github.com/nodejs/security-wg/issues/1037
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 30 Oct 2023 15:10:36 GMT
   ✔  Approvals: 1
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50476#pullrequestreview-1726228816
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-11-12T11:24:44Z: https://ci.nodejs.org/job/node-test-pull-request/55577/
- Querying data for job/node-test-pull-request/55577/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 50476
From https://github.com/nodejs/node
 * branch                  refs/pull/50476/merge -> FETCH_HEAD
✔  Fetched commits as 242cbd7d1a92..2080d72dc2bb
--------------------------------------------------------------------------------
[main 9227968bab] tools: change minimatch install strategy
 Author: Marco Ippolito 
 Date: Mon Oct 30 14:39:43 2023 +0200
 64 files changed, 6272 insertions(+), 670 deletions(-)
 rename deps/minimatch/{src => }/README.md (100%)
 rename deps/minimatch/{src => }/dist/cjs/assert-valid-pattern.d.ts (100%)
 rename deps/minimatch/{src => }/dist/cjs/assert-valid-pattern.d.ts.map (100%)
 rename deps/minimatch/{src => }/dist/cjs/assert-valid-pattern.js (100%)
 rename deps/minimatch/{src => }/dist/cjs/assert-valid-pattern.js.map (100%)
 rename deps/minimatch/{src => }/dist/cjs/ast.d.ts (100%)
 rename deps/minimatch/{src => }/dist/cjs/ast.d.ts.map (100%)
 rename deps/minimatch/{src => }/dist/cjs/ast.js (100%)
 rename deps/minimatch/{src => }/dist/cjs/ast.js.map (100%)
 rename deps/minimatch/{src => }/dist/cjs/brace-expressions.d.ts (100%)
 rename deps/minimatch/{src => }/dist/cjs/brace-expressions.d.ts.map (100%)
 rename deps/minimatch/{src => }/dist/cjs/brace-expressions.js (100%)
 rename deps/minimatch/{src => }/dist/cjs/brace-expressions.js.map (100%)
 rename deps/minimatch/{src => }/dist/cjs/escape.d.ts (100%)
 rename deps/minimatch/{src => }/dist/cjs/escape.d.ts.map (100%)
 rename deps/minimatch/{src => }/dist/cjs/escape.js (100%)
 rename deps/minimatch/{src => }/dist/cjs/escape.js.map (100%)
 rename deps/minimatch/{src => }/dist/cjs/index.d.ts (100%)
 rename deps/minimatch/{src => }/dist/cjs/index.d.ts.map (100%)
 rename deps/minimatch/{src => }/dist/cjs/index.js (100%)
 rename deps/minimatch/{src => }/dist/cjs/index.js.map (100%)
 rename deps/minimatch/{src => }/dist/cjs/package.json (100%)
 rename deps/minimatch/{src => }/dist/cjs/unescape.d.ts (100%)
 rename deps/minimatch/{src => }/dist/cjs/unescape.d.ts.map (100%)
 rename deps/minimatch/{src => }/dist/cjs/unescape.js (100%)
 rename deps/minimatch/{src => }/dist/cjs/unescape.js.map (100%)
 rename deps/minimatch/{src => }/dist/mjs/assert-valid-pattern.d.ts (100%)
 rename deps/minimatch/{src => }/dist/mjs/assert-valid-pattern.d.ts.map (100%)
 rename deps/minimatch/{src => }/dist/mjs/assert-valid-pattern.js (100%)
 rename deps/minimatch/{src => }/dist/mjs/assert-valid-pattern.js.map (100%)
 rename deps/minimatch/{src => }/dist/mjs/ast.d.ts (100%)
 rename deps/minimatch/{src => }/dist/mjs/ast.d.ts.map (100%)
 rename deps/minimatch/{src => }/dist/mjs/ast.js (100%)
 rename deps/minimatch/{src => }/dist/mjs/ast.js.map (100%)
 rename deps/minimatch/{src => }/dist/mjs/brace-expressions.d.ts (100%)
 rename deps/minimatch/{src => }/dist/mjs/brace-expressions.d.ts.map (100%)
 rename deps/minimatch/{src => }/dist/mjs/brace-expressions.js (100%)
 rename deps/minimatch/{src => }/dist/mjs/brace-expressions.js.map (100%)
 rename deps/minimatch/{src => }/dist/mjs/escape.d.ts (100%)
 rename deps/minimatch/{src => }/dist/mjs/escape.d.ts.map (100%)
 rename deps/minimatch/{src => }/dist/mjs/escape.js (100%)
 rename deps/minimatch/{src => }/dist/mjs/escape.js.map (100%)
 rename deps/minimatch/{src => }/dist/mjs/index.d.ts (100%)
 rename deps/minimatch/{src => }/dist/mjs/index.d.ts.map (100%)
 rename deps/minimatch/{src => }/dist/mjs/index.js (100%)
 rename deps/minimatch/{src => }/dist/mjs/index.js.map (100%)
 rename deps/minimatch/{src => }/dist/mjs/package.json (100%)
 rename deps/minimatch/{src => }/dist/mjs/unescape.d.ts (100%)
 rename deps/minimatch/{src => }/dist/mjs/unescape.d.ts.map (100%)
 rename deps/minimatch/{src => }/dist/mjs/unescape.js (100%)
 rename deps/minimatch/{src => }/dist/mjs/unescape.js.map (100%)
 create mode 100644 deps/minimatch/package-lock.json
 rename deps/minimatch/{src => }/package.json (94%)
 delete mode 100644 deps/minimatch/src/LICENSE
 delete mode 100644 deps/minimatch/src/node_modules/balanced-match/LICENSE.md
 delete mode 100644 deps/minimatch/src/node_modules/balanced-match/README.md
 delete mode 100644 deps/minimatch/src/node_modules/balanced-match/index.js
 delete mode 100644 deps/minimatch/src/node_modules/balanced-match/package.json
 delete mode 100644 deps/minimatch/src/node_modules/brace-expansion/LICENSE
 delete mode 100644 deps/minimatch/src/node_modules/brace-expansion/README.md
 delete mode 100644 deps/minimatch/src/node_modules/brace-expansion/index.js
 delete mode 100644 deps/minimatch/src/node_modules/brace-expansion/package.json
[main 88b29a0fc1] fix: header broke everything
 Author: Marco Ippolito 
 Date: Mon Oct 30 17:42:00 2023 +0200
 2 files changed, 6 deletions(-)
[main a252c8c9d0] fix
 Author: Marco Ippolito 
 Date: Tue Oct 31 11:13:55 2023 +0200
 1 file changed, 1 deletion(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

tools: change minimatch install strategy
PR-URL: #50476

Refs: nodejs/security-wg#1037

Reviewed-By: James M Snell [email protected]
[detached HEAD 5f7b8a9c69] tools: change minimatch install strategy

Author: Marco Ippolito [email protected]

Date: Mon Oct 30 14:39:43 2023 +0200

64 files changed, 6272 insertions(+), 670 deletions(-)

rename deps/minimatch/{src => }/README.md (100%)

rename deps/minimatch/{src => }/dist/cjs/assert-valid-pattern.d.ts (100%)

rename deps/minimatch/{src => }/dist/cjs/assert-valid-pattern.d.ts.map (100%)

rename deps/minimatch/{src => }/dist/cjs/assert-valid-pattern.js (100%)

rename deps/minimatch/{src => }/dist/cjs/assert-valid-pattern.js.map (100%)

rename deps/minimatch/{src => }/dist/cjs/ast.d.ts (100%)

rename deps/minimatch/{src => }/dist/cjs/ast.d.ts.map (100%)

rename deps/minimatch/{src => }/dist/cjs/ast.js (100%)

rename deps/minimatch/{src => }/dist/cjs/ast.js.map (100%)

rename deps/minimatch/{src => }/dist/cjs/brace-expressions.d.ts (100%)

rename deps/minimatch/{src => }/dist/cjs/brace-expressions.d.ts.map (100%)

rename deps/minimatch/{src => }/dist/cjs/brace-expressions.js (100%)

rename deps/minimatch/{src => }/dist/cjs/brace-expressions.js.map (100%)

rename deps/minimatch/{src => }/dist/cjs/escape.d.ts (100%)

rename deps/minimatch/{src => }/dist/cjs/escape.d.ts.map (100%)

rename deps/minimatch/{src => }/dist/cjs/escape.js (100%)

rename deps/minimatch/{src => }/dist/cjs/escape.js.map (100%)

rename deps/minimatch/{src => }/dist/cjs/index.d.ts (100%)

rename deps/minimatch/{src => }/dist/cjs/index.d.ts.map (100%)

rename deps/minimatch/{src => }/dist/cjs/index.js (100%)

rename deps/minimatch/{src => }/dist/cjs/index.js.map (100%)

rename deps/minimatch/{src => }/dist/cjs/package.json (100%)

rename deps/minimatch/{src => }/dist/cjs/unescape.d.ts (100%)

rename deps/minimatch/{src => }/dist/cjs/unescape.d.ts.map (100%)

rename deps/minimatch/{src => }/dist/cjs/unescape.js (100%)

rename deps/minimatch/{src => }/dist/cjs/unescape.js.map (100%)

rename deps/minimatch/{src => }/dist/mjs/assert-valid-pattern.d.ts (100%)

rename deps/minimatch/{src => }/dist/mjs/assert-valid-pattern.d.ts.map (100%)

rename deps/minimatch/{src => }/dist/mjs/assert-valid-pattern.js (100%)

rename deps/minimatch/{src => }/dist/mjs/assert-valid-pattern.js.map (100%)

rename deps/minimatch/{src => }/dist/mjs/ast.d.ts (100%)

rename deps/minimatch/{src => }/dist/mjs/ast.d.ts.map (100%)

rename deps/minimatch/{src => }/dist/mjs/ast.js (100%)

rename deps/minimatch/{src => }/dist/mjs/ast.js.map (100%)

rename deps/minimatch/{src => }/dist/mjs/brace-expressions.d.ts (100%)

rename deps/minimatch/{src => }/dist/mjs/brace-expressions.d.ts.map (100%)

rename deps/minimatch/{src => }/dist/mjs/brace-expressions.js (100%)

rename deps/minimatch/{src => }/dist/mjs/brace-expressions.js.map (100%)

rename deps/minimatch/{src => }/dist/mjs/escape.d.ts (100%)

rename deps/minimatch/{src => }/dist/mjs/escape.d.ts.map (100%)

rename deps/minimatch/{src => }/dist/mjs/escape.js (100%)

rename deps/minimatch/{src => }/dist/mjs/escape.js.map (100%)

rename deps/minimatch/{src => }/dist/mjs/index.d.ts (100%)

rename deps/minimatch/{src => }/dist/mjs/index.d.ts.map (100%)

rename deps/minimatch/{src => }/dist/mjs/index.js (100%)

rename deps/minimatch/{src => }/dist/mjs/index.js.map (100%)

rename deps/minimatch/{src => }/dist/mjs/package.json (100%)

rename deps/minimatch/{src => }/dist/mjs/unescape.d.ts (100%)

rename deps/minimatch/{src => }/dist/mjs/unescape.d.ts.map (100%)

rename deps/minimatch/{src => }/dist/mjs/unescape.js (100%)

rename deps/minimatch/{src => }/dist/mjs/unescape.js.map (100%)

create mode 100644 deps/minimatch/package-lock.json

rename deps/minimatch/{src => }/package.json (94%)

delete mode 100644 deps/minimatch/src/LICENSE

delete mode 100644 deps/minimatch/src/node_modules/balanced-match/LICENSE.md

delete mode 100644 deps/minimatch/src/node_modules/balanced-match/README.md

delete mode 100644 deps/minimatch/src/node_modules/balanced-match/index.js

delete mode 100644 deps/minimatch/src/node_modules/balanced-match/package.json

delete mode 100644 deps/minimatch/src/node_modules/brace-expansion/LICENSE

delete mode 100644 deps/minimatch/src/node_modules/brace-expansion/README.md

delete mode 100644 deps/minimatch/src/node_modules/brace-expansion/index.js

delete mode 100644 deps/minimatch/src/node_modules/brace-expansion/package.json

Rebasing (3/6)

Rebasing (4/6)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fix: header broke everything
PR-URL: #50476

Refs: nodejs/security-wg#1037

Reviewed-By: James M Snell [email protected]
[detached HEAD 97de5f7430] fix: header broke everything

Author: Marco Ippolito [email protected]

Date: Mon Oct 30 17:42:00 2023 +0200

2 files changed, 6 deletions(-)

Rebasing (5/6)

Rebasing (6/6)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fix
PR-URL: #50476

Refs: nodejs/security-wg#1037

Reviewed-By: James M Snell [email protected]
[detached HEAD d048eb3cbe] fix

Author: Marco Ippolito [email protected]

Date: Tue Oct 31 11:13:55 2023 +0200

1 file changed, 1 deletion(-)
Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/6840406687

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito added commit-queue

PRs queued for automated landing through the Commit Queue.

commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Nov 13, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 13, 2023

nodejs-github-bot merged commit 0304da2 into nodejs:main

Nov 13, 2023

nodejs-github-bot commented Nov 13, 2023

Copy link

Copy Markdown

Collaborator

Landed in 0304da2

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request

Nov 23, 2023


          tools: change minimatch install strategy

c494838

PR-URL: #50476
Refs: nodejs/security-wg#1037
Reviewed-By: James M Snell <[email protected]>

RafaelGSS mentioned this pull request

Nov 28, 2023

v21.3.0 proposal #50954

Merged

UlisesGascon pushed a commit that referenced this pull request

Dec 11, 2023


          tools: change minimatch install strategy

8ce6403

PR-URL: #50476
Refs: nodejs/security-wg#1037
Reviewed-By: James M Snell <[email protected]>

UlisesGascon mentioned this pull request

Dec 12, 2023

v20.11.0 proposal #51124

Merged

Reviewers

MoLow

MoLow left review comments

jasnell

jasnell approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

dependencies

PRs that add, update, or configure Node.js dependencies.

needs-ci

PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

marco-ippolito commented Oct 30, 2023

Uh oh!

nodejs-github-bot commented Oct 31, 2023

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 7, 2023

Uh oh!

nodejs-github-bot commented Nov 11, 2023 • edited by jasnell Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 12, 2023

Uh oh!

nodejs-github-bot commented Nov 12, 2023

PR-URL: #50476 Refs: nodejs/security-wg#1037 Reviewed-By: James M Snell [email protected]

PR-URL: #50476 Refs: nodejs/security-wg#1037 Reviewed-By: James M Snell [email protected]

PR-URL: #50476 Refs: nodejs/security-wg#1037 Reviewed-By: James M Snell [email protected]

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Nov 13, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nodejs-github-bot commented Nov 11, 2023 •

edited by jasnell

Loading

Uh oh!

There was an error while loading. Please reload this page.

PR-URL: #50476
Refs: nodejs/security-wg#1037
Reviewed-By: James M Snell [email protected]

PR-URL: #50476
Refs: nodejs/security-wg#1037
Reviewed-By: James M Snell [email protected]

PR-URL: #50476
Refs: nodejs/security-wg#1037
Reviewed-By: James M Snell [email protected]