GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — doc: deprecation code for isWebAssemblyCompiledModule by marco-ippolito · Pull Request #50486 · nodejs/node

Conversation

marco-ippolito commented Oct 31, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

It was missing deprecation code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot added deprecations

Issues and PRs related to deprecations.

doc Issues and PRs related to Node.js documentation. labels

Oct 31, 2023

ShogunPanda approved these changes

Nov 1, 2023

View reviewed changes

jasnell approved these changes

Nov 11, 2023

View reviewed changes

jasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 11, 2023

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Nov 11, 2023

nodejs-github-bot commented Nov 11, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/50486 ✔ Done loading data for nodejs/node/pull/50486 ----------------------------------- PR info ------------------------------------ Title doc: deprecation code for isWebAssemblyCompiledModule (#50486) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:feat/deprecate-isWebAssemblyCompiledModule -> nodejs:main Labels doc, deprecations Commits 4 - doc: deprecation code for isWebAssemblyCompiledModule - addded pr url - Update deprecations.md - fix Committers 2 - Marco Ippolito - GitHub PR-URL: https://github.com/nodejs/node/pull/50486 Reviewed-By: Paolo Insogna Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50486 Reviewed-By: Paolo Insogna Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 31 Oct 2023 10:03:58 GMT ✔ Approvals: 2 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/50486#pullrequestreview-1708249819 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50486#pullrequestreview-1726083822 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50486 From https://github.com/nodejs/node * branch refs/pull/50486/merge -> FETCH_HEAD ✔ Fetched commits as 83e6350b826a..3f0db4ecc604 -------------------------------------------------------------------------------- [main 25fe4458f4] doc: deprecation code for isWebAssemblyCompiledModule Author: Marco Ippolito Date: Tue Oct 31 12:00:56 2023 +0200 1 file changed, 18 insertions(+) [main 68ab441ba5] addded pr url Author: Marco Ippolito Date: Tue Oct 31 12:04:25 2023 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main 416bf34715] Update deprecations.md Author: Marco Ippolito Date: Tue Oct 31 12:17:41 2023 +0200 1 file changed, 2 insertions(+), 2 deletions(-) [main 1e3b421ffb] fix Author: Marco Ippolito Date: Tue Oct 31 14:16:18 2023 +0200 1 file changed, 2 insertions(+), 2 deletions(-) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: deprecation code for isWebAssemblyCompiledModule

PR-URL: #50486
Reviewed-By: Paolo Insogna [email protected]
Reviewed-By: James M Snell [email protected]

[detached HEAD 5cb6020934] doc: deprecation code for isWebAssemblyCompiledModule
Author: Marco Ippolito [email protected]
Date: Tue Oct 31 12:00:56 2023 +0200
1 file changed, 18 insertions(+)
Rebasing (3/8)
Rebasing (4/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
addded pr url

PR-URL: #50486
Reviewed-By: Paolo Insogna [email protected]
Reviewed-By: James M Snell [email protected]

[detached HEAD f0f9b0f266] addded pr url
Author: Marco Ippolito [email protected]
Date: Tue Oct 31 12:04:25 2023 +0200
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (5/8)
Rebasing (6/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update deprecations.md

PR-URL: #50486
Reviewed-By: Paolo Insogna [email protected]
Reviewed-By: James M Snell [email protected]

[detached HEAD 0543c368a6] Update deprecations.md
Author: Marco Ippolito [email protected]
Date: Tue Oct 31 12:17:41 2023 +0200
1 file changed, 2 insertions(+), 2 deletions(-)
Rebasing (7/8)
Rebasing (8/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fix

PR-URL: #50486
Reviewed-By: Paolo Insogna [email protected]
Reviewed-By: James M Snell [email protected]

[detached HEAD b68af47e1d] fix
Author: Marco Ippolito [email protected]
Date: Tue Oct 31 14:16:18 2023 +0200
1 file changed, 2 insertions(+), 2 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/6835327454

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito force-pushed the feat/deprecate-isWebAssemblyCompiledModule branch 2 times, most recently from 65723c3 to b97c02b Compare

November 11, 2023 16:36

marco-ippolito added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Nov 11, 2023

nodejs-github-bot commented Nov 11, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/50486
✔  Done loading data for nodejs/node/pull/50486
----------------------------------- PR info ------------------------------------
Title      doc: deprecation code for isWebAssemblyCompiledModule (#50486)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:feat/deprecate-isWebAssemblyCompiledModule -> nodejs:main
Labels     doc, deprecations
Commits    1
 - doc: deprecation code for isWebAssemblyCompiledModule
Committers 1
 - marco-ippolito 
PR-URL: https://github.com/nodejs/node/pull/50486
Reviewed-By: Paolo Insogna 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50486
Reviewed-By: Paolo Insogna 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - doc: deprecation code for isWebAssemblyCompiledModule
   ℹ  This PR was created on Tue, 31 Oct 2023 10:03:58 GMT
   ✔  Approvals: 2
   ✔  - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/50486#pullrequestreview-1708249819
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50486#pullrequestreview-1726083822
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6836131662

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

UlisesGascon approved these changes

Nov 12, 2023

View reviewed changes

targos commented Nov 12, 2023

Copy link

Copy Markdown

Member

Please correct the commit message (it's missing a verb)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          doc: create deprecation code for isWebAssemblyCompiledModule

38f52f8

marco-ippolito force-pushed the feat/deprecate-isWebAssemblyCompiledModule branch from b97c02b to 38f52f8 Compare

November 13, 2023 08:26

marco-ippolito removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label

Nov 13, 2023

marco-ippolito added the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 22, 2023

nodejs-github-bot commented Nov 22, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/50486
✔  Done loading data for nodejs/node/pull/50486
----------------------------------- PR info ------------------------------------
Title      doc: deprecation code for isWebAssemblyCompiledModule (#50486)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:feat/deprecate-isWebAssemblyCompiledModule -> nodejs:main
Labels     doc, deprecations
Commits    1
 - doc: create deprecation code for isWebAssemblyCompiledModule
Committers 1
 - marco-ippolito 
PR-URL: https://github.com/nodejs/node/pull/50486
Reviewed-By: Paolo Insogna 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50486
Reviewed-By: Paolo Insogna 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - doc: create deprecation code for isWebAssemblyCompiledModule
   ℹ  This PR was created on Tue, 31 Oct 2023 10:03:58 GMT
   ✔  Approvals: 2
   ✔  - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/50486#pullrequestreview-1708249819
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50486#pullrequestreview-1726083822
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6960144937

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS approved these changes

Nov 22, 2023

View reviewed changes

Nov 22, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 22, 2023

nodejs-github-bot merged commit 3782006 into nodejs:main

Nov 22, 2023

nodejs-github-bot commented Nov 22, 2023

Copy link

Copy Markdown

Collaborator

Landed in 3782006

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request

Nov 23, 2023


          doc: create deprecation code for isWebAssemblyCompiledModule

0cdbc08

PR-URL: #50486
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>

lucshi pushed a commit to lucshi/node that referenced this pull request

Nov 27, 2023


          doc: create deprecation code for isWebAssemblyCompiledModule

38f3754

PR-URL: nodejs#50486
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>

RafaelGSS mentioned this pull request

Nov 28, 2023

v21.3.0 proposal #50954

Merged

RafaelGSS pushed a commit that referenced this pull request

Nov 29, 2023


          doc: create deprecation code for isWebAssemblyCompiledModule

98fb1fa

PR-URL: #50486
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>

UlisesGascon pushed a commit that referenced this pull request

Dec 11, 2023


          doc: create deprecation code for isWebAssemblyCompiledModule

f71dbd4

PR-URL: #50486
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>

UlisesGascon mentioned this pull request

Dec 12, 2023

v20.11.0 proposal #51124

Merged

UlisesGascon pushed a commit that referenced this pull request

Dec 13, 2023


          doc: create deprecation code for isWebAssemblyCompiledModule

e5b6ca1

PR-URL: #50486
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>

UlisesGascon pushed a commit that referenced this pull request

Dec 15, 2023


          doc: create deprecation code for isWebAssemblyCompiledModule

4d85763

PR-URL: #50486
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>

UlisesGascon pushed a commit that referenced this pull request

Dec 19, 2023


          doc: create deprecation code for isWebAssemblyCompiledModule

168cbf9

PR-URL: #50486
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>

Reviewers

ShogunPanda

ShogunPanda approved these changes

jasnell

jasnell approved these changes

UlisesGascon

UlisesGascon approved these changes

RafaelGSS

RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

deprecations

Issues and PRs related to deprecations.

doc

Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

marco-ippolito commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 11, 2023

PR-URL: #50486 Reviewed-By: Paolo Insogna [email protected] Reviewed-By: James M Snell [email protected]

PR-URL: #50486 Reviewed-By: Paolo Insogna [email protected] Reviewed-By: James M Snell [email protected]

PR-URL: #50486 Reviewed-By: Paolo Insogna [email protected] Reviewed-By: James M Snell [email protected]

PR-URL: #50486 Reviewed-By: Paolo Insogna [email protected] Reviewed-By: James M Snell [email protected]

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Nov 11, 2023

Uh oh!

targos commented Nov 12, 2023

Uh oh!

nodejs-github-bot commented Nov 22, 2023

Uh oh!

nodejs-github-bot commented Nov 22, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

marco-ippolito commented Oct 31, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

PR-URL: #50486
Reviewed-By: Paolo Insogna [email protected]
Reviewed-By: James M Snell [email protected]

PR-URL: #50486
Reviewed-By: Paolo Insogna [email protected]
Reviewed-By: James M Snell [email protected]

PR-URL: #50486
Reviewed-By: Paolo Insogna [email protected]
Reviewed-By: James M Snell [email protected]

PR-URL: #50486
Reviewed-By: Paolo Insogna [email protected]
Reviewed-By: James M Snell [email protected]