GeezerVison

Hey @RafaelGSS @marco-ippolito @lpinca @jasnell, I noticed that some of the checks seem to be consistently failing for this PR - is there an issue with the code or is it a CI issue preventing the checks from passing?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Nov 21, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55821/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS commented Nov 21, 2023

Copy link

Copy Markdown

Member

Hey @RafaelGSS @marco-ippolito @lpinca @jasnell, I noticed that some of the checks seem to be consistently failing for this PR - is there an issue with the code or is it a CI issue preventing the checks from passing?

I suspect this should be fixed on main. Would you mind rebasing this pr?

RBrNx reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RBrNx added 2 commits

November 22, 2023 11:06


          test: replace forEach with for of

9e60471


          fixup! test: replace forEach with for of

0b856ff

RBrNx force-pushed the nodeconfeu-first-contrib branch from af00890 to 0b856ff Compare

November 22, 2023 11:07

RBrNx commented Nov 22, 2023

Copy link

Copy Markdown

Contributor Author

Hey @RafaelGSS, rebased and pushed! Hopefully the CI checks pass this time 😄

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 22, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 22, 2023

nodejs-github-bot commented Nov 22, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55853/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS added the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 24, 2023

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Nov 24, 2023

nodejs-github-bot commented Nov 24, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/50594
✔  Done loading data for nodejs/node/pull/50594
----------------------------------- PR info ------------------------------------
Title      test: replace forEach with for of (#50594)
Author     Conor Watson  (@RBrNx, first-time contributor)
Branch     RBrNx:nodeconfeu-first-contrib -> nodejs:main
Labels     test, code-and-learn, needs-ci, commit-queue-squash
Commits    2
 - test: replace forEach with for of
 - fixup! test: replace forEach with for of
Committers 1
 - RBrNx 
PR-URL: https://github.com/nodejs/node/pull/50594
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Marco Ippolito 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50594
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Marco Ippolito 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - test: replace forEach with for of
   ⚠  - fixup! test: replace forEach with for of
   ℹ  This PR was created on Tue, 07 Nov 2023 14:59:07 GMT
   ✔  Approvals: 4
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/50594#pullrequestreview-1717930171
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/50594#pullrequestreview-1717957296
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50594#pullrequestreview-1718803041
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50594#pullrequestreview-1726071964
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-11-22T12:52:54Z: https://ci.nodejs.org/job/node-test-pull-request/55853/
- Querying data for job/node-test-pull-request/55853/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6981633672

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS approved these changes

Nov 24, 2023

View reviewed changes

RafaelGSS added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Nov 24, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 24, 2023

nodejs-github-bot merged commit 303654c into nodejs:main

Nov 24, 2023

nodejs-github-bot commented Nov 24, 2023

Copy link

Copy Markdown

Collaborator

Landed in 303654c

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lucshi pushed a commit to lucshi/node that referenced this pull request

Nov 27, 2023


          test: replace forEach with for of

6d4439a

PR-URL: nodejs#50594
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

RafaelGSS pushed a commit that referenced this pull request

Nov 27, 2023


          test: replace forEach with for of

cbc7798

PR-URL: #50594
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

RafaelGSS mentioned this pull request

Nov 28, 2023

v21.3.0 proposal #50954

Merged

RafaelGSS pushed a commit that referenced this pull request

Nov 29, 2023


          test: replace forEach with for of

b1b6c44

PR-URL: #50594
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

UlisesGascon pushed a commit that referenced this pull request

Dec 11, 2023


          test: replace forEach with for of

002481c

PR-URL: #50594
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

UlisesGascon mentioned this pull request

Dec 12, 2023

v20.11.0 proposal #51124

Merged

UlisesGascon pushed a commit that referenced this pull request

Dec 13, 2023


          test: replace forEach with for of

eb10c25

PR-URL: #50594
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

UlisesGascon pushed a commit that referenced this pull request

Dec 15, 2023


          test: replace forEach with for of

8ba10bb

PR-URL: #50594
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

UlisesGascon pushed a commit that referenced this pull request

Dec 19, 2023


          test: replace forEach with for of

PR-URL: #50594
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Reviewers

jasnell

jasnell approved these changes

lpinca

lpinca approved these changes

RafaelGSS

RafaelGSS approved these changes

marco-ippolito

marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

code-and-learn

Issues related to the Code-and-Learn events and PRs submitted during the events.

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

needs-ci

PRs that need a full CI run.

test

Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.