GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: replace forEach() with for-loop by jabro86 · Pull Request #50596 · nodejs/node

Conversation

@jabro86

@jabro86 jabro86 commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

NodeConf

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 7, 2023
@RafaelGSS RafaelGSS added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2023
marco-ippolito
marco-ippolito approved these changes Nov 7, 2023
View reviewed changes
RafaelGSS
RafaelGSS reviewed Nov 7, 2023
View reviewed changes

@RafaelGSS RafaelGSS left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add git email and username please

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jabro86
jabro86 force-pushed the for-loop-test-trace-events branch from 7a623d7 to 2488cbc Compare November 7, 2023 15:12
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 7, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55481/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS
RafaelGSS approved these changes Nov 7, 2023
View reviewed changes
lpinca
lpinca approved these changes Nov 7, 2023
View reviewed changes
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 7, 2023
@RafaelGSS RafaelGSS added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 8, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 9, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50596
✔  Done loading data for nodejs/node/pull/50596
----------------------------------- PR info ------------------------------------
Title      test: replace forEach() with for-loop (#50596)
Author     Jan  (@jabro86, first-time contributor)
Branch     jabro86:for-loop-test-trace-events -> nodejs:main
Labels     test, code-and-learn, author ready, needs-ci
Commits    1
 - test: replace forEach() with for-loop
Committers 1
 - Jan Brockmeyer 
PR-URL: https://github.com/nodejs/node/pull/50596
Reviewed-By: Marco Ippolito 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50596
Reviewed-By: Marco Ippolito 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 07 Nov 2023 15:08:25 GMT
   ✔  Approvals: 3
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/50596#pullrequestreview-1717952006
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/50596#pullrequestreview-1718212674
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50596#pullrequestreview-1718810431
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ⚠  GitHub cannot link the author of 'test: replace forEach() with for-loop' to their GitHub account.
   ⚠  Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-11-07T15:20:39Z: https://ci.nodejs.org/job/node-test-pull-request/55481/
- Querying data for job/node-test-pull-request/55481/
   ✔  Last Jenkins CI successful
   ⚠  PR author is a new contributor: @jabro86([email protected])
   ⚠  - commit 2488cbc834b1 is authored by [email protected]
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6813781442
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jabro86
test: replace forEach() with for-loop
a48d650
@jabro86
jabro86 force-pushed the for-loop-test-trace-events branch from 2488cbc to a48d650 Compare November 9, 2023 21:32
@jabro86

jabro86 commented Nov 9, 2023

Copy link
Copy Markdown
Contributor Author

My previous commit was still using a wrong email address. should be fixed now 😺
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25 debadree25 added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Nov 10, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55531/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55543/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Nov 11, 2023
CI Reliability 2023-11-11 nodejs/reliability#714
Open
27 tasks
jasnell
jasnell approved these changes Nov 11, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Nov 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55565/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Nov 12, 2023
CI Reliability 2023-11-12 nodejs/reliability#715
Open
CI Reliability 2023-11-13 nodejs/reliability#716
Open
CI Reliability 2023-11-14 nodejs/reliability#717
Open
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 18, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 59ebf6d into nodejs:main Nov 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 18, 2023

Copy link
Copy Markdown
Collaborator

Landed in 59ebf6d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Nov 23, 2023
@jabro86 @targos
test: replace forEach() with for-loop
278c768 
PR-URL: #50596
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@jabro86 Lei Shi
test: replace forEach() with for-loop
0169a09 
PR-URL: nodejs#50596
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
v21.3.0 proposal #50954
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@jabro86 @RafaelGSS
test: replace forEach() with for-loop
f2e0fce 
PR-URL: #50596
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@jabro86 @UlisesGascon
test: replace forEach() with for-loop
6b21cca 
PR-URL: #50596
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@jabro86 @UlisesGascon
test: replace forEach() with for-loop
6584dd8 
PR-URL: #50596
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95 aduh95 mentioned this pull request May 5, 2024
test: replace forEach with for of #49800
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@jabro86 @nodejs-github-bot @jasnell @lpinca @RafaelGSS @marco-ippolito @debadree25
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.