GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update Crypto API doc for x509.keyUsage to x509.extKeyUsage by DMeechan · Pull Request #50603 · nodejs/node

Conversation

@DMeechan

@DMeechan DMeechan commented Nov 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Updated Crypto API definition for x509.keyUsage to x509.extKeyUsage.

Refs: #48727

Created at NodeConf! ❤️

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@DMeechan
doc: update Crypto API doc for x509.keyUsage
f19e1cb
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to Node.js documentation. labels Nov 7, 2023
@marco-ippolito marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2023
@Qard Qard added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 7, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55483/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Nov 8, 2023
CI Reliability 2023-11-08 nodejs/reliability#711
Open
CI Reliability 2023-11-09 nodejs/reliability#712
Open
@nodejs-github-bot

nodejs-github-bot commented Nov 9, 2023 •
edited by jasnell
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55522/ 💛

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Nov 10, 2023
CI Reliability 2023-11-10 nodejs/reliability#713
Open
CI Reliability 2023-11-11 nodejs/reliability#714
Open
jasnell
jasnell approved these changes Nov 11, 2023
View reviewed changes
@jasnell jasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 11, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 11, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 11, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50603
✔  Done loading data for nodejs/node/pull/50603
----------------------------------- PR info ------------------------------------
Title      doc: update Crypto API doc for x509.keyUsage to x509.extKeyUsage (#50603)
Author     Daniel Meechan  (@DMeechan, first-time contributor)
Branch     DMeechan:crypto-api-key-usage -> nodejs:main
Labels     crypto, doc, code-and-learn
Commits    1
 - doc: update Crypto API doc for x509.keyUsage
Committers 1
 - Daniel Meechan 
PR-URL: https://github.com/nodejs/node/pull/50603
Refs: https://github.com/nodejs/node/issues/48727
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50603
Refs: https://github.com/nodejs/node/issues/48727
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 07 Nov 2023 15:15:49 GMT
   ✔  Approvals: 1
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50603#pullrequestreview-1726076103
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✘  This PR needs to wait 71 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6835039755
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Nov 12, 2023
CI Reliability 2023-11-12 nodejs/reliability#715
Open
18 tasks
marco-ippolito
marco-ippolito approved these changes Nov 20, 2023
View reviewed changes
@marco-ippolito marco-ippolito added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Nov 20, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 20, 2023
@nodejs-github-bot
nodejs-github-bot merged commit a9a4778 into nodejs:main Nov 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 20, 2023

Copy link
Copy Markdown
Collaborator

Landed in a9a4778

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request Nov 23, 2023
@DMeechan @targos
doc: update Crypto API doc for x509.keyUsage
5ba6e7f
PR-URL: #50603
Refs: #48727
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@DMeechan Lei Shi
doc: update Crypto API doc for x509.keyUsage
8eafec3
PR-URL: nodejs#50603
Refs: nodejs#48727
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
v21.3.0 proposal #50954
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@DMeechan @RafaelGSS
doc: update Crypto API doc for x509.keyUsage
8468daf
PR-URL: #50603
Refs: #48727
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@DMeechan
DMeechan deleted the crypto-api-key-usage branch November 30, 2023 13:03
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@DMeechan @UlisesGascon
doc: update Crypto API doc for x509.keyUsage
3eb9e4e
PR-URL: #50603
Refs: #48727
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@DMeechan @UlisesGascon
doc: update Crypto API doc for x509.keyUsage
e22ce95
PR-URL: #50603
Refs: #48727
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@panva

panva commented Aug 2, 2025

Copy link
Copy Markdown
Member

Why did this land? There's no extKeyUsage as far as I can tell...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@panva panva mentioned this pull request Aug 2, 2025
doc: rename x509.extKeyUsage to x509.keyUsage #59332
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@DMeechan @nodejs-github-bot @panva @jasnell @marco-ippolito @Qard
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.