GeezerVison

- Loading data for nodejs/node/pull/50708
✔  Done loading data for nodejs/node/pull/50708
----------------------------------- PR info ------------------------------------
Title      test: improve test-bootstrap-modules.js (#50708)
Author     Joyee Cheung  (@joyeecheung)
Branch     joyeecheung:bootstrap-module-test -> nodejs:main
Labels     test, author ready, needs-ci
Commits    2
 - test: improve test-bootstrap-modules.js
 - fixup! test: improve test-bootstrap-modules.js #50708
Committers 2
 - Joyee Cheung 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/50708
Reviewed-By: Antoine du Hamel 
Reviewed-By: Richard Lau 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Chengzhong Wu 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50708
Reviewed-By: Antoine du Hamel 
Reviewed-By: Richard Lau 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Chengzhong Wu 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 13 Nov 2023 13:10:44 GMT
   ✔  Approvals: 4
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/50708#pullrequestreview-1733682030
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/50708#pullrequestreview-1734416571
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50708#pullrequestreview-1737180743
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/50708#pullrequestreview-1737350580
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-11-17T16:08:59Z: https://ci.nodejs.org/job/node-test-pull-request/55712/
- Querying data for job/node-test-pull-request/55712/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 50708
From https://github.com/nodejs/node
 * branch                  refs/pull/50708/merge -> FETCH_HEAD
✔  Fetched commits as ce4642a5c2ac..1cc16d5329ac
--------------------------------------------------------------------------------
Auto-merging test/parallel/test-bootstrap-modules.js
[main 5e27c443ab] test: improve test-bootstrap-modules.js
 Author: Joyee Cheung 
 Date: Sun Nov 12 22:38:30 2023 +0100
 1 file changed, 103 insertions(+), 25 deletions(-)
Auto-merging test/parallel/test-bootstrap-modules.js
[main 562733ba5b] fixup! test: improve test-bootstrap-modules.js #50708
 Author: Joyee Cheung 
 Date: Wed Nov 15 15:40:27 2023 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test: improve test-bootstrap-modules.js
Divide builtins into two lists depending on whether

they are loaded before pre-execution or at run time,

and give clearer suggestions about how to deal with them

based on the category they are in.
This helps preventing regressions like the one reported

in #45662.
PR-URL: #50708

Reviewed-By: Antoine du Hamel [email protected]

Reviewed-By: Richard Lau [email protected]

Reviewed-By: Yagiz Nizipli [email protected]

Reviewed-By: Chengzhong Wu [email protected]
[detached HEAD cf391d10b0] test: improve test-bootstrap-modules.js

Author: Joyee Cheung [email protected]

Date: Sun Nov 12 22:38:30 2023 +0100

1 file changed, 103 insertions(+), 25 deletions(-)

Rebasing (3/4)

Rebasing (4/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fixup! test: improve test-bootstrap-modules.js #50708
Co-authored-by: Antoine du Hamel [email protected]

PR-URL: #50708

Reviewed-By: Antoine du Hamel [email protected]

Reviewed-By: Richard Lau [email protected]

Reviewed-By: Yagiz Nizipli [email protected]

Reviewed-By: Chengzhong Wu [email protected]
[detached HEAD a21da1dd34] fixup! test: improve test-bootstrap-modules.js #50708

Author: Joyee Cheung [email protected]

Date: Wed Nov 15 15:40:27 2023 +0100

1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.