GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — tools: add workflow to update release links by targos · Pull Request #50710 · nodejs/node

Conversation

targos commented Nov 13, 2023

Copy link

Copy Markdown

Member

Refs: #50623

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          tools: add workflow to update release links

354385e

Refs: nodejs#50623

nodejs-github-bot commented Nov 13, 2023

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/actions

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label

Nov 13, 2023

targos mentioned this pull request

Nov 13, 2023

doc: add r2 cloudflare instruction on release #50623

Closed

targos commented Nov 13, 2023

Copy link

Copy Markdown

Member Author

/cc @nodejs/tsc. I think this requires adding write access to https://github.com/nodejs/release-cloudflare-worker for the nodejs-github-bot account.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ovflowd approved these changes

Nov 13, 2023

View reviewed changes

ovflowd left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is awesome! That's an interesting way of triggering the Workflow by using GitHub's CLI!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

.github/workflows/update-release-links.yml

		steps:
		- name: Trigger update-links workflow on nodejs/release-cloudflare-worker
		run: \|
		gh workflow run update-links.yml --repo nodejs/release-cloudflare-worker

ovflowd Nov 13, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also trigger the job (after this one) to deploy the worker to prod 👀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

targos Nov 13, 2023

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you want this to happen, it should be done from the nodejs/release-cloudflare-worker repo.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MoLow and flakey5 reacted with thumbs up emoji

All reactions

👍 2 reactions

ovflowd Nov 13, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, was pondering on that. @flakey5 it might make sense to make it autodeploz after updating the links

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

MoLow Nov 13, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it currently opens a PR and needs manual approval & merge - we will need to change it to commit and push to main - I don't know if that is possible

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ovflowd Nov 13, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it currently opens a PR and needs manual approval & merge - we will need to change it to commit and push to main - I don't know if that is possible

It is. You can make the workflow commit and push to main directly,

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

flakey5 Nov 13, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd definitely be for either letting the releasers merge the pr it generates in release-cloudflare-worker or having them automatically merged and then deployed. I'm not sure exactly how we could get the second option working right now though

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ovflowd Nov 13, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is easy to do the 2nd. Just instead of opening a PR simply do a commit and then push. You can see a workflow that does similar on the nodejs.org repository (I think the i18n workflow)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

flakey5 reacted with thumbs up emoji

All reactions

👍 1 reaction

flakey5 Nov 13, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that sounds good to me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ovflowd Nov 13, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we create an issue on the worker repo?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

flakey5 Nov 14, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodejs/release-cloudflare-worker#66

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

UlisesGascon approved these changes

Nov 13, 2023

View reviewed changes

MoLow approved these changes

Nov 13, 2023

View reviewed changes

richardlau approved these changes

Nov 13, 2023

View reviewed changes

jasnell approved these changes

Nov 13, 2023

View reviewed changes

anonrig approved these changes

Nov 13, 2023

View reviewed changes

mhdawson approved these changes

Nov 13, 2023

View reviewed changes

mhdawson left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

flakey5 mentioned this pull request

Nov 14, 2023

Automatically merge & deploy prs for updating redirect links nodejs/release-cloudflare-worker#66

Closed

targos added author ready

PRs with CI started, the required approvals, and no outstanding review comments.

commit-queue PRs queued for automated landing through the Commit Queue. labels

Nov 14, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 15, 2023

nodejs-github-bot merged commit 86593e5 into nodejs:main

Nov 15, 2023

nodejs-github-bot commented Nov 15, 2023

Copy link

Copy Markdown

Collaborator

Landed in 86593e5

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos deleted the update-links branch

November 15, 2023 13:40

targos added a commit that referenced this pull request

Nov 23, 2023


          tools: add workflow to update release links

52830b7

Refs: #50623
PR-URL: #50710
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>

RafaelGSS mentioned this pull request

Nov 28, 2023

v21.3.0 proposal #50954

Merged

UlisesGascon pushed a commit that referenced this pull request

Dec 11, 2023


          tools: add workflow to update release links

6beb18b

Refs: #50623
PR-URL: #50710
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>

UlisesGascon mentioned this pull request

Dec 12, 2023

v20.11.0 proposal #51124

Merged

UlisesGascon pushed a commit that referenced this pull request

Dec 19, 2023


          tools: add workflow to update release links

93085cf

Refs: #50623
PR-URL: #50710
Reviewed-By: Claudio Wunder <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>

Reviewers

MoLow

MoLow approved these changes

ovflowd

ovflowd approved these changes

jasnell

jasnell approved these changes

anonrig

anonrig approved these changes

UlisesGascon

UlisesGascon approved these changes

richardlau

richardlau approved these changes

+2 more reviewers

flakey5

flakey5 left review comments

mhdawson

mhdawson approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

targos commented Nov 13, 2023

Uh oh!

nodejs-github-bot commented Nov 13, 2023

Uh oh!

targos commented Nov 13, 2023

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MoLow Nov 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Nov 15, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

MoLow Nov 13, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.