GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: give more time to GC in test-shadow-realm-gc-* by joyeecheung · Pull Request #50735 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Nov 14, 2023

Copy link
Copy Markdown
Member

When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test.

As a workaround, give GC a bit more time by waiting for a timer in the loop.

Refs: #50726

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 14, 2023
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 14, 2023
joyeecheung
joyeecheung commented Nov 14, 2023
View reviewed changes
Comment thread test/parallel/test-shadow-realm-gc-module.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55650/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Nov 15, 2023
CI Reliability 2023-11-15 nodejs/reliability#718
Open
26 tasks
targos
targos reviewed Nov 15, 2023
View reviewed changes
Comment thread test/parallel/test-shadow-realm-gc-module.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

@joyeecheung
test: give more time to GC in test-shadow-realm-gc-*
f2a9e57
When --node-builtin-modules-path is used, we read and create
new strings for builtins in each realm which increases the memory
usage. As a result GC may not be able to keep up with the
allocation done in the loop in the test.

As a workaround, give GC a bit more time by waiting for a timer
in the loop.
@joyeecheung
joyeecheung force-pushed the shadow-realm-gc branch from 59eac85 to f2a9e57 Compare November 15, 2023 14:59
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 15, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55663/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

legendecas
legendecas approved these changes Nov 15, 2023
View reviewed changes
@joyeecheung

joyeecheung commented Nov 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Testing with --node-builtin-modules-path=. https://ci.nodejs.org/job/node-test-commit/66586/

EDIT: er...looks like --node-builtin-modules-path=. doesn't work in the CI

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joyeecheung

joyeecheung commented Nov 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Stress test for affected platforms (using nodejs/reliability#718) https://ci.nodejs.org/job/node-stress-single-test/465/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Nov 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55690/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joyeecheung

joyeecheung commented Nov 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I am again seeing this in the V8 integration CI, not sure if this fixes the flake over there https://logs.chromium.org/logs/node-ci/buildbucket/cr-buildbucket/8764249834281259873/+/u/test_default__retry_/stdout

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joyeecheung

joyeecheung commented Nov 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Last CI and stress tests were green although the bot did not communicate the result to GitHub again (failures are from #50735 (comment) which wasn't supported by the CI..)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joyeecheung joyeecheung changed the title test: give more time to GC in test-shadow-realm-gc-module test: give more time to GC in test-shadow-realm-gc-* Nov 16, 2023
@joyeecheung

joyeecheung commented Nov 17, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

This needs another LGTM to land - I am seeing this again in another V8 CI so it's better to deflake them sooner too.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joyeecheung joyeecheung mentioned this pull request Nov 17, 2023
test-shadow-realm-gc-module can crash on macOS (OOM) #50726
Closed
anonrig
anonrig approved these changes Nov 17, 2023
View reviewed changes
joyeecheung added a commit that referenced this pull request Nov 17, 2023
@joyeecheung
test: give more time to GC in test-shadow-realm-gc-*
c5eb2c4
When --node-builtin-modules-path is used, we read and create
new strings for builtins in each realm which increases the memory
usage. As a result GC may not be able to keep up with the
allocation done in the loop in the test.

As a workaround, give GC a bit more time by waiting for a timer
in the loop.

PR-URL: #50735
Refs: #50726
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@joyeecheung

joyeecheung commented Nov 17, 2023

Copy link
Copy Markdown
Member Author

landed in c5eb2c4

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joyeecheung joyeecheung closed this Nov 17, 2023
pthier pushed a commit to v8/node that referenced this pull request Nov 20, 2023
pthier
[test] Give more time to GC in test-shadow-realm-gc
648158d
Partial cherry-pick of nodejs#50735
targos pushed a commit that referenced this pull request Nov 23, 2023
@joyeecheung @targos
test: give more time to GC in test-shadow-realm-gc-*
91dbe13
When --node-builtin-modules-path is used, we read and create
new strings for builtins in each realm which increases the memory
usage. As a result GC may not be able to keep up with the
allocation done in the loop in the test.

As a workaround, give GC a bit more time by waiting for a timer
in the loop.

PR-URL: #50735
Refs: #50726
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
zcbenz pushed a commit to photoionization/node_ci that referenced this pull request Nov 27, 2023
pthier Node-ci LUCI CQ
Update node
d3a6ba2
To include (partially) nodejs/node#50735 to fix
flaky tests.

Change-Id: I5355397d639bcb03ca2f5de24200db18d6e02505
Reviewed-on: https://chromium-review.googlesource.com/c/v8/node-ci/+/5038521
Reviewed-by: Victor Gomes <[email protected]>
Auto-Submit: Patrick Thier <[email protected]>
Commit-Queue: Victor Gomes <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@joyeecheung Lei Shi
test: give more time to GC in test-shadow-realm-gc-*
377c28d
When --node-builtin-modules-path is used, we read and create
new strings for builtins in each realm which increases the memory
usage. As a result GC may not be able to keep up with the
allocation done in the loop in the test.

As a workaround, give GC a bit more time by waiting for a timer
in the loop.

PR-URL: nodejs#50735
Refs: nodejs#50726
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
v21.3.0 proposal #50954
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@joyeecheung @RafaelGSS
test: give more time to GC in test-shadow-realm-gc-*
6475cee
When --node-builtin-modules-path is used, we read and create
new strings for builtins in each realm which increases the memory
usage. As a result GC may not be able to keep up with the
allocation done in the loop in the test.

As a workaround, give GC a bit more time by waiting for a timer
in the loop.

PR-URL: #50735
Refs: #50726
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@joyeecheung @richardlau
test: give more time to GC in test-shadow-realm-gc-*
26a06b0
When --node-builtin-modules-path is used, we read and create
new strings for builtins in each realm which increases the memory
usage. As a result GC may not be able to keep up with the
allocation done in the loop in the test.

As a workaround, give GC a bit more time by waiting for a timer
in the loop.

PR-URL: #50735
Refs: #50726
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@legendecas legendecas legendecas approved these changes
+1 more reviewer
@targos targos targos left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@joyeecheung @nodejs-github-bot @anonrig @targos @legendecas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.