GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — test: give more time to GC in test-shadow-realm-gc-* by joyeecheung · Pull Request #50735 · nodejs/node Conversation
Member
When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test. As a workaround, give GC a bit more time by waiting for a timer in the loop. Refs: #50726
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
joyeecheung
commented
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
26 tasks
targos
reviewed
Uh oh!
There was an error while loading. Please reload this page. When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test. As a workaround, give GC a bit more time by waiting for a timer in the loop.
joyeecheung
force-pushed
the
shadow-realm-gc
branch
from
59eac85 to
f2a9e57
Compare
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
legendecas
approved these changes
|
There was an error while loading. Please reload this page.
|
Testing with EDIT: er...looks like |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Stress test for affected platforms (using nodejs/reliability#718) https://ci.nodejs.org/job/node-stress-single-test/465/ |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I am again seeing this in the V8 integration CI, not sure if this fixes the flake over there https://logs.chromium.org/logs/node-ci/buildbucket/cr-buildbucket/8764249834281259873/+/u/test_default__retry_/stdout |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Last CI and stress tests were green although the bot did not communicate the result to GitHub again (failures are from #50735 (comment) which wasn't supported by the CI..) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
This needs another LGTM to land - I am seeing this again in another V8 CI so it's better to deflake them sooner too. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test. As a workaround, give GC a bit more time by waiting for a timer in the loop. PR-URL: #50735 Refs: #50726 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
|
landed in c5eb2c4 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Partial cherry-pick of nodejs#50735
When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test. As a workaround, give GC a bit more time by waiting for a timer in the loop. PR-URL: #50735 Refs: #50726 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
To include (partially) nodejs/node#50735 to fix flaky tests. Change-Id: I5355397d639bcb03ca2f5de24200db18d6e02505 Reviewed-on: https://chromium-review.googlesource.com/c/v8/node-ci/+/5038521 Reviewed-by: Victor Gomes <[email protected]> Auto-Submit: Patrick Thier <[email protected]> Commit-Queue: Victor Gomes <[email protected]>
When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test. As a workaround, give GC a bit more time by waiting for a timer in the loop. PR-URL: nodejs#50735 Refs: nodejs#50726 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test. As a workaround, give GC a bit more time by waiting for a timer in the loop. PR-URL: #50735 Refs: #50726 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
When --node-builtin-modules-path is used, we read and create new strings for builtins in each realm which increases the memory usage. As a result GC may not be able to keep up with the allocation done in the loop in the test. As a workaround, give GC a bit more time by waiting for a timer in the loop. PR-URL: #50735 Refs: #50726 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.