GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js by StiffWriter00 · Pull Request #50795 · nodejs/node

Conversation

StiffWriter00 commented Nov 18, 2023

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js

e853993

nodejs-github-bot added needs-ci

PRs that need a full CI run.

test Issues and PRs related to Node.js core tests and test infrastructure. labels

Nov 18, 2023

marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label

Nov 18, 2023

jasnell approved these changes

Nov 19, 2023

View reviewed changes

marco-ippolito approved these changes

Nov 20, 2023

View reviewed changes

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 20, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 20, 2023

nodejs-github-bot commented Nov 20, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55781/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Nov 21, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55818/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca approved these changes

Nov 21, 2023

View reviewed changes

RafaelGSS added the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 24, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 24, 2023

nodejs-github-bot merged commit 8c72210 into nodejs:main

Nov 24, 2023

nodejs-github-bot commented Nov 24, 2023

Copy link

Copy Markdown

Collaborator

Landed in 8c72210

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lucshi pushed a commit to lucshi/node that referenced this pull request

Nov 27, 2023


          test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js

247915b

PR-URL: nodejs#50795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

RafaelGSS pushed a commit that referenced this pull request

Nov 27, 2023


          test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js

46bfdf4

PR-URL: #50795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

RafaelGSS mentioned this pull request

Nov 28, 2023

v21.3.0 proposal #50954

Merged

RafaelGSS pushed a commit that referenced this pull request

Nov 29, 2023


          test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js

7f44164

PR-URL: #50795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

UlisesGascon pushed a commit that referenced this pull request

Dec 11, 2023


          test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js

9f5860f

PR-URL: #50795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

UlisesGascon mentioned this pull request

Dec 12, 2023

v20.11.0 proposal #51124

Merged

UlisesGascon pushed a commit that referenced this pull request

Dec 13, 2023


          test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js

04717bd

PR-URL: #50795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

UlisesGascon pushed a commit that referenced this pull request

Dec 15, 2023


          test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js

0ad36c2

PR-URL: #50795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

UlisesGascon pushed a commit that referenced this pull request

Dec 19, 2023


          test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js

96143a3

PR-URL: #50795
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

Reviewers

jasnell

jasnell approved these changes

lpinca

lpinca approved these changes

marco-ippolito

marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

code-and-learn

Issues related to the Code-and-Learn events and PRs submitted during the events.

needs-ci

PRs that need a full CI run.

test

Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.