GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: use ppc and ppc64 to skip SEA tests on PowerPC by joyeecheung · Pull Request #50828 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Nov 20, 2023

Copy link
Copy Markdown
Member

It seems using ppc alone is not enough. Add ppc64 to be safe.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joyeecheung
test: use ppc and ppc64 to skip SEA tests on PowerPC
a5cac37 
It seems using ppc alone is not enough. Add ppc64 to be safe.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 20, 2023
@joyeecheung

joyeecheung commented Nov 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

For context I looked at the CI and found https://ci.nodejs.org/job/node-test-commit-plinux/50941/ which was rebasing onto a commit that should contain #50750 yet the SEA tests are still not marked as flaky. To be safe, just check both ppc and ppc64 here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 20, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55793/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Nov 20, 2023
View reviewed changes
lpinca
lpinca approved these changes Nov 20, 2023
View reviewed changes
@joyeecheung joyeecheung added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 20, 2023
@github-actions

github-actions Bot commented Nov 20, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @joyeecheung. Please 👍 to approve.
kvakil and richardlau reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55800/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kvakil
kvakil approved these changes Nov 20, 2023
View reviewed changes
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 21, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 78633c4 into nodejs:main Nov 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 21, 2023

Copy link
Copy Markdown
Collaborator

Landed in 78633c4
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Nov 21, 2023
@joyeecheung @targos
test: use ppc and ppc64 to skip SEA tests on PowerPC
6e0f0fa 
It seems using ppc alone is not enough. Add ppc64 to be safe.

PR-URL: #50828
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Keyhan Vakil <[email protected]>
@targos targos mentioned this pull request Nov 21, 2023
v20.10.0 release proposal #50682
Merged
targos pushed a commit that referenced this pull request Nov 23, 2023
@joyeecheung @targos
test: use ppc and ppc64 to skip SEA tests on PowerPC
3287a21 
It seems using ppc alone is not enough. Add ppc64 to be safe.

PR-URL: #50828
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Keyhan Vakil <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@joyeecheung Lei Shi
test: use ppc and ppc64 to skip SEA tests on PowerPC
7131119 
It seems using ppc alone is not enough. Add ppc64 to be safe.

PR-URL: nodejs#50828
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Keyhan Vakil <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
v21.3.0 proposal #50954
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@joyeecheung @RafaelGSS
test: use ppc and ppc64 to skip SEA tests on PowerPC
221952a 
It seems using ppc alone is not enough. Add ppc64 to be safe.

PR-URL: #50828
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Keyhan Vakil <[email protected]>
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
@joyeecheung joyeecheung mentioned this pull request Jan 9, 2024
v21.6.0 proposal #51342
Merged
@richardlau richardlau mentioned this pull request Jan 10, 2024
test: fix flaky conditions for ppc64 SEA tests #51422
Merged
nodejs-github-bot pushed a commit that referenced this pull request Jan 11, 2024
@richardlau
test: fix flaky conditions for ppc64 SEA tests
273c892 
In test status files, `$system` will be the OS and not the arch (which
would be `$arch`).

Add missing single-executable-application test to the list of tests
marked flaky on Linux ppc64le.

PR-URL: #51422
Refs: #50828
Refs: #50740
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jan 11, 2024
@richardlau @RafaelGSS
test: fix flaky conditions for ppc64 SEA tests
757a84c 
In test status files, `$system` will be the OS and not the arch (which
would be `$arch`).

Add missing single-executable-application test to the list of tests
marked flaky on Linux ppc64le.

PR-URL: #51422
Refs: #50828
Refs: #50740
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
@richardlau @marco-ippolito
test: fix flaky conditions for ppc64 SEA tests
25aaf1a 
In test status files, `$system` will be the OS and not the arch (which
would be `$arch`).

Add missing single-executable-application test to the list of tests
marked flaky on Linux ppc64le.

PR-URL: nodejs#51422
Refs: nodejs#50828
Refs: nodejs#50740
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@richardlau @Medhansh404
test: fix flaky conditions for ppc64 SEA tests
396dd89 
In test status files, `$system` will be the OS and not the arch (which
would be `$arch`).

Add missing single-executable-application test to the list of tests
marked flaky on Linux ppc64le.

PR-URL: nodejs#51422
Refs: nodejs#50828
Refs: nodejs#50740
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
richardlau added a commit that referenced this pull request Mar 25, 2024
@richardlau
test: fix flaky conditions for ppc64 SEA tests
6ee5f50 
In test status files, `$system` will be the OS and not the arch (which
would be `$arch`).

Add missing single-executable-application test to the list of tests
marked flaky on Linux ppc64le.

PR-URL: #51422
Refs: #50828
Refs: #50740
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
+1 more reviewer
@kvakil kvakil kvakil approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@joyeecheung @nodejs-github-bot @lpinca @richardlau @kvakil
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.