GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: add GN configurations for simdjson by zcbenz · Pull Request #50831 · nodejs/node

Conversation

@zcbenz

@zcbenz zcbenz commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

Fix the GN build after the change in #50322.

Would appreciate a fast track merge to bring GN build back to green, so we can continue monitoring if anything breaks on main branch. /cc @anonrig

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zcbenz
build: add GN configurations for simdjson
418117a
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Nov 21, 2023
This was referenced Nov 21, 2023
Things blocking a full-featured GN build of upstream Node.js photoionization/node_with_gn#1
Closed
Failed build: node photoionization/node_with_gn#2
Closed
kvakil
kvakil approved these changes Nov 21, 2023
View reviewed changes

@kvakil kvakil left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kvakil kvakil added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 21, 2023
@github-actions

github-actions Bot commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @kvakil. Please 👍 to approve.
kvakil, marco-ippolito, and anonrig reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kvakil kvakil added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 21, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55808/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
marco-ippolito
marco-ippolito approved these changes Nov 21, 2023
View reviewed changes
anonrig
anonrig approved these changes Nov 21, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Nov 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55827/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kvakil kvakil added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 21, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 1858341 into nodejs:main Nov 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 21, 2023

Copy link
Copy Markdown
Collaborator

Landed in 1858341
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Nov 23, 2023
@zcbenz @targos
build: add GN configurations for simdjson
36fee4e 
PR-URL: #50831
Reviewed-By: Keyhan Vakil <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@zcbenz Lei Shi
build: add GN configurations for simdjson
a653bde 
PR-URL: nodejs#50831
Reviewed-By: Keyhan Vakil <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
v21.3.0 proposal #50954
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@zcbenz @RafaelGSS
build: add GN configurations for simdjson
5849f09 
PR-URL: #50831
Reviewed-By: Keyhan Vakil <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@zcbenz @UlisesGascon
build: add GN configurations for simdjson
bab4592 
PR-URL: #50831
Reviewed-By: Keyhan Vakil <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@zcbenz @UlisesGascon
build: add GN configurations for simdjson
44081d8 
PR-URL: #50831
Reviewed-By: Keyhan Vakil <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@zcbenz @UlisesGascon
build: add GN configurations for simdjson
f916774 
PR-URL: #50831
Reviewed-By: Keyhan Vakil <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@zcbenz @UlisesGascon
build: add GN configurations for simdjson
80ea837 
PR-URL: #50831
Reviewed-By: Keyhan Vakil <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
+1 more reviewer
@kvakil kvakil kvakil approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

dependencies PRs that add, update, or configure Node.js dependencies. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@zcbenz @nodejs-github-bot @anonrig @kvakil @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.