GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — meta: clarify nomination process according to Node.js charter by mcollina · Pull Request #50834 · nodejs/node

Conversation

@mcollina

@mcollina mcollina commented Nov 21, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Clarification on the nomination process as mentioned by @jasnell in nodejs/TSC#1467 (comment).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ljharb reacted with eyes emoji
All reactions
  • 👀 1 reaction
@mcollina
meta: clarify nomination process according to Node.js charter
a023014
Signed-off-by: Matteo Collina <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Nov 21, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 21, 2023
@mcollina
mcollina requested review from jasnell and mhdawson November 21, 2023 09:00
gireeshpunathil
gireeshpunathil approved these changes Nov 21, 2023
View reviewed changes
Comment thread GOVERNANCE.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@mcollina @gireeshpunathil
Update GOVERNANCE.md
97acd78
Co-authored-by: Gireesh Punathil <[email protected]>
@GeoffreyBooth

GeoffreyBooth commented Nov 21, 2023

Copy link
Copy Markdown
Member

I don't see how that comment led to this. And this language feels harsh; mentioning directly that the TSC might overrule an objection feels like it would chill people making objections. Doesn't the TSC already have this power without needing to add this text?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mcollina

mcollina commented Nov 21, 2023

Copy link
Copy Markdown
Member Author

Yes. Apparently a few other TSC members think it is required to explicit it out.

gireeshpunathil and benjamingr reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS
RafaelGSS approved these changes Nov 21, 2023
View reviewed changes
ronag
ronag approved these changes Nov 21, 2023
View reviewed changes
mhdawson
mhdawson reviewed Nov 21, 2023
View reviewed changes
Comment thread GOVERNANCE.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@mcollina @mhdawson
Update GOVERNANCE.md
565d236
Co-authored-by: Michael Dawson <[email protected]>
anonrig
anonrig approved these changes Nov 21, 2023
View reviewed changes
aduh95
aduh95 approved these changes Nov 21, 2023
View reviewed changes
mhdawson
mhdawson approved these changes Nov 21, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
joyeecheung
joyeecheung approved these changes Nov 21, 2023
View reviewed changes
benjamingr
benjamingr approved these changes Nov 21, 2023
View reviewed changes
lpinca
lpinca approved these changes Nov 21, 2023
View reviewed changes
RaisinTen
RaisinTen approved these changes Nov 22, 2023
View reviewed changes
aduh95
aduh95 reviewed Nov 22, 2023
View reviewed changes
Comment thread GOVERNANCE.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@mcollina @aduh95
Update GOVERNANCE.md
ea35554
Co-authored-by: Antoine du Hamel <[email protected]>
targos
targos approved these changes Nov 22, 2023
View reviewed changes
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 22, 2023
legendecas
legendecas approved these changes Nov 22, 2023
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 22, 2023
@nodejs-github-bot

This comment was marked as off-topic.

Sign in to view
jasnell
jasnell reviewed Nov 24, 2023
View reviewed changes
Comment thread GOVERNANCE.md
the nomination fails.
The nomination passes if no collaborators oppose it after one week. In the case
of an objection, the TSC is responsible for working with the individuals
involved and finding a resolution.

@jasnell jasnell Nov 24, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
involved and finding a resolution.
involved and finding a resolution. The TSC may, at its discretion, vote to override
any objection but should do so only after other measures to reach consensus have
failed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@benjamingr benjamingr Nov 24, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the existing phrasing since it says the TSC is responsible for resolving the matter rather than just voting. The TSC for example can come to consensus about overriding a nomination without voting. It also emphasizes the TSC working with the individuals rather than them having to reach consensus on their own.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
jasnell
jasnell approved these changes Nov 24, 2023
View reviewed changes

@jasnell jasnell left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, consider it optional. Otherwise LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ruyadorno
ruyadorno approved these changes Nov 24, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55916/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 25, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Nov 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 25, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50834
✔  Done loading data for nodejs/node/pull/50834
----------------------------------- PR info ------------------------------------
Title      meta: clarify nomination process according to Node.js charter (#50834)
Author     Matteo Collina  (@mcollina)
Branch     mcollina:clarify-nomination-process -> nodejs:main
Labels     meta
Commits    4
 - meta: clarify nomination process according to Node.js charter
 - Update GOVERNANCE.md
 - Update GOVERNANCE.md
 - Update GOVERNANCE.md
Committers 2
 - Matteo Collina 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/50834
Reviewed-By: Gireesh Punathil 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Robert Nagy 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Michael Dawson 
Reviewed-By: Joyee Cheung 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
Reviewed-By: Darshan Sen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Chengzhong Wu 
Reviewed-By: James M Snell 
Reviewed-By: Ruy Adorno 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50834
Reviewed-By: Gireesh Punathil 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Robert Nagy 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Michael Dawson 
Reviewed-By: Joyee Cheung 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
Reviewed-By: Darshan Sen 
Reviewed-By: Michaël Zasso 
Reviewed-By: Chengzhong Wu 
Reviewed-By: James M Snell 
Reviewed-By: Ruy Adorno 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 21 Nov 2023 08:59:46 GMT
   ✔  Approvals: 14
   ✔  - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1741455492
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742081465
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742112546
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742210875
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742213614
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742224874
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742622759
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742635069
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50834#pullrequestreview-1743060178
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1743672722
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1743943202
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1743957631
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1748043163
   ✔  - Ruy Adorno (@ruyadorno) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1748302024
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 50834
From https://github.com/nodejs/node
 * branch                  refs/pull/50834/merge -> FETCH_HEAD
✔  Fetched commits as ed5cb37ccbc4..ea35554c7d75
--------------------------------------------------------------------------------
[main af5b57919e] meta: clarify nomination process according to Node.js charter
 Author: Matteo Collina 
 Date: Tue Nov 21 09:59:10 2023 +0100
 1 file changed, 3 insertions(+)
[main f41d89451f] Update GOVERNANCE.md
 Author: Matteo Collina 
 Date: Tue Nov 21 10:13:59 2023 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
[main b03aacd5a2] Update GOVERNANCE.md
 Author: Matteo Collina 
 Date: Tue Nov 21 15:42:33 2023 +0100
 1 file changed, 3 insertions(+), 5 deletions(-)
[main 6d64197199] Update GOVERNANCE.md
 Author: Matteo Collina 
 Date: Wed Nov 22 10:35:08 2023 +0100
 1 file changed, 3 insertions(+), 3 deletions(-)
   ✔  Patches applied
There are 4 commits in the PR. Attempting autorebase.
Rebasing (2/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
meta: clarify nomination process according to Node.js charter

Signed-off-by: Matteo Collina [email protected]
PR-URL: #50834
Reviewed-By: Gireesh Punathil [email protected]
Reviewed-By: Rafael Gonzaga [email protected]
Reviewed-By: Robert Nagy [email protected]
Reviewed-By: Yagiz Nizipli [email protected]
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: Michael Dawson [email protected]
Reviewed-By: Joyee Cheung [email protected]
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Darshan Sen [email protected]
Reviewed-By: Michaël Zasso [email protected]
Reviewed-By: Chengzhong Wu [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Ruy Adorno [email protected]

[detached HEAD 34119b1e9a] meta: clarify nomination process according to Node.js charter
Author: Matteo Collina [email protected]
Date: Tue Nov 21 09:59:10 2023 +0100
1 file changed, 3 insertions(+)
Rebasing (3/8)
Rebasing (4/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update GOVERNANCE.md

Co-authored-by: Gireesh Punathil [email protected]
PR-URL: #50834
Reviewed-By: Gireesh Punathil [email protected]
Reviewed-By: Rafael Gonzaga [email protected]
Reviewed-By: Robert Nagy [email protected]
Reviewed-By: Yagiz Nizipli [email protected]
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: Michael Dawson [email protected]
Reviewed-By: Joyee Cheung [email protected]
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Darshan Sen [email protected]
Reviewed-By: Michaël Zasso [email protected]
Reviewed-By: Chengzhong Wu [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Ruy Adorno [email protected]

[detached HEAD 676df9d944] Update GOVERNANCE.md
Author: Matteo Collina [email protected]
Date: Tue Nov 21 10:13:59 2023 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (5/8)
Rebasing (6/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update GOVERNANCE.md

Co-authored-by: Michael Dawson [email protected]
PR-URL: #50834
Reviewed-By: Gireesh Punathil [email protected]
Reviewed-By: Rafael Gonzaga [email protected]
Reviewed-By: Robert Nagy [email protected]
Reviewed-By: Yagiz Nizipli [email protected]
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: Michael Dawson [email protected]
Reviewed-By: Joyee Cheung [email protected]
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Darshan Sen [email protected]
Reviewed-By: Michaël Zasso [email protected]
Reviewed-By: Chengzhong Wu [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Ruy Adorno [email protected]

[detached HEAD 07dc7aa427] Update GOVERNANCE.md
Author: Matteo Collina [email protected]
Date: Tue Nov 21 15:42:33 2023 +0100
1 file changed, 3 insertions(+), 5 deletions(-)
Rebasing (7/8)
Rebasing (8/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update GOVERNANCE.md

Co-authored-by: Antoine du Hamel [email protected]
PR-URL: #50834
Reviewed-By: Gireesh Punathil [email protected]
Reviewed-By: Rafael Gonzaga [email protected]
Reviewed-By: Robert Nagy [email protected]
Reviewed-By: Yagiz Nizipli [email protected]
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: Michael Dawson [email protected]
Reviewed-By: Joyee Cheung [email protected]
Reviewed-By: Benjamin Gruenbaum [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Darshan Sen [email protected]
Reviewed-By: Michaël Zasso [email protected]
Reviewed-By: Chengzhong Wu [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Ruy Adorno [email protected]

[detached HEAD 1a972e305a] Update GOVERNANCE.md
Author: Matteo Collina [email protected]
Date: Wed Nov 22 10:35:08 2023 +0100
1 file changed, 3 insertions(+), 3 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/6991191399

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mcollina mcollina added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Nov 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 26, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 5f8ec99 into nodejs:main Nov 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2023

Copy link
Copy Markdown
Collaborator

Landed in 5f8ec99

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@mcollina Lei Shi
meta: clarify nomination process according to Node.js charter
810905c
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: nodejs#50834
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 27, 2023
@mcollina @RafaelGSS
meta: clarify nomination process according to Node.js charter
24db92e
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #50834
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
v21.3.0 proposal #50954
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@mcollina @RafaelGSS
meta: clarify nomination process according to Node.js charter
1a0069b
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #50834
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@mcollina @UlisesGascon
meta: clarify nomination process according to Node.js charter
138263f
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #50834
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@mcollina @UlisesGascon
meta: clarify nomination process according to Node.js charter
ba6d365
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #50834
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@mcollina @UlisesGascon
meta: clarify nomination process according to Node.js charter
0d04c8a
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #50834
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@mcollina @UlisesGascon
meta: clarify nomination process according to Node.js charter
0c85ceb
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #50834
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@aduh95 aduh95 aduh95 approved these changes
@ruyadorno ruyadorno ruyadorno approved these changes
@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@ronag ronag ronag approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@legendecas legendecas legendecas approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+2 more reviewers
@targos targos targos approved these changes
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

17 participants

@mcollina @nodejs-github-bot @GeoffreyBooth @ruyadorno @jasnell @benjamingr @lpinca @anonrig @targos @ronag @joyeecheung @gireeshpunathil @legendecas @mhdawson @aduh95 @RafaelGSS @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.