GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||
GeezerVison is showing github.com — meta: clarify nomination process according to Node.js charter by mcollina · Pull Request #50834 · nodejs/node Conversation
|
|
Review requested:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Gireesh Punathil <[email protected]>
|
I don't see how that comment led to this. And this language feels harsh; mentioning directly that the TSC might overrule an objection feels like it would chill people making objections. Doesn't the TSC already have this power without needing to add this text? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Yes. Apparently a few other TSC members think it is required to explicit it out. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Michael Dawson <[email protected]>
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Antoine du Hamel <[email protected]>
| the nomination fails. | ||
| The nomination passes if no collaborators oppose it after one week. In the case | ||
| of an objection, the TSC is responsible for working with the individuals | ||
| involved and finding a resolution. |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
| involved and finding a resolution. | |
| involved and finding a resolution. The TSC may, at its discretion, vote to override | |
| any objection but should do so only after other measures to reach consensus have | |
| failed. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I prefer the existing phrasing since it says the TSC is responsible for resolving the matter rather than just voting. The TSC for example can come to consensus about overriding a nomination without voting. It also emphasizes the TSC working with the individuals rather than them having to reach consensus on their own.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, consider it optional. Otherwise LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Commit Queue failed- Loading data for nodejs/node/pull/50834 ✔ Done loading data for nodejs/node/pull/50834 ----------------------------------- PR info ------------------------------------ Title meta: clarify nomination process according to Node.js charter (#50834) Author Matteo Collina (@mcollina) Branch mcollina:clarify-nomination-process -> nodejs:main Labels meta Commits 4 - meta: clarify nomination process according to Node.js charter - Update GOVERNANCE.md - Update GOVERNANCE.md - Update GOVERNANCE.md Committers 2 - Matteo Collina - GitHub PR-URL: https://github.com/nodejs/node/pull/50834 Reviewed-By: Gireesh Punathil Reviewed-By: Rafael Gonzaga Reviewed-By: Robert Nagy Reviewed-By: Yagiz Nizipli Reviewed-By: Antoine du Hamel Reviewed-By: Michael Dawson Reviewed-By: Joyee Cheung Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen Reviewed-By: Michaël Zasso Reviewed-By: Chengzhong Wu Reviewed-By: James M Snell Reviewed-By: Ruy Adorno ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50834 Reviewed-By: Gireesh Punathil Reviewed-By: Rafael Gonzaga Reviewed-By: Robert Nagy Reviewed-By: Yagiz Nizipli Reviewed-By: Antoine du Hamel Reviewed-By: Michael Dawson Reviewed-By: Joyee Cheung Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen Reviewed-By: Michaël Zasso Reviewed-By: Chengzhong Wu Reviewed-By: James M Snell Reviewed-By: Ruy Adorno -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 21 Nov 2023 08:59:46 GMT ✔ Approvals: 14 ✔ - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1741455492 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742081465 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742112546 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742210875 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742213614 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742224874 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742622759 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1742635069 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50834#pullrequestreview-1743060178 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1743672722 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1743943202 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1743957631 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1748043163 ✔ - Ruy Adorno (@ruyadorno) (TSC): https://github.com/nodejs/node/pull/50834#pullrequestreview-1748302024 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50834 From https://github.com/nodejs/node * branch refs/pull/50834/merge -> FETCH_HEAD ✔ Fetched commits as ed5cb37ccbc4..ea35554c7d75 -------------------------------------------------------------------------------- [main af5b57919e] meta: clarify nomination process according to Node.js charter Author: Matteo Collina Date: Tue Nov 21 09:59:10 2023 +0100 1 file changed, 3 insertions(+) [main f41d89451f] Update GOVERNANCE.md Author: Matteo Collina Date: Tue Nov 21 10:13:59 2023 +0100 1 file changed, 1 insertion(+), 1 deletion(-) [main b03aacd5a2] Update GOVERNANCE.md Author: Matteo Collina Date: Tue Nov 21 15:42:33 2023 +0100 1 file changed, 3 insertions(+), 5 deletions(-) [main 6d64197199] Update GOVERNANCE.md Author: Matteo Collina Date: Wed Nov 22 10:35:08 2023 +0100 1 file changed, 3 insertions(+), 3 deletions(-) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/8)https://github.com/nodejs/node/actions/runs/6991191399 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Landed in 5f8ec99 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Signed-off-by: Matteo Collina <[email protected]> PR-URL: nodejs#50834 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #50834 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #50834 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #50834 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #50834 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #50834 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #50834 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruy Adorno <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.