GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add CanadaHonk to triagers by CanadaHonk · Pull Request #50848 · nodejs/node

Conversation

@CanadaHonk

@CanadaHonk CanadaHonk commented Nov 21, 2023

Copy link
Copy Markdown
Member

I started making PRs and discussing in issues a few months ago, mostly perf related. Becoming a triager helps the workflow and is more of a commitment for the future :)

I have read the Code of Conduct plus Triage Guide and agree to both. Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil, aduh95, H4ad, pluris, debadree25, and mertcanaltin reacted with heart emoji
All reactions
  • ❤️ 6 reactions
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Nov 21, 2023
anonrig
anonrig approved these changes Nov 21, 2023
View reviewed changes

@anonrig anonrig left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely yes!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
joyeecheung
joyeecheung approved these changes Nov 22, 2023
View reviewed changes
H4ad
H4ad approved these changes Nov 22, 2023
View reviewed changes
Ayase-252
Ayase-252 approved these changes Nov 22, 2023
View reviewed changes
RaisinTen
RaisinTen approved these changes Nov 22, 2023
View reviewed changes

@RaisinTen RaisinTen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! 🎉
cc @nodejs/issue-triage

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
meixg
meixg approved these changes Nov 22, 2023
View reviewed changes
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 22, 2023
gireeshpunathil
gireeshpunathil approved these changes Nov 22, 2023
View reviewed changes
marsonya
marsonya approved these changes Nov 22, 2023
View reviewed changes
VoltrexKeyva
VoltrexKeyva approved these changes Nov 22, 2023
View reviewed changes

@VoltrexKeyva VoltrexKeyva left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 22, 2023
@gireeshpunathil

gireeshpunathil commented Nov 22, 2023

Copy link
Copy Markdown
Member

@CanadaHonk - looks like your email id is not configured in git, it is appearing as GitHub default [email protected]. Do you want to try pushing again by setting those?

ref: https://docs.github.com/en/get-started/getting-started-with-git/setting-your-username-in-git
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@CanadaHonk
CanadaHonk force-pushed the canadahonk-triager branch from b82127e to 05b36ce Compare November 22, 2023 14:30
H4ad
H4ad approved these changes Nov 22, 2023
View reviewed changes
@CanadaHonk
doc: add CanadaHonk to triagers
bddb0b2
@CanadaHonk
CanadaHonk force-pushed the canadahonk-triager branch from 05b36ce to bddb0b2 Compare November 22, 2023 14:33
@CanadaHonk

CanadaHonk commented Nov 22, 2023

Copy link
Copy Markdown
Member Author

Sorry, should be fixed now :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil pushed a commit that referenced this pull request Nov 22, 2023
@CanadaHonk @gireeshpunathil
doc: add CanadaHonk to triagers
081474b 
PR-URL: #50848
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@gireeshpunathil

gireeshpunathil commented Nov 22, 2023

Copy link
Copy Markdown
Member

landed in 081474b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gireeshpunathil gireeshpunathil closed this Nov 22, 2023
@gireeshpunathil

gireeshpunathil commented Nov 22, 2023

Copy link
Copy Markdown
Member

invitation sent for joining the triage team 🎉
CanadaHonk and H4ad reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Nov 23, 2023
@CanadaHonk @targos
doc: add CanadaHonk to triagers
ebc6fe8 
PR-URL: #50848
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@CanadaHonk Lei Shi
doc: add CanadaHonk to triagers
3c46275 
PR-URL: nodejs#50848
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
v21.3.0 proposal #50954
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@CanadaHonk @RafaelGSS
doc: add CanadaHonk to triagers
e116fcd 
PR-URL: #50848
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@CanadaHonk @UlisesGascon
doc: add CanadaHonk to triagers
1fef045 
PR-URL: #50848
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@CanadaHonk @UlisesGascon
doc: add CanadaHonk to triagers
033c482 
PR-URL: #50848
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@CanadaHonk @UlisesGascon
doc: add CanadaHonk to triagers
135ec0a 
PR-URL: #50848
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@CanadaHonk @UlisesGascon
doc: add CanadaHonk to triagers
30baacb 
PR-URL: #50848
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@mertcanaltin

mertcanaltin commented Jan 14, 2024

Copy link
Copy Markdown
Member

Welcome aboard ❤️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@Ayase-252 Ayase-252 Ayase-252 approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@meixg meixg meixg approved these changes
@H4ad H4ad H4ad approved these changes
@marsonya marsonya marsonya approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

14 participants

@CanadaHonk @gireeshpunathil @mertcanaltin @anonrig @joyeecheung @Ayase-252 @meixg @H4ad @marsonya @RaisinTen @VoltrexKeyva @panva @aduh95 @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.